From 93a74d6700dbe639c3368931d47d56d545293014 Mon Sep 17 00:00:00 2001 From: Scott Long Date: Tue, 23 Jul 2019 14:49:21 -0700 Subject: [PATCH] gpu: nvgpu: fix MISRA 10.5 issue in syncpt code This change switches nvgpu_nvhost_syncpt_is_expired_ext() to return a bool instead of an int to remove advisory rule MISRA 10.5 violations. MISRA 10.5 states that the value of an expression should not be cast to an inappropriate essential type. JIRA NVGPU-3798 Change-Id: Ie0772ac7167a3c999129de0dc7f22cd96faa28fc Signed-off-by: Scott Long Reviewed-on: https://git-master.nvidia.com/r/2159801 Reviewed-by: svc-mobile-coverity GVS: Gerrit_Virtual_Submit Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Adeel Raza Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/include/nvgpu/nvhost.h | 2 +- drivers/gpu/nvgpu/os/linux/nvhost.c | 2 +- drivers/gpu/nvgpu/os/posix/posix-nvhost.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/nvgpu/include/nvgpu/nvhost.h b/drivers/gpu/nvgpu/include/nvgpu/nvhost.h index dd2e64d2e..2bb22cf4e 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/nvhost.h +++ b/drivers/gpu/nvgpu/include/nvgpu/nvhost.h @@ -41,7 +41,7 @@ void nvgpu_nvhost_module_idle_ext(struct nvgpu_nvhost_dev *nvhost_dev); void nvgpu_nvhost_debug_dump_device(struct nvgpu_nvhost_dev *nvhost_dev); -int nvgpu_nvhost_syncpt_is_expired_ext(struct nvgpu_nvhost_dev *nvhost_dev, +bool nvgpu_nvhost_syncpt_is_expired_ext(struct nvgpu_nvhost_dev *nvhost_dev, u32 id, u32 thresh); int nvgpu_nvhost_syncpt_wait_timeout_ext(struct nvgpu_nvhost_dev *nvhost_dev, u32 id, u32 thresh, u32 timeout, u32 *value, struct timespec *ts); diff --git a/drivers/gpu/nvgpu/os/linux/nvhost.c b/drivers/gpu/nvgpu/os/linux/nvhost.c index ff9c3379e..3605560be 100644 --- a/drivers/gpu/nvgpu/os/linux/nvhost.c +++ b/drivers/gpu/nvgpu/os/linux/nvhost.c @@ -97,7 +97,7 @@ bool nvgpu_nvhost_syncpt_is_valid_pt_ext( return nvhost_syncpt_is_valid_pt_ext(nvhost_dev->host1x_pdev, id); } -int nvgpu_nvhost_syncpt_is_expired_ext( +bool nvgpu_nvhost_syncpt_is_expired_ext( struct nvgpu_nvhost_dev *nvhost_dev, u32 id, u32 thresh) { return nvhost_syncpt_is_expired_ext(nvhost_dev->host1x_pdev, diff --git a/drivers/gpu/nvgpu/os/posix/posix-nvhost.c b/drivers/gpu/nvgpu/os/posix/posix-nvhost.c index 53d75171c..c5d81e6ac 100644 --- a/drivers/gpu/nvgpu/os/posix/posix-nvhost.c +++ b/drivers/gpu/nvgpu/os/posix/posix-nvhost.c @@ -68,11 +68,11 @@ bool nvgpu_nvhost_syncpt_is_valid_pt_ext( return false; } -int nvgpu_nvhost_syncpt_is_expired_ext( +bool nvgpu_nvhost_syncpt_is_expired_ext( struct nvgpu_nvhost_dev *nvhost_dev, u32 id, u32 thresh) { BUG(); - return 0; + return false; } u32 nvgpu_nvhost_syncpt_incr_max_ext(