nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 17:36:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: nvgpu_cond_signal to return void

Browse Source 
MISRA Rule-17.7 requires the return value of all functions to be used.
Fix is either to use the return value or change the function to return
void. This patch changes nvgpu_cond_signal and nvgpu_cond_signal_interruptible
to return void since no callers were using the return value.

JIRA NVGPU-677

Change-Id: I406309bde247e7ca656c91be1ea5ab742b0a045a
Signed-off-by: Nicolas Benech <nbenech@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2007563
Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-misra <svc-mobile-misra@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Nicolas Benech
2019-01-30 10:51:59 -05:00
committed by mobile promotions
parent 182aadfd71
commit 9467646a87
6 changed files with 13 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/gpu/nvgpu/os/linux/cond.c
View File

@@ -32,24 +32,18 @@ void nvgpu_cond_destroy(struct nvgpu_cond *cond)
cond->initialized = false;
}
int nvgpu_cond_signal(struct nvgpu_cond *cond)
void nvgpu_cond_signal(struct nvgpu_cond *cond)
{
if (!cond->initialized)
return -EINVAL;
BUG_ON(!cond->initialized);
wake_up(&cond->wq);
return 0;
}
int nvgpu_cond_signal_interruptible(struct nvgpu_cond *cond)
void nvgpu_cond_signal_interruptible(struct nvgpu_cond *cond)
{
if (!cond->initialized)
return -EINVAL;
BUG_ON(!cond->initialized);
wake_up_interruptible(&cond->wq);
return 0;
}
int nvgpu_cond_broadcast(struct nvgpu_cond *cond)