From 9edd68ac52f8b8f7ca9a564f4a52bbea9c167a2c Mon Sep 17 00:00:00 2001 From: Alex Waterman Date: Fri, 12 Apr 2019 12:17:45 -0700 Subject: [PATCH] nvgpu: gpu: posix: Fix order of memset() after malloc() A memset was being done right before checking the malloc'ed pointer for NULL. This completely ruins the purpose of the NULL check! Change-Id: I3d6bc000f20054b5ff18d1171e51b227628ccf7c Signed-off-by: Alex Waterman Reviewed-on: https://git-master.nvidia.com/r/2096466 Reviewed-by: Nicolas Benech Reviewed-by: svc-mobile-coverity Reviewed-by: svc-mobile-misra Reviewed-by: Philip Elcan GVS: Gerrit_Virtual_Submit Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/os/posix/nvgpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nvgpu/os/posix/nvgpu.c b/drivers/gpu/nvgpu/os/posix/nvgpu.c index f9cd2aacd..94ba24a42 100644 --- a/drivers/gpu/nvgpu/os/posix/nvgpu.c +++ b/drivers/gpu/nvgpu/os/posix/nvgpu.c @@ -82,12 +82,13 @@ struct gk20a *nvgpu_posix_probe(void) struct nvgpu_os_posix *p; p = malloc(sizeof(*p)); - (void) memset(p, 0, sizeof(*p)); if (p == NULL) { return NULL; } + (void) memset(p, 0, sizeof(*p)); + g = &p->g; g->log_mask = 0; g->mm.g = g;