gpu: nvgpu: remove unnecessary hal gops.gr.gr_enable_hw()

gops.gr.gr_enable_hw() is a common function and not referred on vGPU.
Remove HAL pointer and directly use nvgpu_gr_enable_hw() instead.

Jira NVGPU-5648

Change-Id: Id031024ed01f9d890cffb5902cc433800810b219
Signed-off-by: Deepak Nibade <dnibade@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2403548
Reviewed-by: automaticguardword <automaticguardword@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-misra <svc-mobile-misra@nvidia.com>
Reviewed-by: svc-mobile-cert <svc-mobile-cert@nvidia.com>
Reviewed-by: Lakshmanan M <lm@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Deepak Nibade
2020-08-21 18:00:22 +05:30
committed by Alex Waterman
parent e773cb6087
commit a2809088eb
10 changed files with 2 additions and 25 deletions

View File

@@ -659,7 +659,7 @@ int nvgpu_finalize_poweron(struct gk20a *g)
NVGPU_INIT_TABLE_ENTRY(&nvgpu_netlist_init_ctx_vars, NO_FLAG), NVGPU_INIT_TABLE_ENTRY(&nvgpu_netlist_init_ctx_vars, NO_FLAG),
/* prepare portion of sw required for enable hw */ /* prepare portion of sw required for enable hw */
NVGPU_INIT_TABLE_ENTRY(&nvgpu_gr_alloc, NO_FLAG), NVGPU_INIT_TABLE_ENTRY(&nvgpu_gr_alloc, NO_FLAG),
NVGPU_INIT_TABLE_ENTRY(g->ops.gr.gr_enable_hw, NO_FLAG), NVGPU_INIT_TABLE_ENTRY(&nvgpu_gr_enable_hw, NO_FLAG),
NVGPU_INIT_TABLE_ENTRY(g->ops.acr.acr_construct_execute, NVGPU_INIT_TABLE_ENTRY(g->ops.acr.acr_construct_execute,
NVGPU_SEC_PRIVSECURITY), NVGPU_SEC_PRIVSECURITY),
#ifdef CONFIG_NVGPU_DGPU #ifdef CONFIG_NVGPU_DGPU

View File

@@ -190,7 +190,6 @@ static const struct gpu_ops gm20b_ops = {
.isr_nonstall = gk20a_ce2_nonstall_isr, .isr_nonstall = gk20a_ce2_nonstall_isr,
}, },
.gr = { .gr = {
.gr_enable_hw = nvgpu_gr_enable_hw,
.gr_init_support = nvgpu_gr_init_support, .gr_init_support = nvgpu_gr_init_support,
.gr_suspend = nvgpu_gr_suspend, .gr_suspend = nvgpu_gr_suspend,
#ifdef CONFIG_NVGPU_DEBUGGER #ifdef CONFIG_NVGPU_DEBUGGER

View File

@@ -238,7 +238,6 @@ static const struct gpu_ops gp10b_ops = {
.isr_nonstall = gp10b_ce_nonstall_isr, .isr_nonstall = gp10b_ce_nonstall_isr,
}, },
.gr = { .gr = {
.gr_enable_hw = nvgpu_gr_enable_hw,
.gr_init_support = nvgpu_gr_init_support, .gr_init_support = nvgpu_gr_init_support,
.gr_suspend = nvgpu_gr_suspend, .gr_suspend = nvgpu_gr_suspend,
#ifdef CONFIG_NVGPU_DEBUGGER #ifdef CONFIG_NVGPU_DEBUGGER

View File

@@ -305,7 +305,6 @@ NVGPU_COV_WHITELIST_BLOCK_END(NVGPU_MISRA(Rule, 8_7))
.init_prod_values = gv11b_ce_init_prod_values, .init_prod_values = gv11b_ce_init_prod_values,
}, },
.gr = { .gr = {
.gr_enable_hw = nvgpu_gr_enable_hw,
.gr_init_support = nvgpu_gr_init_support, .gr_init_support = nvgpu_gr_init_support,
.gr_suspend = nvgpu_gr_suspend, .gr_suspend = nvgpu_gr_suspend,
#ifdef CONFIG_NVGPU_DEBUGGER #ifdef CONFIG_NVGPU_DEBUGGER

View File

@@ -350,7 +350,6 @@ static const struct gpu_ops tu104_ops = {
.init_prod_values = gv11b_ce_init_prod_values, .init_prod_values = gv11b_ce_init_prod_values,
}, },
.gr = { .gr = {
.gr_enable_hw = nvgpu_gr_enable_hw,
.gr_init_support = nvgpu_gr_init_support, .gr_init_support = nvgpu_gr_init_support,
.gr_suspend = nvgpu_gr_suspend, .gr_suspend = nvgpu_gr_suspend,
#ifdef CONFIG_NVGPU_DEBUGGER #ifdef CONFIG_NVGPU_DEBUGGER

View File

@@ -175,7 +175,6 @@ static const struct gpu_ops vgpu_gp10b_ops = {
.get_num_pce = vgpu_ce_get_num_pce, .get_num_pce = vgpu_ce_get_num_pce,
}, },
.gr = { .gr = {
.gr_enable_hw = nvgpu_gr_enable_hw,
.gr_init_support = nvgpu_gr_init_support, .gr_init_support = nvgpu_gr_init_support,
.gr_suspend = nvgpu_gr_suspend, .gr_suspend = nvgpu_gr_suspend,
#ifdef CONFIG_NVGPU_DEBUGGER #ifdef CONFIG_NVGPU_DEBUGGER

View File

@@ -234,7 +234,6 @@ static const struct gpu_ops vgpu_gv11b_ops = {
.get_num_pce = vgpu_ce_get_num_pce, .get_num_pce = vgpu_ce_get_num_pce,
}, },
.gr = { .gr = {
.gr_enable_hw = nvgpu_gr_enable_hw,
.gr_init_support = nvgpu_gr_init_support, .gr_init_support = nvgpu_gr_init_support,
.gr_suspend = nvgpu_gr_suspend, .gr_suspend = nvgpu_gr_suspend,
#ifdef CONFIG_NVGPU_DEBUGGER #ifdef CONFIG_NVGPU_DEBUGGER

View File

@@ -998,22 +998,6 @@ struct gops_gr_zcull {
* @see gpu_ops * @see gpu_ops
*/ */
struct gops_gr { struct gops_gr {
/**
* @brief Enable GR engine h/w.
*
* @param g [in] Pointer to GPU driver struct.
*
* This HAL enables GR engine h/w.
* This HAL always maps to #nvgpu_gr_enable_hw.
*
* @return 0 in case of success, < 0 in case of failure.
* @retval -ETIMEDOUT if falcon mem scrubbing times out.
* @retval -EAGAIN if GR engine idle wait times out.
*
* @see nvgpu_gr_enable_hw
*/
int (*gr_enable_hw)(struct gk20a *g);
/** /**
* @brief Initialize GR engine support. * @brief Initialize GR engine support.
* *

View File

@@ -83,7 +83,7 @@ int test_gr_remove_setup(struct unit_module *m, struct gk20a *g, void *args);
* *
* Test Type: Feature * Test Type: Feature
* *
* Targets: gops_gr.gr_enable_hw, nvgpu_gr_enable_hw, * Targets: nvgpu_gr_enable_hw,
* gops_gr_intr.enable_hww_exceptions, * gops_gr_intr.enable_hww_exceptions,
* gv11b_gr_intr_enable_hww_exceptions, * gv11b_gr_intr_enable_hww_exceptions,
* gops_gr_intr.enable_interrupts, * gops_gr_intr.enable_interrupts,

View File

@@ -404,7 +404,6 @@ static void set_poweron_funcs_success(struct gk20a *g)
setup_simple_init_func_success(&g->ops.mm.init_mm_support, i++); setup_simple_init_func_success(&g->ops.mm.init_mm_support, i++);
setup_simple_init_func_success(&g->ops.fifo.fifo_init_support, i++); setup_simple_init_func_success(&g->ops.fifo.fifo_init_support, i++);
setup_simple_init_func_success(&g->ops.therm.elcg_init_idle_filters, i++); setup_simple_init_func_success(&g->ops.therm.elcg_init_idle_filters, i++);
setup_simple_init_func_success(&g->ops.gr.gr_enable_hw, i++);
setup_simple_init_func_success(&g->ops.fbp.fbp_init_support, i++); setup_simple_init_func_success(&g->ops.fbp.fbp_init_support, i++);
setup_simple_init_func_success(&g->ops.gr.gr_init_support, i++); setup_simple_init_func_success(&g->ops.gr.gr_init_support, i++);
setup_simple_init_func_success(&g->ops.ecc.ecc_finalize_support, i++); setup_simple_init_func_success(&g->ops.ecc.ecc_finalize_support, i++);