nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 09:12:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

scripts: rfr: explicitly use gerrit cl if needed

Browse Source 
Fetch the full patch information from gerrit as soon as possible, so
that the gerrit cl (i.e., git-master url) is used if given, because it
has more information than the change-id (which may exist in multiple
branches).

Querying based on change-id or git commit-id are left as-is.

Change-Id: I58dfa9da7354d607ca7e38f91e4a5f2c92c8454f
Signed-off-by: Konsta Holtta <kholtta@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1585436
Reviewed-by: Alex Waterman <alexw@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vijayakumar Subbu <vsubbu@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Konsta Holtta
2017-10-25 15:16:09 +03:00
committed by mobile promotions
parent 8221a19e13
commit b5b9e71bd5
1 changed files with 12 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
scripts/rfr
View File

@@ -113,20 +113,16 @@ def commit_info_from_gerrit_change_id(change_id):
return gerrit_query(change_id) return gerrit_query(change_id)
def gerrit_change_id_from_gerrit_cl(cmt): def commit_info_from_gerrit_cl(cmt):
""" """
Return the gerrit Change-Id from the passed Gerrit URL. Return a dict with all the gerrit info from a Gerrit URL.
""" """
cl = get_gerrit_url_id(cmt) cl = get_gerrit_url_id(cmt)
if not cl: if not cl:
return None return None
commit = gerrit_query(cl) return gerrit_query(cl)
if not commit:
return None
return commit['id']
def gerrit_change_id_from_git_commit(cmt_id): def gerrit_change_id_from_git_commit(cmt_id):
""" """
@@ -157,9 +153,9 @@ def indent_lines(text, ind):
""" """
return ''.join(ind + l + '\n' for l in text.splitlines()) return ''.join(ind + l + '\n' for l in text.splitlines())
def display_commits(commits, extra_message): def display_commits(commits_info, extra_message):
""" """
Takes a list of the commits to print. Takes a list of the commit info objects to print.
""" """
whole_template = """ whole_template = """
@@ -178,10 +174,6 @@ Thanks!
{cmtmsg}""" {cmtmsg}"""
commits_info = [ ]
for cmt in commits:
commits_info.append(commit_info_from_gerrit_change_id(cmt))
cmt_descriptions = '' cmt_descriptions = ''
for c in commits_info: for c in commits_info:
cmt_descriptions += " %s - %s\n" % (c['url'], c['subject']) cmt_descriptions += " %s - %s\n" % (c['url'], c['subject'])
@@ -210,7 +202,7 @@ def main():
""" """
arg_parser = parse_args() arg_parser = parse_args()
commits = [ ] commits_info = [ ]
if arg_parser.version: if arg_parser.version:
print('Version: %s' % VERSION) print('Version: %s' % VERSION)
@@ -224,18 +216,18 @@ def main():
# on the order in which they pass the commits. # on the order in which they pass the commits.
for cmt in arg_parser.commits: for cmt in arg_parser.commits:
if cmt[0] == 'I': if cmt[0] == 'I':
cid = cmt info = commit_info_from_gerrit_change_id(cmt)
elif get_gerrit_url_id(cmt): elif get_gerrit_url_id(cmt):
cid = gerrit_change_id_from_gerrit_cl(cmt) info = commit_info_from_gerrit_cl(cmt)
else: else:
cid = gerrit_change_id_from_git_commit(cmt) info = commit_info_from_gerrit_change_id(gerrit_change_id_from_git_commit(cmt))
if cid: if info:
commits.append(cid) commits_info.append(info)
else: else:
print('Warning: \'%s\' doesn\'t appear to be a commit!' % cmt) print('Warning: \'%s\' doesn\'t appear to be a commit!' % cmt)
display_commits(commits, arg_parser.msg) display_commits(commits_info, arg_parser.msg)
if __name__ == '__main__': if __name__ == '__main__':
main() main()