nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-23 18:16:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: remove assert in devctl processing path

Browse Source 
Asserting in the path of devctl processing is not safe here because
incompr_kind can be passed out of range by a malicious app and it will
cause nvgpu-rm to crash. Instead return error in case of out of range
value.

Jira NVGPU-6496

Change-Id: I9c3264776110f606a67f27ce7b01fdce82aa3021
Signed-off-by: shashank singh <shashsingh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2485752
(cherry picked from commit 689054d65fff2c61b9f1d413eef4a44a5f27fc54)
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2492290
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
shashank singh
2021-02-17 16:52:20 +05:30
committed by mobile promotions
parent 625d942c52
commit b91f57d933
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/nvgpu/common/mm/vm.c
View File

@@ -1295,13 +1295,12 @@ static int nvgpu_vm_do_map(struct vm_gk20a *vm,
binfo_ptr->ctag_offset = ctag_offset; binfo_ptr->ctag_offset = ctag_offset;
} else } else
#endif #endif
if (binfo_ptr->incompr_kind != NVGPU_KIND_INVALID) { if ((binfo_ptr->incompr_kind >= 0) &&
(binfo_ptr->incompr_kind <= (s16)U8_MAX)) {
/* /*
* Incompressible kind, ctag offset will not be programmed * Incompressible kind, ctag offset will not be programmed
*/ */
ctag_offset = 0; ctag_offset = 0;
nvgpu_assert((binfo_ptr->incompr_kind >= 0) &&
(binfo_ptr->incompr_kind <= (s16)U8_MAX));
pte_kind = (u8)binfo_ptr->incompr_kind; pte_kind = (u8)binfo_ptr->incompr_kind;
} else { } else {
/* /*