gpu: nvgpu: boardobj update for gv10x branch

- Created ops for below boardobj methods to support gp10x & gv10x branch boardobj changes, and defined methods for gv10x with postfix _v1 with below names boardobjgrp_pmucmd_construct_impl boardobjgrp_pmuset_impl boardobjgrp_pmugetstatus_impl is_boardobjgrp_pmucmd_id_valid - These ops are assigned based on PMU version to respective chip. - Modified BOARDOBJGRP_PMU_CMD_GRP_SET_CONSTRUCT & BOARDOBJGRP_PMU_CMD_GRP_GET_STATUS_CONSTRUCT to support gp10x & gv10x branch changes - Updated struct boardobjgrp_pmu_cmd to include members needed for gv10x boardobj changes - Created "struct nv_pmu_rpc_struct_board_obj_grp_cmd" to execute BOARD_OBJ_GRP_CMD using RPC. - Defined method boardobjgrp_pmucmdsend_rpc() to send BOARD_OBJ_GRP_CMD to PMU. Change-Id: If2551bdda80e897e7b21d2966881586f3bbc7a9b Signed-off-by: Mahantesh Kumbar <mkumbar@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1656511 GVS: Gerrit_Virtual_Submit Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
2025-12-23 09:57:08 +03:00 · 2018-02-13 12:48:58 +05:30
parent cc4b9f540f
commit b94770dc4d
5 changed files with 319 additions and 43 deletions
--- a/drivers/gpu/nvgpu/boardobj/boardobjgrp.c
+++ b/drivers/gpu/nvgpu/boardobj/boardobjgrp.c
@@ -35,6 +35,10 @@ static boardobjgrp_pmustatusinstget boardobjgrp_pmustatusinstget_stub;
 static u32 boardobjgrp_pmucmdsend(struct gk20a *g,
 		struct boardobjgrp *pboardobjgrp,
 		struct boardobjgrp_pmu_cmd *pcmd);
+static u32 boardobjgrp_pmucmdsend_rpc(struct gk20a *g,
+		struct boardobjgrp *pboardobjgrp,
+		struct boardobjgrp_pmu_cmd *pcmd,
+		bool copy_out);
 struct boardobjgrp_pmucmdhandler_params {
 	/* Pointer to the BOARDOBJGRP associated with this CMD */
 	struct boardobjgrp *pboardobjgrp;
@@ -63,6 +67,8 @@ u32 boardobjgrp_construct_super(struct gk20a *g, struct boardobjgrp *pboardobjgr
 	pboardobjgrp->classid = 0;
 	pboardobjgrp->pmu.unitid = BOARDOBJGRP_UNIT_ID_INVALID;
 	pboardobjgrp->pmu.classid = BOARDOBJGRP_GRP_CLASS_ID_INVALID;
+	pboardobjgrp->pmu.bset = false;
+	pboardobjgrp->pmu.rpc_func_id = BOARDOBJGRP_GRP_RPC_FUNC_ID_INVALID;
 	pboardobjgrp->pmu.set.id = BOARDOBJGRP_GRP_CMD_ID_INVALID;
 	pboardobjgrp->pmu.getstatus.id = BOARDOBJGRP_GRP_CMD_ID_INVALID;

@@ -77,8 +83,10 @@ u32 boardobjgrp_construct_super(struct gk20a *g, struct boardobjgrp *pboardobjgr
 	pboardobjgrp->pmuinithandle = boardobjgrp_pmuinithandle_impl;
 	pboardobjgrp->pmuhdrdatainit = boardobjgrp_pmuhdrdatainit_super;
 	pboardobjgrp->pmudatainit = boardobjgrp_pmudatainit_super;
-	pboardobjgrp->pmuset = boardobjgrp_pmuset_impl;
-	pboardobjgrp->pmugetstatus = boardobjgrp_pmugetstatus_impl;
+	pboardobjgrp->pmuset =
+		g->ops.pmu_ver.boardobj.boardobjgrp_pmuset_impl;
+	pboardobjgrp->pmugetstatus =
+		g->ops.pmu_ver.boardobj.boardobjgrp_pmugetstatus_impl;

 	pboardobjgrp->pmudatainstget = boardobjgrp_pmudatainstget_stub;
 	pboardobjgrp->pmustatusinstget = boardobjgrp_pmustatusinstget_stub;
@@ -155,7 +163,7 @@ u32 boardobjgrp_destruct_super(struct boardobjgrp *pboardobjgrp)

 u32 boardobjgrp_pmucmd_construct_impl(struct gk20a *g, struct boardobjgrp
 	*pboardobjgrp, struct boardobjgrp_pmu_cmd *cmd, u8 id, u8 msgid,
-	u8 hdrsize, u8 entrysize, u16 fbsize)
+	u8 hdrsize, u8 entrysize, u16 fbsize,  u32 ss_offset, u8 rpc_func_id)
 {
 	gk20a_dbg_info("");

@@ -169,6 +177,22 @@ u32 boardobjgrp_pmucmd_construct_impl(struct gk20a *g, struct boardobjgrp
 	return 0;
 }

+u32 boardobjgrp_pmucmd_construct_impl_v1(struct gk20a *g, struct boardobjgrp
+	*pboardobjgrp, struct boardobjgrp_pmu_cmd *cmd, u8 id, u8 msgid,
+	u8 hdrsize, u8 entrysize, u16 fbsize, u32 ss_offset, u8 rpc_func_id)
+{
+	nvgpu_log_fn(g, " ");
+
+	/* Copy the parameters into the CMD*/
+	cmd->dmem_buffer_size = ((hdrsize > entrysize) ? hdrsize : entrysize);
+	cmd->super_surface_offset = ss_offset;
+	pboardobjgrp->pmu.rpc_func_id = rpc_func_id;
+	cmd->fbsize = fbsize;
+
+	nvgpu_log_fn(g, "DONE");
+	return 0;
+}
+
 u32 boardobjgrp_pmucmd_destroy_impl(struct gk20a *g,
 	struct boardobjgrp_pmu_cmd *cmd)
 {
@@ -178,6 +202,31 @@ u32 boardobjgrp_pmucmd_destroy_impl(struct gk20a *g,
 	return 0;
 }

+int is_boardobjgrp_pmucmd_id_valid_v0(struct gk20a *g,
+		struct boardobjgrp *pboardobjgrp,
+		struct boardobjgrp_pmu_cmd *pcmd)
+{
+	int err = 0;
+
+	if (pcmd->id == BOARDOBJGRP_GRP_CMD_ID_INVALID)
+		err = -EINVAL;
+
+	return err;
+}
+
+int is_boardobjgrp_pmucmd_id_valid_v1(struct gk20a *g,
+		struct boardobjgrp *pboardobjgrp,
+		struct boardobjgrp_pmu_cmd *cmd)
+{
+	int err = 0;
+
+	if (pboardobjgrp->pmu.rpc_func_id ==
+		BOARDOBJGRP_GRP_RPC_FUNC_ID_INVALID)
+		err = -EINVAL;
+
+	return err;
+}
+
 u32 boardobjgrp_pmucmd_pmuinithandle_impl(struct gk20a *g,
 	struct boardobjgrp *pboardobjgrp,
 	struct boardobjgrp_pmu_cmd *pcmd)
@@ -187,7 +236,8 @@ u32 boardobjgrp_pmucmd_pmuinithandle_impl(struct gk20a *g,

 	gk20a_dbg_info("");

-	if (pcmd->id == BOARDOBJGRP_GRP_CMD_ID_INVALID)
+	if (g->ops.pmu_ver.boardobj.is_boardobjgrp_pmucmd_id_valid(g,
+			pboardobjgrp, pcmd))
 		goto boardobjgrp_pmucmd_pmuinithandle_exit;

 	nvgpu_pmu_sysmem_surface_alloc(g, sysmem_desc, pcmd->fbsize);
@@ -223,7 +273,8 @@ u32 boardobjgrp_pmuinithandle_impl(struct gk20a *g,
 	}

 	/* If the GRP_SET CMD has not been allocated, nothing left to do. */
-	if (((pboardobjgrp->pmu.set.id) == BOARDOBJGRP_GRP_CMD_ID_INVALID) ||
+	if ((g->ops.pmu_ver.boardobj.is_boardobjgrp_pmucmd_id_valid(g,
+			pboardobjgrp, &pboardobjgrp->pmu.set))||
 		(BOARDOBJGRP_IS_EMPTY(pboardobjgrp)))
 		goto boardobjgrp_pmuinithandle_exit;

@@ -369,12 +420,9 @@ boardobjgrppmudatainit_super_done:
 	return status;
 }

-u32 boardobjgrp_pmuset_impl(struct gk20a *g, struct boardobjgrp *pboardobjgrp)
+static int check_boardobjgrp_param(struct gk20a *g,
+		struct boardobjgrp *pboardobjgrp)
 {
-	u32 status = 0;
-	struct boardobjgrp_pmu_cmd *pcmd = &pboardobjgrp->pmu.set;
-	gk20a_dbg_info("");
-
 	if (pboardobjgrp == NULL)
 		return -EINVAL;

@@ -387,6 +435,24 @@ u32 boardobjgrp_pmuset_impl(struct gk20a *g, struct boardobjgrp *pboardobjgrp)
 	if (pboardobjgrp->pmu.classid == BOARDOBJGRP_GRP_CLASS_ID_INVALID)
 		return -EINVAL;

+	/* If no objects in the group, return early */
+	if (BOARDOBJGRP_IS_EMPTY(pboardobjgrp))
+		return -EINVAL;
+
+	return 0;
+}
+
+u32 boardobjgrp_pmuset_impl(struct gk20a *g, struct boardobjgrp *pboardobjgrp)
+{
+	u32 status = 0;
+	struct boardobjgrp_pmu_cmd *pcmd =
+		(struct boardobjgrp_pmu_cmd *)(&pboardobjgrp->pmu.set);
+
+	gk20a_dbg_info("");
+
+	if (check_boardobjgrp_param(g, pboardobjgrp))
+		return -EINVAL;
+
 	if (pboardobjgrp->pmu.set.id == BOARDOBJGRP_GRP_CMD_ID_INVALID)
 		return -EINVAL;

@@ -395,10 +461,6 @@ u32 boardobjgrp_pmuset_impl(struct gk20a *g, struct boardobjgrp *pboardobjgrp)
 		(pcmd->buf == NULL))
 		return -EINVAL;

-	/* If no objects in the group, return early */
-	if (BOARDOBJGRP_IS_EMPTY(pboardobjgrp))
-		return -EINVAL;
-
 	/* Initialize PMU buffer with BOARDOBJGRP data. */
 	memset(pcmd->buf, 0x0, pcmd->fbsize);
 	status = pboardobjgrp->pmudatainit(g, pboardobjgrp,
@@ -438,29 +500,76 @@ boardobjgrp_pmuset_exit:
 	return status;
 }

+u32 boardobjgrp_pmuset_impl_v1(struct gk20a *g, struct boardobjgrp *pboardobjgrp)
+{
+	struct nvgpu_pmu *pmu = &g->pmu;
+	u32 status = 0;
+	struct boardobjgrp_pmu_cmd *pcmd =
+		(struct boardobjgrp_pmu_cmd *)(&pboardobjgrp->pmu.set);
+
+	gk20a_dbg_info("");
+
+	if (check_boardobjgrp_param(g, pboardobjgrp))
+		return -EINVAL;
+
+	if ((pcmd->buf == NULL) &&
+		(pboardobjgrp->pmu.rpc_func_id ==
+		BOARDOBJGRP_GRP_RPC_FUNC_ID_INVALID))
+		return -EINVAL;
+
+	/* Initialize PMU buffer with BOARDOBJGRP data. */
+	memset(pcmd->buf, 0x0, pcmd->fbsize);
+	status = pboardobjgrp->pmudatainit(g, pboardobjgrp,
+			pcmd->buf);
+	if (status) {
+		nvgpu_err(g, "could not parse pmu data");
+		goto boardobjgrp_pmuset_exit;
+	}
+
+	/*
+	 * Reset the boolean that indicates set status
+	 * for most recent instance of BOARDOBJGRP.
+	 */
+	pboardobjgrp->pmu.bset = false;
+
+	/*
+	 * copy constructed pmu boardobjgrp data from
+	 * sysmem to pmu super surface present in FB
+	 */
+	nvgpu_mem_wr_n(g, &pmu->super_surface_buf,
+		pcmd->super_surface_offset, pcmd->buf,
+		pcmd->fbsize);
+
+	/* Send the SET PMU CMD to the PMU using RPC*/
+	status = boardobjgrp_pmucmdsend_rpc(g, pboardobjgrp,
+			pcmd, false);
+	if (status) {
+		nvgpu_err(g, "could not send SET CMD to PMU");
+		goto boardobjgrp_pmuset_exit;
+	}
+
+	pboardobjgrp->pmu.bset = true;
+
+boardobjgrp_pmuset_exit:
+	return status;
+}
+
 u32
 boardobjgrp_pmugetstatus_impl(struct gk20a *g, struct boardobjgrp *pboardobjgrp,
 	struct boardobjgrpmask *mask)
 {
 	u32 status  = 0;
-	struct boardobjgrp_pmu_cmd *pcmd = &pboardobjgrp->pmu.getstatus;
-	struct boardobjgrp_pmu_cmd *pset = &pboardobjgrp->pmu.set;
+	struct boardobjgrp_pmu_cmd *pcmd =
+		(struct boardobjgrp_pmu_cmd *)(&pboardobjgrp->pmu.getstatus);
+	struct boardobjgrp_pmu_cmd *pset =
+		(struct boardobjgrp_pmu_cmd *)(&pboardobjgrp->pmu.set);

 	gk20a_dbg_info("");

-	if (pboardobjgrp == NULL)
+	if (check_boardobjgrp_param(g, pboardobjgrp))
 		return -EINVAL;

-	if (!pboardobjgrp->bconstructed)
-		return -EINVAL;
-
-	if (pboardobjgrp->pmu.unitid == BOARDOBJGRP_UNIT_ID_INVALID)
-		return -EINVAL;
-
-	if (pboardobjgrp->pmu.classid == BOARDOBJGRP_GRP_CLASS_ID_INVALID)
-		return -EINVAL;
-
-	if (pboardobjgrp->pmu.set.id == BOARDOBJGRP_GRP_CMD_ID_INVALID)
+	if (pset->id == BOARDOBJGRP_GRP_CMD_ID_INVALID)
 		return -EINVAL;

 	if ((pcmd->hdrsize == 0) ||
@@ -468,10 +577,6 @@ boardobjgrp_pmugetstatus_impl(struct gk20a *g, struct boardobjgrp *pboardobjgrp,
 		(pcmd->buf == NULL))
 		return -EINVAL;

-	/* If no objects in the group, return early */
-	if (BOARDOBJGRP_IS_EMPTY(pboardobjgrp))
-		return -EINVAL;
-
 	/*
 	 * Can only GET_STATUS if the BOARDOBJGRP has been previously SET to the
 	 * PMU
@@ -517,6 +622,66 @@ boardobjgrp_pmugetstatus_exit:
 	return status;
 }

+u32
+boardobjgrp_pmugetstatus_impl_v1(struct gk20a *g, struct boardobjgrp *pboardobjgrp,
+	struct boardobjgrpmask *mask)
+{
+	struct nvgpu_pmu *pmu = &g->pmu;
+	u32 status  = 0;
+	struct boardobjgrp_pmu_cmd *pcmd =
+		(struct boardobjgrp_pmu_cmd *)(&pboardobjgrp->pmu.getstatus);
+
+	gk20a_dbg_info("");
+
+	if (check_boardobjgrp_param(g, pboardobjgrp))
+		return -EINVAL;
+
+	if ((pcmd->buf == NULL) &&
+		(pboardobjgrp->pmu.rpc_func_id ==
+		BOARDOBJGRP_GRP_RPC_FUNC_ID_INVALID))
+		return -EINVAL;
+
+	/*
+	 * Can only GET_STATUS if the BOARDOBJGRP has been
+	 * previously SET to the PMU
+	 */
+	if (!pboardobjgrp->pmu.bset)
+		return -EINVAL;
+
+	/*
+	 * Initialize PMU buffer with the mask of
+	 * BOARDOBJGRPs for which to retrieve status
+	 */
+	memset(pcmd->buf, 0x0, pcmd->fbsize);
+	status = pboardobjgrp->pmuhdrdatainit(g, pboardobjgrp,
+			pcmd->buf, mask);
+	if (status) {
+		nvgpu_err(g, "could not init PMU HDR data");
+		goto boardobjgrp_pmugetstatus_exit;
+	}
+
+	/*
+	 * copy constructed pmu boardobjgrp data from
+	 * sysmem to pmu super surface present in FB
+	 */
+	nvgpu_mem_wr_n(g, &pmu->super_surface_buf, pcmd->super_surface_offset,
+			pcmd->buf, pcmd->fbsize);
+	/* Send the GET_STATUS PMU CMD to the PMU */
+	status = boardobjgrp_pmucmdsend_rpc(g, pboardobjgrp,
+			pcmd, true);
+	if (status) {
+		nvgpu_err(g, "could not send GET_STATUS cmd to PMU");
+		goto boardobjgrp_pmugetstatus_exit;
+	}
+
+	/*copy the data back to sysmem buffer that belongs to command*/
+	nvgpu_mem_rd_n(g, &pmu->super_surface_buf,pcmd->super_surface_offset,
+		pcmd->buf, pcmd->fbsize);
+
+boardobjgrp_pmugetstatus_exit:
+	return status;
+}
+
 static u32
 boardobjgrp_objinsert_final(struct boardobjgrp *pboardobjgrp,
 	struct boardobj *pboardobj, u8 index)
@@ -785,3 +950,37 @@ static u32 boardobjgrp_pmucmdsend(struct gk20a *g,
 boardobjgrp_pmucmdsend_exit:
 	return status;
 }
+
+static u32 boardobjgrp_pmucmdsend_rpc(struct gk20a *g,
+	struct boardobjgrp *pboardobjgrp,
+	struct boardobjgrp_pmu_cmd *pcmd,
+	bool copy_out)
+{
+	struct nvgpu_pmu *pmu = &g->pmu;
+	struct nv_pmu_rpc_struct_board_obj_grp_cmd rpc;
+	int status = 0;
+
+	nvgpu_log_fn(g, " ");
+
+	memset(&rpc, 0, sizeof(struct nv_pmu_rpc_struct_board_obj_grp_cmd));
+
+	rpc.class_id = pboardobjgrp->pmu.classid;
+	rpc.command_id = copy_out ?
+		NV_PMU_BOARDOBJGRP_CMD_GET_STATUS :
+		NV_PMU_BOARDOBJGRP_CMD_SET;
+
+	rpc.hdr.unit_id   = pboardobjgrp->pmu.unitid;
+	rpc.hdr.function = pboardobjgrp->pmu.rpc_func_id;
+	rpc.hdr.flags    = 0x0;
+
+	status = nvgpu_pmu_rpc_execute(pmu, &(rpc.hdr),
+		(sizeof(rpc) - sizeof(rpc.scratch)),
+		pcmd->dmem_buffer_size,
+		NULL, NULL);
+
+	if (status) {
+		nvgpu_err(g, "Failed to execute RPC, status=0x%x", status);
+	}
+
+	return status;
+}
--- a/drivers/gpu/nvgpu/boardobj/boardobjgrp.h
+++ b/drivers/gpu/nvgpu/boardobj/boardobjgrp.h
@@ -123,7 +123,9 @@ struct boardobjgrp_pmu_cmd {
 	u8   msgid;
 	u8   hdrsize;
 	u8   entrysize;
-	u16  fbsize;
+	u16 dmem_buffer_size;
+	u32 super_surface_offset;
+	u32 fbsize;
 	struct nv_pmu_boardobjgrp_super *buf;
 	struct pmu_surface surf;
 };
@@ -136,6 +138,7 @@ struct boardobjgrp_pmu {
 	u8   unitid;
 	u8   classid;
 	bool bset;
+	u8 rpc_func_id;
 	struct boardobjgrp_pmu_cmd set;
 	struct boardobjgrp_pmu_cmd getstatus;
 };
@@ -148,7 +151,7 @@ struct boardobjgrp_pmu {
 typedef u32 boardobjgrp_pmucmd_construct(struct gk20a *g,
 		struct boardobjgrp *pboardobjgrp,
 		struct boardobjgrp_pmu_cmd *cmd, u8 id, u8 msgid,
-		u8 hdrsize, u8 entrysize, u16 fbsize);
+		u8 hdrsize, u8 entrysize, u16 fbsize, u32 ss_offset, u8 rpc_func_id);

 /*
 * Destroys BOARDOBJGRP PMU SW state.  CMD.
@@ -296,6 +299,7 @@ struct boardobjgrp {
 * are not supported.
 */
 #define BOARDOBJGRP_GRP_CMD_ID_INVALID                                255
+#define BOARDOBJGRP_GRP_RPC_FUNC_ID_INVALID                           255

 /*!
 * Helper macro to construct a BOARDOBJGRP's PMU SW state.
@@ -313,29 +317,33 @@ do {                                                                          \
 	NV_PMU_##_ENG##_BOARDOBJGRP_CLASS_ID_##_CLASS;                        \
 } while (0)

-#define BOARDOBJGRP_PMU_CMD_GRP_SET_CONSTRUCT(pgpu, pboardobjgrp, eng, ENG,   \
-	class, CLASS)                                                         \
-	boardobjgrp_pmucmd_construct_impl(                                    \
-	pgpu,                                              /* pgpu */         \
+#define BOARDOBJGRP_PMU_CMD_GRP_SET_CONSTRUCT(g, pboardobjgrp, eng, ENG, \
+	class, CLASS)                                                 \
+	g->ops.pmu_ver.boardobj.boardobjgrp_pmucmd_construct_impl(    \
+	g,                                              /* pgpu */    \
 	pboardobjgrp,                                      /* pboardobjgrp */ \
 	&((pboardobjgrp)->pmu.set),                        /* pcmd */         \
 	NV_PMU_##ENG##_CMD_ID_BOARDOBJ_GRP_SET,               /* id */        \
 	NV_PMU_##ENG##_MSG_ID_BOARDOBJ_GRP_SET,               /* msgid */     \
 	(u32)sizeof(union nv_pmu_##eng##_##class##_boardobjgrp_set_header_aligned), \
 	(u32)sizeof(union nv_pmu_##eng##_##class##_boardobj_set_union_aligned), \
-	(u32)sizeof(struct nv_pmu_##eng##_##class##_boardobj_grp_set))
+	(u32)sizeof(struct nv_pmu_##eng##_##class##_boardobj_grp_set),	\
+	(u32)offsetof(struct nv_pmu_super_surface, eng.class##_grp_set), \
+	NV_PMU_RPC_ID_##ENG##_BOARD_OBJ_GRP_CMD)

-#define BOARDOBJGRP_PMU_CMD_GRP_GET_STATUS_CONSTRUCT(pgpu, pboardobjgrp,      \
-	eng, ENG, class, CLASS)                                           \
-	boardobjgrp_pmucmd_construct_impl(                                    \
-	pgpu,                                              /* pGpu */         \
+#define BOARDOBJGRP_PMU_CMD_GRP_GET_STATUS_CONSTRUCT(g, pboardobjgrp, \
+	eng, ENG, class, CLASS)                                       \
+	g->ops.pmu_ver.boardobj.boardobjgrp_pmucmd_construct_impl(    \
+	g,                                              /* pGpu */    \
 	pboardobjgrp,                                      /* pBoardObjGrp */ \
 	&((pboardobjgrp)->pmu.getstatus),                  /* pCmd */         \
 	NV_PMU_##ENG##_CMD_ID_BOARDOBJ_GRP_GET_STATUS,        /* id */        \
 	NV_PMU_##ENG##_MSG_ID_BOARDOBJ_GRP_GET_STATUS,        /* msgid */     \
 	(u32)sizeof(union nv_pmu_##eng##_##class##_boardobjgrp_get_status_header_aligned), \
 	(u32)sizeof(union nv_pmu_##eng##_##class##_boardobj_get_status_union_aligned), \
-	(u32)sizeof(struct nv_pmu_##eng##_##class##_boardobj_grp_get_status))
+	(u32)sizeof(struct nv_pmu_##eng##_##class##_boardobj_grp_get_status),	\
+	(u32)offsetof(struct nv_pmu_super_surface, eng.class##_grp_get_status), \
+	NV_PMU_RPC_ID_##ENG##_BOARD_OBJ_GRP_CMD)

 /* ------------------------ Function Prototypes ----------------------------- */
 /* Constructor and destructor */
@@ -348,6 +356,8 @@ boardobjgrp_pmucmd_construct     boardobjgrp_pmucmd_construct_impl;
 boardobjgrp_pmucmd_destroy         boardobjgrp_pmucmd_destroy_impl;
 boardobjgrp_pmucmd_pmuinithandle   boardobjgrp_pmucmd_pmuinithandle_impl;

+boardobjgrp_pmucmd_construct     boardobjgrp_pmucmd_construct_impl_v1;
+
 /* BOARDOBJGRP interfaces */
 boardobjgrp_pmuinithandle    boardobjgrp_pmuinithandle_impl;
 boardobjgrp_pmuhdrdatainit   boardobjgrp_pmuhdrdatainit_super;
@@ -356,6 +366,8 @@ boardobjgrp_pmudatainit      boardobjgrp_pmudatainit_super;
 boardobjgrp_pmudatainit      boardobjgrp_pmudatainit_legacy;
 boardobjgrp_pmuset           boardobjgrp_pmuset_impl;
 boardobjgrp_pmugetstatus     boardobjgrp_pmugetstatus_impl;
+boardobjgrp_pmuset           boardobjgrp_pmuset_impl_v1;
+boardobjgrp_pmugetstatus     boardobjgrp_pmugetstatus_impl_v1;

 void boardobjgrpe32hdrset(struct nv_pmu_boardobjgrp *hdr, u32 objmask);

@@ -413,4 +425,10 @@ boardobjgrp_from_node(struct nvgpu_list_node *node)
 		((uintptr_t)node - offsetof(struct boardobjgrp, node));
 };

+int is_boardobjgrp_pmucmd_id_valid_v0(struct gk20a *g,
+	struct boardobjgrp *pboardobjgrp,
+	struct boardobjgrp_pmu_cmd *cmd);
+int is_boardobjgrp_pmucmd_id_valid_v1(struct gk20a *g,
+	struct boardobjgrp *pboardobjgrp,
+	struct boardobjgrp_pmu_cmd *cmd);
 #endif
--- a/drivers/gpu/nvgpu/common/pmu/pmu_fw.c
+++ b/drivers/gpu/nvgpu/common/pmu/pmu_fw.c
@@ -1291,6 +1291,14 @@ static int nvgpu_init_pmu_fw_ver_ops(struct nvgpu_pmu *pmu)
 				get_pmu_init_msg_pmu_sw_mg_off_v5;
 			g->ops.pmu_ver.get_pmu_init_msg_pmu_sw_mg_size =
 				get_pmu_init_msg_pmu_sw_mg_size_v5;
+			g->ops.pmu_ver.boardobj.boardobjgrp_pmucmd_construct_impl =
+				boardobjgrp_pmucmd_construct_impl_v1;
+			g->ops.pmu_ver.boardobj.boardobjgrp_pmuset_impl =
+				boardobjgrp_pmuset_impl_v1;
+			g->ops.pmu_ver.boardobj.boardobjgrp_pmugetstatus_impl =
+				boardobjgrp_pmugetstatus_impl_v1;
+			g->ops.pmu_ver.boardobj.is_boardobjgrp_pmucmd_id_valid =
+				is_boardobjgrp_pmucmd_id_valid_v1;
 		} else {
 			g->ops.pmu_ver.get_pmu_init_msg_pmu_queue_params =
 				get_pmu_init_msg_pmu_queue_params_v4;
@@ -1442,6 +1450,14 @@ static int nvgpu_init_pmu_fw_ver_ops(struct nvgpu_pmu *pmu)
 			get_pmu_sequence_in_alloc_ptr_v3;
 		g->ops.pmu_ver.get_pmu_seq_out_a_ptr =
 			get_pmu_sequence_out_alloc_ptr_v3;
+		g->ops.pmu_ver.boardobj.boardobjgrp_pmucmd_construct_impl =
+			boardobjgrp_pmucmd_construct_impl;
+		g->ops.pmu_ver.boardobj.boardobjgrp_pmuset_impl =
+			boardobjgrp_pmuset_impl;
+		g->ops.pmu_ver.boardobj.boardobjgrp_pmugetstatus_impl =
+			boardobjgrp_pmugetstatus_impl;
+		g->ops.pmu_ver.boardobj.is_boardobjgrp_pmucmd_id_valid =
+			is_boardobjgrp_pmucmd_id_valid_v0;
 		break;
 	case APP_VERSION_GM20B:
 		g->ops.pmu_ver.pg_cmd_eng_buf_load_size =
--- a/drivers/gpu/nvgpu/gk20a/gk20a.h
+++ b/drivers/gpu/nvgpu/gk20a/gk20a.h
@@ -731,6 +731,21 @@ struct gpu_ops {
 				u8 value);
 		void (*pg_cmd_eng_buf_load_set_dma_idx)(struct pmu_pg_cmd *pg,
 				u8 value);
+		struct {
+			u32 (*boardobjgrp_pmucmd_construct_impl)(struct gk20a *g,
+				struct boardobjgrp *pboardobjgrp,
+				struct boardobjgrp_pmu_cmd *cmd, u8 id, u8 msgid,
+				u8 hdrsize, u8 entrysize, u16 fbsize, u32 ss_offset,
+				u8 rpc_func_id);
+			u32 (*boardobjgrp_pmuset_impl)(struct gk20a *g,
+				struct boardobjgrp *pboardobjgrp);
+			u32 (*boardobjgrp_pmugetstatus_impl)(struct gk20a *g,
+				struct boardobjgrp *pboardobjgrp,
+				struct boardobjgrpmask *mask);
+			int (*is_boardobjgrp_pmucmd_id_valid)(struct gk20a *g,
+				struct boardobjgrp *pboardobjgrp,
+				struct boardobjgrp_pmu_cmd *cmd);
+		} boardobj;
 	} pmu_ver;
 	struct {
 		int (*get_netlist_name)(struct gk20a *g, int index, char *name);
--- a/drivers/gpu/nvgpu/include/nvgpu/pmuif/gpmuifboardobj.h
+++ b/drivers/gpu/nvgpu/include/nvgpu/pmuif/gpmuifboardobj.h
@@ -25,6 +25,18 @@
 #include <nvgpu/flcnif_cmn.h>
 #include "ctrl/ctrlboardobj.h"

+/* board object group command id's. */
+#define NV_PMU_BOARDOBJGRP_CMD_SET 			0x00
+#define NV_PMU_BOARDOBJGRP_CMD_GET_STATUS	0x01
+
+#define NV_PMU_RPC_ID_CLK_BOARD_OBJ_GRP_CMD		0x00
+#define NV_PMU_RPC_ID_FAN_BOARD_OBJ_GRP_CMD		0x00
+#define NV_PMU_RPC_ID_PERF_BOARD_OBJ_GRP_CMD 	0x00
+#define NV_PMU_RPC_ID_PERF_CF_BOARD_OBJ_GRP_CMD	0x00
+#define NV_PMU_RPC_ID_PMGR_BOARD_OBJ_GRP_CMD   	0x00
+#define NV_PMU_RPC_ID_THERM_BOARD_OBJ_GRP_CMD  	0x00
+#define NV_PMU_RPC_ID_VOLT_BOARD_OBJ_GRP_CMD   	0x00
+
 /*
 * Base structure describing a BOARDOBJ for communication between Kernel and
 * PMU.
@@ -200,5 +212,21 @@ struct nv_pmu_boardobj_msg {
 	NV_PMU_BOARDOBJ_GRP_GET_STATUS_MAKE(_eng, _class,                      \
 	CTRL_BOARDOBJGRP_E255_MAX_OBJECTS)

+/* RPC */
+
+/*
+ * structure that holds data used to
+ * execute BOARD_OBJ_GRP_CMD RPC.
+ */
+struct nv_pmu_rpc_struct_board_obj_grp_cmd
+{
+    /* [IN/OUT] Must be first field in RPC structure */
+	struct nv_pmu_rpc_header hdr;
+    /* [IN] BOARDOBJGRP class IDs. */
+    u8  class_id;
+    /* [IN] Requested command ID (@ref NV_PMU_BOARDOBJGRP_CMD_***)*/
+    u8  command_id;
+    u32  scratch[1];
+};

 #endif /*  _GPMUIFBOARDOBJ_H_ */