From bc76577591f8d24e4bb6a03bc31ba9c95c61fa7a Mon Sep 17 00:00:00 2001 From: Shashank Singh Date: Thu, 22 Aug 2019 13:55:27 +0530 Subject: [PATCH] gpu: nvgpu: Fix misra rule 10.3 for qnx.vm unit For getting the buffer size qnx issues a devctl to nvmap which can fail as well. So, check the size that is returned by nvgpu_os_buf_get_size. If 0 size is returned then return -EINVAL to the caller. Jira NVGPU-3891 Change-Id: Id13e7612b044e9228d78469ab4e43961a6877ce8 Signed-off-by: Shashank Singh Reviewed-on: https://git-master.nvidia.com/r/2174458 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/mm/vm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/nvgpu/common/mm/vm.c b/drivers/gpu/nvgpu/common/mm/vm.c index 49c2f64bd..64cca5edc 100644 --- a/drivers/gpu/nvgpu/common/mm/vm.c +++ b/drivers/gpu/nvgpu/common/mm/vm.c @@ -1014,6 +1014,10 @@ int nvgpu_vm_map(struct vm_gk20a *vm, binfo.flags = flags; binfo.size = nvgpu_os_buf_get_size(os_buf); + if (binfo.size == 0UL) { + nvgpu_err(g, "Invalid buffer size"); + return -EINVAL; + } binfo.incompr_kind = incompr_kind; #ifdef CONFIG_NVGPU_COMPRESSION