nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 02:22:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: MISRA 14.4 err/ret/status as boolean

Browse Source 
MISRA rule 14.4 doesn't allow the usage of integer types as booleans
in the controlling expression of an if statement or an iteration
statement.

Fix violations where the integer variables err, ret, status are used
as booleans in the controlling expression of if and loop statements.

JIRA NVGPU-1019

Change-Id: I8c9ad786a741b78293d0ebc4e1c33d4d0fc8f9b4
Signed-off-by: Amurthyreddy <amurthyreddy@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1921260
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Amurthyreddy
2018-10-08 10:54:08 +05:30
committed by mobile promotions
parent 745e720089
commit c94643155e
27 changed files with 203 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/gpu/nvgpu/lpwr/rppg.c
View File

@@ -32,7 +32,7 @@ static void pmu_handle_rppg_init_msg(struct gk20a *g, struct pmu_msg *msg,
{
u32 *success = param;
if (status == 0) {
if (status == 0U) {
switch (msg->msg.pg.rppg_msg.cmn.msg_id) {
case NV_PMU_RPPG_MSG_ID_INIT_CTRL_ACK:
*success = 1;
@@ -46,11 +46,11 @@ static void pmu_handle_rppg_init_msg(struct gk20a *g, struct pmu_msg *msg,
msg->msg.pg.msg_type);
}
static u32 rppg_send_cmd(struct gk20a *g, struct nv_pmu_rppg_cmd *prppg_cmd)
static int rppg_send_cmd(struct gk20a *g, struct nv_pmu_rppg_cmd *prppg_cmd)
{
struct pmu_cmd cmd;
u32 seq;
u32 status = 0;
int status = 0;
u32 success = 0;
memset(&cmd, 0, sizeof(struct pmu_cmd));
@@ -82,7 +82,7 @@ static u32 rppg_send_cmd(struct gk20a *g, struct nv_pmu_rppg_cmd *prppg_cmd)
status = nvgpu_pmu_cmd_post(g, &cmd, NULL, NULL, PMU_COMMAND_QUEUE_HPQ,
pmu_handle_rppg_init_msg, &success, &seq, ~0);
if (status) {
if (status != 0) {
nvgpu_err(g, "Unable to submit parameter command %d",
prppg_cmd->cmn.cmd_id);
goto exit;
@@ -102,7 +102,7 @@ exit:
return status;
}
static u32 rppg_init(struct gk20a *g)
static int rppg_init(struct gk20a *g)
{
struct nv_pmu_rppg_cmd rppg_cmd;
@@ -111,7 +111,7 @@ static u32 rppg_init(struct gk20a *g)
return rppg_send_cmd(g, &rppg_cmd);
}
static u32 rppg_ctrl_init(struct gk20a *g, u8 ctrl_id)
static int rppg_ctrl_init(struct gk20a *g, u8 ctrl_id)
{
struct nv_pmu_rppg_cmd rppg_cmd;
@@ -128,9 +128,9 @@ static u32 rppg_ctrl_init(struct gk20a *g, u8 ctrl_id)
return rppg_send_cmd(g, &rppg_cmd);
}
u32 init_rppg(struct gk20a *g)
int init_rppg(struct gk20a *g)
{
u32 status;
int status;
status = rppg_init(g);
if (status != 0) {