From cb636330382d718d09d01b8499f1572fdf8b2637 Mon Sep 17 00:00:00 2001 From: Jon Hunter Date: Wed, 6 Dec 2023 08:15:47 +0000 Subject: [PATCH] gpu: nvgpu: Remove unused function When compiling NVGPU with the GCC option '-Wmissing-prototypes' the following error is observed ... nvgpu/drivers/gpu/nvgpu/os/linux/nvlink.c:42:5: error: no previous prototype for nvgpu_nvlink_train [-Werror=missing-prototypes] | int nvgpu_nvlink_train(struct gk20a *g, u32 link_id, bool from_off) | ^~~~~~~~~~~~~~~~~~ The function nvgpu_nvlink_train() is no longer used and has not been used for a long time. Therefore, fix the above by removing this legacy function. Bug 4404965 Change-Id: Ib5d13b024a072d20cb569cfa77a86a74274d3fe7 Signed-off-by: Jon Hunter Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/3029179 (cherry picked from commit e378ca55059fdf649d3300ae98ba80ac6262c893) Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/3035510 Reviewed-by: Alex Waterman GVS: Gerrit_Virtual_Submit --- drivers/gpu/nvgpu/os/linux/nvlink.c | 34 ++--------------------------- 1 file changed, 2 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/nvgpu/os/linux/nvlink.c b/drivers/gpu/nvgpu/os/linux/nvlink.c index 565480cc2..a49c62618 100644 --- a/drivers/gpu/nvgpu/os/linux/nvlink.c +++ b/drivers/gpu/nvgpu/os/linux/nvlink.c @@ -1,18 +1,5 @@ -/* - * Copyright (c) 2018-2022, NVIDIA CORPORATION. All rights reserved. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see . - */ +// SPDX-License-Identifier: GPL-2.0-only +// SPDX-FileCopyrightText: Copyright (c) 2018-2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved. #include #include @@ -37,23 +24,6 @@ int nvgpu_nvlink_enumerate(struct gk20a *g) return nvlink_enumerate(ndev); } -int nvgpu_nvlink_train(struct gk20a *g, u32 link_id, bool from_off) -{ - struct nvlink_device *ndev = (struct nvlink_device *) g->nvlink.priv; - - if (!ndev) - return -ENODEV; - - /* Check if the link is connected */ - if (!g->nvlink.links[link_id].remote_info.is_connected) - return -ENODEV; - - if (from_off) - return nvlink_transition_intranode_conn_off_to_safe(ndev); - - return nvlink_train_intranode_conn_safe_to_hs(ndev); -} - void nvgpu_nvlink_free_minion_used_mem(struct gk20a *g, struct nvgpu_firmware *nvgpu_minion_fw) {