From ceeead091e22458b533e93f11cccec3e6c625ce0 Mon Sep 17 00:00:00 2001 From: Vaibhav Kachore Date: Sat, 1 Jun 2019 01:48:55 +0530 Subject: [PATCH] gpu: nvgpu: fix error condition in nvgpu_safe_mult_u64 This patch fixes error condition in nvgpu_safe_mult_u64. As this function is operating on u64, ULONG_MAX should be used to check error condition. NVGPU-3432 Change-Id: I950c70bb0f26b58ae7ba0f04fad5c2bde64f07ba Signed-off-by: Vaibhav Kachore Reviewed-on: https://git-master.nvidia.com/r/2128612 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/include/nvgpu/safe_ops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/nvgpu/include/nvgpu/safe_ops.h b/drivers/gpu/nvgpu/include/nvgpu/safe_ops.h index 236f4e328..8aa40bede 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/safe_ops.h +++ b/drivers/gpu/nvgpu/include/nvgpu/safe_ops.h @@ -97,7 +97,7 @@ static inline u64 nvgpu_safe_mult_u64(u64 ul_a, u64 ul_b) { if (ul_a == 0 || ul_b == 0) { return 0UL; - } else if (ul_a > UINT_MAX / ul_b) { + } else if (ul_a > ULONG_MAX / ul_b) { BUG(); } else { return ul_a * ul_b;