From d01ab945373aff869f0249422cde88a853b5ae66 Mon Sep 17 00:00:00 2001 From: Philip Elcan Date: Tue, 25 Feb 2020 13:51:49 -0500 Subject: [PATCH] gpu: nvgpu: unit: mm: remove errant call to info_mem_destroy Remove the second call to info_mem_destroy() in the unit test test_page_faults_clean(). This did not add any additional coverage and causes an attempt to access an invalid mutex since it is destroyed by the first call. JIRA NVGPU-4987 Change-Id: Ibbf5c4c300802566b6260f0236f705d48bebf3ee Signed-off-by: Philip Elcan Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2302644 Reviewed-by: svc-mobile-coverity Reviewed-by: svc-mobile-misra Reviewed-by: Vinod Gopalakrishnakurup Reviewed-by: mobile promotions GVS: Gerrit_Virtual_Submit Tested-by: mobile promotions --- userspace/units/mm/page_table_faults/page_table_faults.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/userspace/units/mm/page_table_faults/page_table_faults.c b/userspace/units/mm/page_table_faults/page_table_faults.c index 4f0d5e02b..35edc43f6 100644 --- a/userspace/units/mm/page_table_faults/page_table_faults.c +++ b/userspace/units/mm/page_table_faults/page_table_faults.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018-2019, NVIDIA CORPORATION. All rights reserved. + * Copyright (c) 2018-2020, NVIDIA CORPORATION. All rights reserved. * * Permission is hereby granted, free of charge, to any person obtaining a * copy of this software and associated documentation files (the "Software"), @@ -339,9 +339,6 @@ int test_page_faults_clean(struct unit_module *m, struct gk20a *g, void *args) nvgpu_vm_put(g->mm.pmu.vm); nvgpu_vm_put(g->mm.bar2.vm); - /* Call again to test some branches */ - g->ops.mm.mmu_fault.info_mem_destroy(g); - return UNIT_SUCCESS; }