nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-23 09:57:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: fix resource leak in error path

Browse Source 
In nvgpu_request_firmware(), if fw->data is NULL, we jump
to label "err" and leak the storage pointed by linux_fw

Fix this by releasing firmware in error path if
fw->data is NULL

Coverity id : 2513066
Bug 200291879

Change-Id: Ieb5e22137cebb4cd02415b805941969b95a38668
Signed-off-by: Deepak Nibade <dnibade@nvidia.com>
Reviewed-on: http://git-master/r/1479884
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
This commit is contained in:
Deepak Nibade
2017-05-11 14:58:51 +05:30
committed by mobile promotions
parent 677edcd6ec
commit d0955cad82
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/nvgpu/common/linux/firmware.c
View File

@@ -93,7 +93,7 @@ struct nvgpu_firmware *nvgpu_request_firmware(struct gk20a *g,
fw->data = nvgpu_kmalloc(g, linux_fw->size); fw->data = nvgpu_kmalloc(g, linux_fw->size);
if (!fw->data) if (!fw->data)
goto err; goto err_release;
memcpy(fw->data, linux_fw->data, linux_fw->size); memcpy(fw->data, linux_fw->data, linux_fw->size);
fw->size = linux_fw->size; fw->size = linux_fw->size;
@@ -102,6 +102,8 @@ struct nvgpu_firmware *nvgpu_request_firmware(struct gk20a *g,
return fw; return fw;
err_release:
release_firmware(linux_fw);
err: err:
nvgpu_kfree(g, fw); nvgpu_kfree(g, fw);
return NULL; return NULL;