From d0fa6a15c1013cde1fa3f4b42c3c8485b4cd6909 Mon Sep 17 00:00:00 2001 From: Alex Waterman Date: Thu, 11 Jun 2020 14:49:55 -0500 Subject: [PATCH] gpu: nvgpu: Fix logging for pre-4.14 kernels It seems that on Tegra kernels older than 4.14 the pre_err() function does not automatically add a '\n' if you don't supply it. For older kernels, with the new nvgpu_dbg_dump_impl() function, add this extra newline so that logs are not hopelessly scrambled. Change-Id: Ife8fe03ace248a1d8ece7850b609c343cc1d27ac Signed-off-by: Alex Waterman Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2359752 Reviewed-by: automaticguardword Reviewed-by: Debarshi Dutta Reviewed-by: Deepak Nibade Reviewed-by: mobile promotions GVS: Gerrit_Virtual_Submit Tested-by: mobile promotions --- drivers/gpu/nvgpu/os/linux/log.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/nvgpu/os/linux/log.c b/drivers/gpu/nvgpu/os/linux/log.c index b9c31b7c2..efbcba833 100644 --- a/drivers/gpu/nvgpu/os/linux/log.c +++ b/drivers/gpu/nvgpu/os/linux/log.c @@ -130,5 +130,9 @@ void nvgpu_log_dbg_impl(struct gk20a *g, u64 log_mask, void nvgpu_dbg_dump_impl(struct gk20a *g, const char *str) { +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 14, 0) pr_err("__%s__ %s", g->name, str); +#else + pr_err("__%s__ %s\n", g->name, str); +#endif }