nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-25 02:52:51 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: incr sync once submit is ready to go

Browse Source 
Split out the max value increment and syncpt interrupt registration out
of nvgpu_channel_sync_incr*(). This API is called in the submit path to
prepare buffers and tracking resources, but later on in the submit path
errors can still occur so that the increment wouldn't happen (unless
artificially forced by sw).

The increment and irq registration cannot easily be undone and it makes
more sense to do these at the moment when the prepared job is finally
ready, so add a new nvgpu_channel_sync_mark_progress() API to be called
later in the submit path to signal that progress shall eventually happen
on the sync. Without this, the max value would stay too large after an
unsuccessful submit until the channel gets closed.

The sync object (syncpt or semaphore) is always exclusively owned by the
channel that allocated it, so nonatomically reading the max value first
in sync_incr() and incrementing it later in mark_progress() is racefree;
all submits per channel are serialized.

Change the channel syncpoint to client managed from host managed so that
nvhost-exported sync fences behave correctly with the temporary state
where the fence threshold is over the max value. Ideally we'd always
track nvgpu-owned syncpts' max values internally, but this is enough for
now.

Jira NVGPU-5491

Change-Id: Idf0bda7ac93d7f2f114cdeb497fe6b5369d21c95
Signed-off-by: Konsta Hölttä <kholtta@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2340465
Reviewed-by: automaticguardword <automaticguardword@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Konsta Hölttä
2020-05-06 14:23:49 +03:00
committed by Alex Waterman
parent dbbe6b67be
commit d916e85171
10 changed files with 130 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/gpu/nvgpu/common/sync/channel_sync.c
View File

@@ -65,17 +65,22 @@ int nvgpu_channel_sync_wait_fence_fd(struct nvgpu_channel_sync *s, int fd,
int nvgpu_channel_sync_incr(struct nvgpu_channel_sync *s,
struct priv_cmd_entry **entry, struct nvgpu_fence_type *fence,
bool need_sync_fence, bool register_irq)
bool need_sync_fence)
{
return s->ops->incr(s, entry, fence, need_sync_fence, register_irq);
return s->ops->incr(s, entry, fence, need_sync_fence);
}
int nvgpu_channel_sync_incr_user(struct nvgpu_channel_sync *s,
struct priv_cmd_entry **entry, struct nvgpu_fence_type *fence,
bool wfi, bool need_sync_fence, bool register_irq)
bool wfi, bool need_sync_fence)
{
return s->ops->incr_user(s, entry, fence, wfi, need_sync_fence,
register_irq);
return s->ops->incr_user(s, entry, fence, wfi, need_sync_fence);
}
void nvgpu_channel_sync_mark_progress(struct nvgpu_channel_sync *s,
bool register_irq)
{
s->ops->mark_progress(s, register_irq);
}
void nvgpu_channel_sync_set_min_eq_max(struct nvgpu_channel_sync *s)