nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 09:12:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: firmware: use u32 for flags

Browse Source 
Update the nvgpu_request_firmware API to use u32 for the flags
parameter. The API previously defined the flags parameter to be an int.
However, the flags were defined as UL. This was causing MISRA 10.3
violations for implicitly assigning an object of different essential
type. So, this change makes all definitions a u32.

JIRA NVGPU-1008

Change-Id: I09eb75d4e2a20e7ac6dba80d3bc06335d3c78d62
Signed-off-by: Philip Elcan <pelcan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2023223
Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Adeel Raza <araza@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Philip Elcan
2019-02-19 16:17:58 -05:00
committed by mobile promotions
parent ba6c6c818b
commit dc9ba05cd4
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/nvgpu/include/nvgpu/firmware.h
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2016-2018, NVIDIA CORPORATION. All rights reserved. * Copyright (c) 2016-2019, NVIDIA CORPORATION. All rights reserved.
* *
* Permission is hereby granted, free of charge, to any person obtaining a * Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"), * copy of this software and associated documentation files (the "Software"),
@@ -27,8 +27,8 @@
struct gk20a; struct gk20a;
#define NVGPU_REQUEST_FIRMWARE_NO_WARN (1UL << 0) #define NVGPU_REQUEST_FIRMWARE_NO_WARN BIT32(0)
#define NVGPU_REQUEST_FIRMWARE_NO_SOC (1UL << 1) #define NVGPU_REQUEST_FIRMWARE_NO_SOC BIT32(1)
struct nvgpu_firmware { struct nvgpu_firmware {
u8 *data; u8 *data;
@@ -61,7 +61,7 @@ struct nvgpu_firmware {
*/ */
struct nvgpu_firmware *nvgpu_request_firmware(struct gk20a *g, struct nvgpu_firmware *nvgpu_request_firmware(struct gk20a *g,
const char *fw_name, const char *fw_name,
int flags); u32 flags);
/** /**
* nvgpu_release_firmware - free firmware and associated nvgpu_firmware blob * nvgpu_release_firmware - free firmware and associated nvgpu_firmware blob

6
drivers/gpu/nvgpu/os/linux/firmware.c
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2017-2018, NVIDIA CORPORATION. All rights reserved. * Copyright (c) 2017-2019, NVIDIA CORPORATION. All rights reserved.
* *
* This program is free software; you can redistribute it and/or modify it * This program is free software; you can redistribute it and/or modify it
* under the terms and conditions of the GNU General Public License, * under the terms and conditions of the GNU General Public License,
@@ -26,7 +26,7 @@
#include "os_linux.h" #include "os_linux.h"
static const struct firmware *do_request_firmware(struct device *dev, static const struct firmware *do_request_firmware(struct device *dev,
const char *prefix, const char *fw_name, int flags) const char *prefix, const char *fw_name, u32 flags)
{ {
const struct firmware *fw; const struct firmware *fw;
char *fw_path = NULL; char *fw_path = NULL;
@@ -61,7 +61,7 @@ static const struct firmware *do_request_firmware(struct device *dev,
* responsible for calling nvgpu_release_firmware later. */ * responsible for calling nvgpu_release_firmware later. */
struct nvgpu_firmware *nvgpu_request_firmware(struct gk20a *g, struct nvgpu_firmware *nvgpu_request_firmware(struct gk20a *g,
const char *fw_name, const char *fw_name,
int flags) u32 flags)
{ {
struct device *dev = dev_from_gk20a(g); struct device *dev = dev_from_gk20a(g);
struct nvgpu_firmware *fw; struct nvgpu_firmware *fw;

4
drivers/gpu/nvgpu/os/posix/firmware.c
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. * Copyright (c) 2018-2019, NVIDIA CORPORATION. All rights reserved.
* *
* Permission is hereby granted, free of charge, to any person obtaining a * Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"), * copy of this software and associated documentation files (the "Software"),
@@ -24,7 +24,7 @@
struct nvgpu_firmware *nvgpu_request_firmware(struct gk20a *g, struct nvgpu_firmware *nvgpu_request_firmware(struct gk20a *g,
const char *fw_name, const char *fw_name,
int flags) u32 flags)
{ {
return NULL; return NULL;
} }