From e0061b8daa72e7478a5dd17f005941bd485f8e37 Mon Sep 17 00:00:00 2001 From: Nitin Kumbhar Date: Mon, 20 May 2019 16:31:11 +0530 Subject: [PATCH] gpu: nvgpu: fix sim STR30 CERT C violations Make path a pointer to const char to avoid attempt to modify string literal. Error: CERT STR30-C: drivers/gpu/nvgpu/common/sim/sim_netlist.c:363: cert_violation: Assigning or casting string literal ""GRCTX_GEN_CTX_REGS_BASE_INDEX"" to a pointer to non-const. Jira NVGPU-3560 Change-Id: I22dacbbd210a43c41aef2532c5ddb1429d5c9153 Signed-off-by: Nitin Kumbhar Reviewed-on: https://git-master.nvidia.com/r/2122101 Reviewed-by: svc-mobile-coverity Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svc-mobile-misra GVS: Gerrit_Virtual_Submit Reviewed-by: Alex Waterman Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/sim/sim.c | 2 +- drivers/gpu/nvgpu/common/sim/sim_pci.c | 2 +- drivers/gpu/nvgpu/include/nvgpu/sim.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nvgpu/common/sim/sim.c b/drivers/gpu/nvgpu/common/sim/sim.c index ea4b8879d..ef9320796 100644 --- a/drivers/gpu/nvgpu/common/sim/sim.c +++ b/drivers/gpu/nvgpu/common/sim/sim.c @@ -219,7 +219,7 @@ static int issue_rpc_and_wait(struct gk20a *g) } static void nvgpu_sim_esc_readl(struct gk20a *g, - char *path, u32 index, u32 *data) + const char *path, u32 index, u32 *data) { int err; size_t pathlen = strlen(path); diff --git a/drivers/gpu/nvgpu/common/sim/sim_pci.c b/drivers/gpu/nvgpu/common/sim/sim_pci.c index f66f292ff..89ec2fa74 100644 --- a/drivers/gpu/nvgpu/common/sim/sim_pci.c +++ b/drivers/gpu/nvgpu/common/sim/sim_pci.c @@ -185,7 +185,7 @@ static int issue_rpc_and_wait(struct gk20a *g) } static void nvgpu_sim_esc_readl(struct gk20a *g, - char *path, u32 index, u32 *data) + const char *path, u32 index, u32 *data) { int err; size_t pathlen = strlen(path); diff --git a/drivers/gpu/nvgpu/include/nvgpu/sim.h b/drivers/gpu/nvgpu/include/nvgpu/sim.h index e15a74cd1..e79b83658 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/sim.h +++ b/drivers/gpu/nvgpu/include/nvgpu/sim.h @@ -37,7 +37,7 @@ struct sim_nvgpu { void (*sim_init_late)(struct gk20a *g); void (*remove_support)(struct gk20a *g); void (*esc_readl)( - struct gk20a *g, char *path, u32 index, u32 *data); + struct gk20a *g, const char *path, u32 index, u32 *data); }; #ifdef __KERNEL__ #include "linux/sim.h"