nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 17:36:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: change gk20a_gr_debug_dump to return void

Browse Source 
MISRA Rule-17.7 requires the return value of all functions to be
used. Fix is either to use the return value or change the function
to return void. In the case of the gk20a_gr_debug_dump function, it
was always returning 0, so this patch changes the signature to
return void instead.

JIRA NVGPU-3153

Change-Id: I90173ba4e74fe045d9d6a819889d443f8423f34e
Signed-off-by: Nicolas Benech <nbenech@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2100651
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Nicolas Benech
2019-04-18 13:50:45 -04:00
committed by mobile promotions
parent d0907087c1
commit f99a75913d
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/nvgpu/include/nvgpu/debug.h
View File

@@ -45,7 +45,7 @@ void gk20a_debug_output(struct gk20a_debug_output *o,
void gk20a_debug_dump(struct gk20a *g);
void gk20a_debug_show_dump(struct gk20a *g, struct gk20a_debug_output *o);
int gk20a_gr_debug_dump(struct gk20a *g);
void gk20a_gr_debug_dump(struct gk20a *g);
void gk20a_init_debug_ops(struct gpu_ops *gops);
void gk20a_debug_init(struct gk20a *g, const char *debugfs_symlink);
@@ -57,7 +57,7 @@ static inline void gk20a_debug_output(struct gk20a_debug_output *o,
static inline void gk20a_debug_dump(struct gk20a *g) {}
static inline void gk20a_debug_show_dump(struct gk20a *g, struct gk20a_debug_output *o) {}
static inline int gk20a_gr_debug_dump(struct gk20a *g) { return 0;}
static inline void gk20a_gr_debug_dump(struct gk20a *g) {}
static inline void gk20a_debug_init(struct gk20a *g, const char *debugfs_symlink) {}
static inline void gk20a_debug_deinit(struct gk20a *g) {}
#endif

4
drivers/gpu/nvgpu/os/linux/debug.c
View File

@@ -79,7 +79,7 @@ static int gk20a_gr_dump_regs(struct gk20a *g,
return 0;
}
int gk20a_gr_debug_dump(struct gk20a *g)
void gk20a_gr_debug_dump(struct gk20a *g)
{
struct gk20a_debug_output o = {
.fn = gk20a_debug_write_printk,
@@ -87,8 +87,6 @@ int gk20a_gr_debug_dump(struct gk20a *g)
};
gk20a_gr_dump_regs(g, &o);
return 0;
}
static int gk20a_gr_debug_show(struct seq_file *s, void *unused)