mirror of
git://nv-tegra.nvidia.com/linux-nvgpu.git
synced 2025-12-23 01:50:07 +03:00
f97d62eb8f
-issue: flcn pointer in nvgpu_flcn_sw_init() will be NULL in default case of switch, and that results in NULL pointer dereference on flcn->flcn_id. -Fix: Used flcn_id parameter to print falcon id in default case. Coverity ID: 2514311 Coverity ID: 2514313 Bug 200291879 Change-Id: I7008817c22cdf8d9d9027cc1b724e2424b4a3d8e Signed-off-by: Mahantesh Kumbar <mkumbar@nvidia.com> Reviewed-on: http://git-master/r/1491694 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Deepak Nibade <dnibade@nvidia.com> Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
52 lines
1.3 KiB
C
52 lines
1.3 KiB
C
/*
|
|
* Copyright (c) 2017, NVIDIA CORPORATION. All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms and conditions of the GNU General Public License,
|
|
* version 2, as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*/
|
|
#include <nvgpu/lock.h>
|
|
#include <nvgpu/timers.h>
|
|
#include <nvgpu/falcon.h>
|
|
|
|
#include "gk20a/gk20a.h"
|
|
|
|
void nvgpu_flcn_sw_init(struct gk20a *g, u32 flcn_id)
|
|
{
|
|
struct nvgpu_falcon *flcn = NULL;
|
|
struct gpu_ops *gops = &g->ops;
|
|
|
|
switch (flcn_id) {
|
|
case FALCON_ID_PMU:
|
|
flcn = &g->pmu_flcn;
|
|
flcn->flcn_id = flcn_id;
|
|
break;
|
|
case FALCON_ID_SEC2:
|
|
flcn = &g->sec2_flcn;
|
|
flcn->flcn_id = flcn_id;
|
|
break;
|
|
case FALCON_ID_FECS:
|
|
flcn = &g->fecs_flcn;
|
|
flcn->flcn_id = flcn_id;
|
|
break;
|
|
case FALCON_ID_GPCCS:
|
|
flcn = &g->gpccs_flcn;
|
|
flcn->flcn_id = flcn_id;
|
|
break;
|
|
default:
|
|
nvgpu_err(g, "Invalid/Unsupported falcon ID %x", flcn_id);
|
|
break;
|
|
};
|
|
|
|
/* call to HAL method to assign flcn base & ops to selected falcon */
|
|
if (flcn) {
|
|
flcn->g = g;
|
|
gops->falcon.falcon_hal_sw_init(flcn);
|
|
}
|
|
}
|