mirror of
git://nv-tegra.nvidia.com/linux-nvgpu.git
synced 2025-12-22 17:36:20 +03:00
ECC counter structures are freed without removing the node from the stats_list. This can lead to invalid access due to dangling pointers. Update the ecc counter free logic to set them to NULL upon free, to remove them from stats_list and free them by validation. Also updated some of the ecc init paths where error was not propa- gated to callers and full ecc counters deallocation was not done. Now, calling unit ecc_free from any context (with counters alloc- ated or not) is harmless as requisite checks are in place. bug 3326612 bug 3345977 Change-Id: I05eb6ed226cff9197ad37776912da9dcb7e0716d Signed-off-by: Sagar Kamble <skamble@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2565264 Tested-by: Ashish Mhetre <amhetre@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> Reviewed-by: svc_kernel_abi <svc_kernel_abi@nvidia.com> Reviewed-by: Konsta Holtta <kholtta@nvidia.com> Reviewed-by: Deepak Nibade <dnibade@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit
270 lines
6.9 KiB
C
270 lines
6.9 KiB
C
/*
|
|
* Copyright (c) 2019-2021, NVIDIA CORPORATION. All rights reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include <nvgpu/gr/gr_ecc.h>
|
|
#include <nvgpu/gr/gr_utils.h>
|
|
#include <nvgpu/gr/config.h>
|
|
#include <nvgpu/string.h>
|
|
#include <nvgpu/gk20a.h>
|
|
#include <nvgpu/kmem.h>
|
|
#include <nvgpu/ecc.h>
|
|
|
|
int nvgpu_ecc_counter_init_per_gr(struct gk20a *g,
|
|
struct nvgpu_ecc_stat **stat, const char *name)
|
|
{
|
|
struct nvgpu_ecc_stat *stats;
|
|
u32 i;
|
|
char gr_str[10] = {0};
|
|
|
|
stats = nvgpu_kzalloc(g, nvgpu_safe_mult_u64(sizeof(*stats),
|
|
g->num_gr_instances));
|
|
if (stats == NULL) {
|
|
return -ENOMEM;
|
|
}
|
|
|
|
for (i = 0; i < g->num_gr_instances; i++) {
|
|
/**
|
|
* Store stats name as below:
|
|
* gr<gr_index>_<name_string>
|
|
*/
|
|
(void)strcpy(stats[i].name, "gr");
|
|
(void)nvgpu_strnadd_u32(gr_str, i, sizeof(gr_str), 10U);
|
|
(void)strncat(stats[i].name, gr_str,
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[i].name));
|
|
(void)strncat(stats[i].name, "_",
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[i].name));
|
|
(void)strncat(stats[i].name, name,
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[i].name));
|
|
|
|
nvgpu_ecc_stat_add(g, &stats[i]);
|
|
}
|
|
|
|
*stat = stats;
|
|
return 0;
|
|
}
|
|
|
|
int nvgpu_ecc_counter_init_per_tpc(struct gk20a *g,
|
|
struct nvgpu_ecc_stat ***stat, const char *name)
|
|
{
|
|
struct nvgpu_ecc_stat **stats;
|
|
struct nvgpu_gr_config *gr_config = nvgpu_gr_get_config_ptr(g);
|
|
u32 gpc_count = nvgpu_gr_config_get_gpc_count(gr_config);
|
|
u32 gpc, tpc;
|
|
char gpc_str[10] = {0}, tpc_str[10] = {0};
|
|
int err = 0;
|
|
|
|
stats = nvgpu_kzalloc(g, nvgpu_safe_mult_u64(sizeof(*stats),
|
|
gpc_count));
|
|
if (stats == NULL) {
|
|
return -ENOMEM;
|
|
}
|
|
|
|
for (gpc = 0; gpc < gpc_count; gpc++) {
|
|
stats[gpc] = nvgpu_kzalloc(g,
|
|
nvgpu_safe_mult_u64(sizeof(*stats[gpc]),
|
|
nvgpu_gr_config_get_gpc_tpc_count(gr_config,
|
|
gpc)));
|
|
if (stats[gpc] == NULL) {
|
|
err = -ENOMEM;
|
|
goto fail;
|
|
}
|
|
}
|
|
|
|
for (gpc = 0; gpc < gpc_count; gpc++) {
|
|
for (tpc = 0;
|
|
tpc < nvgpu_gr_config_get_gpc_tpc_count(gr_config, gpc);
|
|
tpc++) {
|
|
/**
|
|
* Store stats name as below:
|
|
* gpc<gpc_value>_tpc<tpc_value>_<name_string>
|
|
*/
|
|
(void)strcpy(stats[gpc][tpc].name, "gpc");
|
|
(void)nvgpu_strnadd_u32(gpc_str, gpc,
|
|
sizeof(gpc_str), 10U);
|
|
(void)strncat(stats[gpc][tpc].name, gpc_str,
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[gpc][tpc].name));
|
|
(void)strncat(stats[gpc][tpc].name, "_tpc",
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[gpc][tpc].name));
|
|
(void)nvgpu_strnadd_u32(tpc_str, tpc,
|
|
sizeof(tpc_str), 10U);
|
|
(void)strncat(stats[gpc][tpc].name, tpc_str,
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[gpc][tpc].name));
|
|
(void)strncat(stats[gpc][tpc].name, "_",
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[gpc][tpc].name));
|
|
(void)strncat(stats[gpc][tpc].name, name,
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[gpc][tpc].name));
|
|
|
|
nvgpu_ecc_stat_add(g, &stats[gpc][tpc]);
|
|
}
|
|
}
|
|
|
|
*stat = stats;
|
|
|
|
fail:
|
|
if (err != 0) {
|
|
while (gpc-- != 0u) {
|
|
nvgpu_kfree(g, stats[gpc]);
|
|
}
|
|
|
|
nvgpu_kfree(g, stats);
|
|
}
|
|
|
|
return err;
|
|
}
|
|
|
|
int nvgpu_ecc_counter_init_per_gpc(struct gk20a *g,
|
|
struct nvgpu_ecc_stat **stat, const char *name)
|
|
{
|
|
struct nvgpu_ecc_stat *stats;
|
|
struct nvgpu_gr_config *gr_config = nvgpu_gr_get_config_ptr(g);
|
|
u32 gpc_count = nvgpu_gr_config_get_gpc_count(gr_config);
|
|
u32 gpc;
|
|
char gpc_str[10] = {0};
|
|
|
|
stats = nvgpu_kzalloc(g, nvgpu_safe_mult_u64(sizeof(*stats),
|
|
gpc_count));
|
|
if (stats == NULL) {
|
|
return -ENOMEM;
|
|
}
|
|
|
|
for (gpc = 0; gpc < gpc_count; gpc++) {
|
|
/**
|
|
* Store stats name as below:
|
|
* gpc<gpc_value>_<name_string>
|
|
*/
|
|
(void)strcpy(stats[gpc].name, "gpc");
|
|
(void)nvgpu_strnadd_u32(gpc_str, gpc, sizeof(gpc_str), 10U);
|
|
(void)strncat(stats[gpc].name, gpc_str,
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[gpc].name));
|
|
(void)strncat(stats[gpc].name, "_",
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[gpc].name));
|
|
(void)strncat(stats[gpc].name, name,
|
|
NVGPU_ECC_STAT_NAME_MAX_SIZE -
|
|
strlen(stats[gpc].name));
|
|
|
|
nvgpu_ecc_stat_add(g, &stats[gpc]);
|
|
}
|
|
|
|
*stat = stats;
|
|
return 0;
|
|
}
|
|
|
|
void nvgpu_ecc_counter_deinit_per_gr(struct gk20a *g,
|
|
struct nvgpu_ecc_stat **stats_p)
|
|
{
|
|
struct nvgpu_ecc_stat *stats = NULL;
|
|
u32 i;
|
|
|
|
if (*stats_p != NULL) {
|
|
stats = *stats_p;
|
|
|
|
for (i = 0; i < g->num_gr_instances; i++) {
|
|
nvgpu_ecc_stat_del(g, &stats[i]);
|
|
}
|
|
|
|
nvgpu_kfree(g, stats);
|
|
*stats_p = NULL;
|
|
}
|
|
}
|
|
|
|
void nvgpu_ecc_counter_deinit_per_tpc(struct gk20a *g,
|
|
struct nvgpu_ecc_stat ***stats_p)
|
|
{
|
|
struct nvgpu_gr_config *gr_config = nvgpu_gr_get_config_ptr(g);
|
|
struct nvgpu_ecc_stat **stats = NULL;
|
|
u32 gpc_count;
|
|
u32 gpc, tpc;
|
|
|
|
if (*stats_p != NULL) {
|
|
gpc_count = nvgpu_gr_config_get_gpc_count(gr_config);
|
|
stats = *stats_p;
|
|
|
|
for (gpc = 0; gpc < gpc_count; gpc++) {
|
|
if (stats[gpc] == NULL) {
|
|
continue;
|
|
}
|
|
|
|
for (tpc = 0;
|
|
tpc < nvgpu_gr_config_get_gpc_tpc_count(gr_config, gpc);
|
|
tpc++) {
|
|
nvgpu_ecc_stat_del(g, &stats[gpc][tpc]);
|
|
}
|
|
|
|
nvgpu_kfree(g, stats[gpc]);
|
|
stats[gpc] = NULL;
|
|
}
|
|
|
|
nvgpu_kfree(g, stats);
|
|
*stats_p = NULL;
|
|
}
|
|
}
|
|
|
|
void nvgpu_ecc_counter_deinit_per_gpc(struct gk20a *g,
|
|
struct nvgpu_ecc_stat **stats_p)
|
|
{
|
|
struct nvgpu_gr_config *gr_config = nvgpu_gr_get_config_ptr(g);
|
|
struct nvgpu_ecc_stat *stats = NULL;
|
|
u32 gpc_count;
|
|
u32 gpc;
|
|
|
|
if (*stats_p != NULL) {
|
|
gpc_count = nvgpu_gr_config_get_gpc_count(gr_config);
|
|
stats = *stats_p;
|
|
|
|
for (gpc = 0; gpc < gpc_count; gpc++) {
|
|
nvgpu_ecc_stat_del(g, &stats[gpc]);
|
|
}
|
|
|
|
nvgpu_kfree(g, stats);
|
|
*stats_p = NULL;
|
|
}
|
|
}
|
|
|
|
void nvgpu_gr_ecc_free(struct gk20a *g)
|
|
{
|
|
struct nvgpu_gr_config *gr_config = nvgpu_gr_get_config_ptr(g);
|
|
|
|
nvgpu_log(g, gpu_dbg_gr, " ");
|
|
|
|
if (gr_config == NULL) {
|
|
return;
|
|
}
|
|
|
|
if (g->ops.gr.ecc.fecs_ecc_deinit != NULL) {
|
|
g->ops.gr.ecc.fecs_ecc_deinit(g);
|
|
}
|
|
|
|
if (g->ops.gr.ecc.gpc_tpc_ecc_deinit != NULL) {
|
|
g->ops.gr.ecc.gpc_tpc_ecc_deinit(g);
|
|
}
|
|
}
|