Alex Waterman 3f7b312e89 gpu: nvgpu: Adjust error condition checking in pd_alloc code ...

The following error checking code in  nvgpu_pd_cache_alloc() cannot
hit the greater than PAGE_SIZE check:

  if ((bytes & (bytes - 1U)) != 0U ||
      (bytes >= PAGE_SIZE ||
       bytes < NVGPU_PD_CACHE_MIN)) {
          /* ... */

This is because the nvgpu_pd_cache_alloc() function is only called,
specifically when, bytes is less than PAGE_SIZE! As such we would
only see this case when there's a bug.

So change the error condition to now check only for bytes being a
power of 2 and being greater than NVGPU_PD_CACHE_MIN. The greater
than page size check has been turned into an assert since this
should really never happen in practice unless there's a bug.

JIRA NVGPU-1323

Change-Id: I97cd701aa4f045345606b90c97a8478b4a06e189
Signed-off-by: Alex Waterman <alexw@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1946731
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>

2018-11-14 12:43:50 -08:00

..

nvgpu

gpu: nvgpu: Adjust error condition checking in pd_alloc code

2018-11-14 12:43:50 -08:00

Makefile

nvgpu: use kernel overlay features

2017-10-29 11:00:55 -07:00