mirror of
git://nv-tegra.nvidia.com/linux-nvgpu.git
synced 2025-12-22 17:36:20 +03:00
Below MISRA 10.4 violation is reported in nvgpu.common.mm.vm_area
${TEGRA_TOP}/kernel/nvgpu/drivers/gpu/nvgpu/common/mm/vm_area.c:234:
misra_violation: The condition clause expression of the for loop has
persistent side-effects.
Fix this by replacing with a while loop.
Jira NVGPU-3330
Change-Id: Ica6882d6c73dc0d74159f34279d8f91b7494c65c
Signed-off-by: Thomas Fleury <tfleury@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2117059
GVS: Gerrit_Virtual_Submit
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: Philip Elcan <pelcan@nvidia.com>
Reviewed-by: Vinod Gopalakrishnakurup <vinodg@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
260 lines
7.1 KiB
C
260 lines
7.1 KiB
C
/*
|
|
* Copyright (c) 2017-2019, NVIDIA CORPORATION. All rights reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include <nvgpu/vm.h>
|
|
#include <nvgpu/vm_area.h>
|
|
#include <nvgpu/barrier.h>
|
|
#include <nvgpu/gk20a.h>
|
|
|
|
|
|
struct nvgpu_vm_area *nvgpu_vm_area_find(struct vm_gk20a *vm, u64 addr)
|
|
{
|
|
struct nvgpu_vm_area *vm_area;
|
|
|
|
nvgpu_list_for_each_entry(vm_area, &vm->vm_area_list,
|
|
nvgpu_vm_area, vm_area_list) {
|
|
if (addr >= vm_area->addr &&
|
|
addr < (u64)vm_area->addr + (u64)vm_area->size) {
|
|
return vm_area;
|
|
}
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
int nvgpu_vm_area_validate_buffer(struct vm_gk20a *vm,
|
|
u64 map_addr, u64 map_size, u32 pgsz_idx,
|
|
struct nvgpu_vm_area **pvm_area)
|
|
{
|
|
struct gk20a *g = vm->mm->g;
|
|
struct nvgpu_vm_area *vm_area;
|
|
struct nvgpu_mapped_buf *buffer;
|
|
u64 map_end = map_addr + map_size;
|
|
|
|
/* can wrap around with insane map_size; zero is disallowed too */
|
|
if (map_end <= map_addr) {
|
|
nvgpu_warn(g, "fixed offset mapping with invalid map_size");
|
|
return -EINVAL;
|
|
}
|
|
|
|
if ((map_addr & (U64(vm->gmmu_page_sizes[pgsz_idx]) - U64(1))) != 0ULL) {
|
|
nvgpu_err(g, "map offset must be buffer page size aligned 0x%llx",
|
|
map_addr);
|
|
return -EINVAL;
|
|
}
|
|
|
|
/* Find the space reservation, but it's ok to have none for
|
|
* userspace-managed address spaces */
|
|
vm_area = nvgpu_vm_area_find(vm, map_addr);
|
|
if (vm_area == NULL && !vm->userspace_managed) {
|
|
nvgpu_warn(g, "fixed offset mapping without space allocation");
|
|
return -EINVAL;
|
|
}
|
|
|
|
/* Mapped area should fit inside va, if there's one */
|
|
if (vm_area != NULL && map_end > vm_area->addr + vm_area->size) {
|
|
nvgpu_warn(g, "fixed offset mapping size overflows va node");
|
|
return -EINVAL;
|
|
}
|
|
|
|
/* check that this mapping does not collide with existing
|
|
* mappings by checking the buffer with the highest GPU VA
|
|
* that is less than our buffer end */
|
|
buffer = nvgpu_vm_find_mapped_buf_less_than(
|
|
vm, map_addr + map_size);
|
|
if (buffer != NULL && buffer->addr + buffer->size > map_addr) {
|
|
nvgpu_warn(g, "overlapping buffer map requested");
|
|
return -EINVAL;
|
|
}
|
|
|
|
*pvm_area = vm_area;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int nvgpu_vm_area_alloc(struct vm_gk20a *vm, u32 pages, u32 page_size,
|
|
u64 *addr, u32 flags)
|
|
{
|
|
struct gk20a *g = vm->mm->g;
|
|
struct nvgpu_allocator *vma;
|
|
struct nvgpu_vm_area *vm_area;
|
|
u64 vaddr_start = 0;
|
|
u64 our_addr = *addr;
|
|
u32 pgsz_idx = GMMU_PAGE_SIZE_SMALL;
|
|
|
|
/*
|
|
* If we have a fixed address then use the passed address in *addr. This
|
|
* corresponds to the o_a field in the IOCTL. But since we do not
|
|
* support specific alignments in the buddy allocator we ignore the
|
|
* field if it isn't a fixed offset.
|
|
*/
|
|
if ((flags & NVGPU_VM_AREA_ALLOC_FIXED_OFFSET) != 0U) {
|
|
our_addr = *addr;
|
|
}
|
|
|
|
nvgpu_log(g, gpu_dbg_map,
|
|
"ADD vm_area: pgsz=%#-8x pages=%-9u a/o=%#-14llx flags=0x%x",
|
|
page_size, pages, our_addr, flags);
|
|
|
|
for (; pgsz_idx < GMMU_NR_PAGE_SIZES; pgsz_idx++) {
|
|
if (vm->gmmu_page_sizes[pgsz_idx] == page_size) {
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (pgsz_idx > GMMU_PAGE_SIZE_BIG) {
|
|
return -EINVAL;
|
|
}
|
|
|
|
/*
|
|
* pgsz_idx isn't likely to get too crazy, since it starts at 0 and
|
|
* increments but this ensures that we still have a definitely valid
|
|
* page size before proceeding.
|
|
*/
|
|
nvgpu_speculation_barrier();
|
|
|
|
if (!vm->big_pages && pgsz_idx == GMMU_PAGE_SIZE_BIG) {
|
|
return -EINVAL;
|
|
}
|
|
|
|
vm_area = nvgpu_kzalloc(g, sizeof(*vm_area));
|
|
if (vm_area == NULL) {
|
|
goto clean_up_err;
|
|
}
|
|
|
|
vma = vm->vma[pgsz_idx];
|
|
if ((flags & NVGPU_VM_AREA_ALLOC_FIXED_OFFSET) != 0U) {
|
|
vaddr_start = nvgpu_alloc_fixed(vma, our_addr,
|
|
(u64)pages *
|
|
(u64)page_size,
|
|
page_size);
|
|
} else {
|
|
vaddr_start = nvgpu_alloc_pte(vma,
|
|
(u64)pages *
|
|
(u64)page_size,
|
|
page_size);
|
|
}
|
|
|
|
if (vaddr_start == 0ULL) {
|
|
goto clean_up_err;
|
|
}
|
|
|
|
vm_area->flags = flags;
|
|
vm_area->addr = vaddr_start;
|
|
vm_area->size = (u64)page_size * (u64)pages;
|
|
vm_area->pgsz_idx = pgsz_idx;
|
|
nvgpu_init_list_node(&vm_area->buffer_list_head);
|
|
nvgpu_init_list_node(&vm_area->vm_area_list);
|
|
|
|
nvgpu_mutex_acquire(&vm->update_gmmu_lock);
|
|
|
|
if ((flags & NVGPU_VM_AREA_ALLOC_SPARSE) != 0U) {
|
|
u64 map_addr = g->ops.mm.gmmu.map(vm, vaddr_start,
|
|
NULL,
|
|
0,
|
|
vm_area->size,
|
|
pgsz_idx,
|
|
0,
|
|
0,
|
|
flags,
|
|
gk20a_mem_flag_none,
|
|
false,
|
|
true,
|
|
false,
|
|
NULL,
|
|
APERTURE_INVALID);
|
|
if (map_addr == 0ULL) {
|
|
nvgpu_mutex_release(&vm->update_gmmu_lock);
|
|
goto clean_up_err;
|
|
}
|
|
|
|
vm_area->sparse = true;
|
|
}
|
|
nvgpu_list_add_tail(&vm_area->vm_area_list, &vm->vm_area_list);
|
|
|
|
nvgpu_mutex_release(&vm->update_gmmu_lock);
|
|
|
|
*addr = vaddr_start;
|
|
return 0;
|
|
|
|
clean_up_err:
|
|
if (vaddr_start != 0ULL) {
|
|
nvgpu_free(vma, vaddr_start);
|
|
}
|
|
if (vm_area != NULL) {
|
|
nvgpu_kfree(g, vm_area);
|
|
}
|
|
return -ENOMEM;
|
|
}
|
|
|
|
int nvgpu_vm_area_free(struct vm_gk20a *vm, u64 addr)
|
|
{
|
|
struct gk20a *g = gk20a_from_vm(vm);
|
|
struct nvgpu_mapped_buf *buffer;
|
|
struct nvgpu_vm_area *vm_area;
|
|
|
|
nvgpu_mutex_acquire(&vm->update_gmmu_lock);
|
|
vm_area = nvgpu_vm_area_find(vm, addr);
|
|
if (vm_area == NULL) {
|
|
nvgpu_mutex_release(&vm->update_gmmu_lock);
|
|
return 0;
|
|
}
|
|
nvgpu_list_del(&vm_area->vm_area_list);
|
|
|
|
nvgpu_log(g, gpu_dbg_map,
|
|
"DEL vm_area: pgsz=%#-8x pages=%-9llu "
|
|
"addr=%#-14llx flags=0x%x",
|
|
vm->gmmu_page_sizes[vm_area->pgsz_idx],
|
|
vm_area->size / vm->gmmu_page_sizes[vm_area->pgsz_idx],
|
|
vm_area->addr,
|
|
vm_area->flags);
|
|
|
|
/* Decrement the ref count on all buffers in this vm_area. This
|
|
* allows userspace to let the kernel free mappings that are
|
|
* only used by this vm_area. */
|
|
while (!nvgpu_list_empty(&vm_area->buffer_list_head)) {
|
|
buffer = nvgpu_list_first_entry(&vm_area->buffer_list_head,
|
|
nvgpu_mapped_buf, buffer_list);
|
|
nvgpu_list_del(&buffer->buffer_list);
|
|
nvgpu_ref_put(&buffer->ref, nvgpu_vm_unmap_ref_internal);
|
|
}
|
|
|
|
/* if this was a sparse mapping, free the va */
|
|
if (vm_area->sparse) {
|
|
g->ops.mm.gmmu.unmap(vm,
|
|
vm_area->addr,
|
|
vm_area->size,
|
|
vm_area->pgsz_idx,
|
|
false,
|
|
gk20a_mem_flag_none,
|
|
true,
|
|
NULL);
|
|
}
|
|
|
|
nvgpu_mutex_release(&vm->update_gmmu_lock);
|
|
|
|
nvgpu_free(vm->vma[vm_area->pgsz_idx], vm_area->addr);
|
|
nvgpu_kfree(g, vm_area);
|
|
|
|
return 0;
|
|
}
|