Files
linux-nvgpu/drivers/gpu/nvgpu/os/posix/nvgpu.c
Alex Waterman 9edd68ac52 nvgpu: gpu: posix: Fix order of memset() after malloc()
A memset was being done right before checking the malloc'ed pointer
for NULL. This completely ruins the purpose of the NULL check!

Change-Id: I3d6bc000f20054b5ff18d1171e51b227628ccf7c
Signed-off-by: Alex Waterman <alexw@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2096466
Reviewed-by: Nicolas Benech <nbenech@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-misra <svc-mobile-misra@nvidia.com>
Reviewed-by: Philip Elcan <pelcan@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
2019-04-16 14:14:36 -07:00

122 lines
2.8 KiB
C

/*
* Copyright (c) 2018-2019, NVIDIA CORPORATION. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
#include <unistd.h>
#include <stdlib.h>
#include <pthread.h>
#include <nvgpu/bug.h>
#include <nvgpu/types.h>
#include <nvgpu/atomic.h>
#include <nvgpu/nvgpu_common.h>
#include <nvgpu/os_sched.h>
#include <nvgpu/gk20a.h>
#include <nvgpu/enabled.h>
#include <nvgpu/posix/probe.h>
#include "os_posix.h"
/*
* Somewhat meaningless in userspace...
*/
void nvgpu_kernel_restart(void *cmd)
{
BUG();
}
/*
* We have no runtime PM stuff in userspace so these are really just noops.
*/
void gk20a_busy_noresume(struct gk20a *g)
{
}
void gk20a_idle_nosuspend(struct gk20a *g)
{
}
int gk20a_busy(struct gk20a *g)
{
nvgpu_atomic_inc(&g->usage_count);
return 0;
}
void gk20a_idle(struct gk20a *g)
{
nvgpu_atomic_dec(&g->usage_count);
}
/*
* This function aims to initialize enough stuff to make unit testing worth
* while. There are several interfaces and APIs that rely on the struct gk20a's
* state in order to function: logging, for example, but there are many other
* things, too.
*
* Initialize as much of that as possible here. This is meant to be equivalent
* to the kernel space driver's probe function.
*/
struct gk20a *nvgpu_posix_probe(void)
{
struct gk20a *g;
struct nvgpu_os_posix *p;
p = malloc(sizeof(*p));
if (p == NULL) {
return NULL;
}
(void) memset(p, 0, sizeof(*p));
g = &p->g;
g->log_mask = 0;
g->mm.g = g;
if (nvgpu_kmem_init(g) != 0) {
goto fail_kmem;
}
if (nvgpu_init_enabled_flags(g) != 0) {
goto fail_enabled_flags;
}
return g;
fail_enabled_flags:
nvgpu_kmem_fini(g, 0);
fail_kmem:
free(p);
return NULL;
}
void nvgpu_posix_cleanup(struct gk20a *g)
{
struct nvgpu_os_posix *p = nvgpu_os_posix_from_gk20a(g);
nvgpu_kmem_fini(g, 0);
nvgpu_free_enabled_flags(g);
free(p);
}