mirror of
git://nv-tegra.nvidia.com/linux-nvgpu.git
synced 2025-12-24 18:42:29 +03:00
The valid flag in struct nvgpu_fence_type is not very useful. It's set when a fence is created on an allocated object and read in these three scenarios: - nvgpu_fence_install_fd() after a submit, if the submit was successful. A successful submit implies that a post fence exists. - nvgpu_fence_wait() for a copyengine job when synchronizing the ce ringbuffer or when waiting for vidmem clears. In these cases the fence is also clearly always valid. - nvgpu_fence_is_expired() when testing whether a tracked job has completed. Such jobs cannot exist without post fences that are mandatory for tracking, so the fence must exist. Remove the valid flag. Remove also the other init checks from the above functions; they're equally unused and confusing implying that such calls would be acceptable, causing sloppy code at best. Jira NVGPU-5248 Jira NVGPU-5493 Change-Id: I52c5be1569b343024d2626bd9577f87b46064fba Signed-off-by: Konsta Hölttä <kholtta@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2357828 Reviewed-by: automaticguardword <automaticguardword@nvidia.com> Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> Reviewed-by: svc-mobile-misra <svc-mobile-misra@nvidia.com> Reviewed-by: svc-mobile-cert <svc-mobile-cert@nvidia.com> Reviewed-by: Alex Waterman <alexw@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>