Files
linux-nvgpu/drivers/gpu/nvgpu/boardobj/boardobj.c
Sai Nikhil 9de30e1f95 gpu: nvgpu: boardobj: fix MISRA 10.4 Violations
MISRA Rule 10.4 only allows the usage of arithmetic operations on
operands of the same essential type category.

Adding "U" at the end of the integer literals to have same type of
operands when an arithmetic operation is performed.

This fixes violation where an arithmetic operation is performed on
signed and unsigned int types.

JIRA NVGPU-992

Change-Id: I1e8659ee6759b05dec93bef83928bae77a9ee01b
Signed-off-by: Sai Nikhil <snikhil@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1812198
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Adeel Raza <araza@nvidia.com>
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
2018-10-18 03:22:42 -07:00

103 lines
2.8 KiB
C

/*
* Copyright (c) 2016-2018, NVIDIA CORPORATION. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
#include <nvgpu/kmem.h>
#include <nvgpu/gk20a.h>
#include "boardobj.h"
#include "ctrl/ctrlboardobj.h"
int boardobj_construct_super(struct gk20a *g, struct boardobj **ppboardobj,
u16 size, void *args)
{
struct boardobj *pboardobj = NULL;
struct boardobj *devtmp = (struct boardobj *)args;
nvgpu_log_info(g, " ");
if (devtmp == NULL) {
return -EINVAL;
}
if (*ppboardobj == NULL) {
*ppboardobj = nvgpu_kzalloc(g, size);
if (*ppboardobj == NULL) {
return -ENOMEM;
}
(*ppboardobj)->allocated = true;
}
pboardobj = *ppboardobj;
pboardobj->g = g;
pboardobj->type = devtmp->type;
pboardobj->idx = CTRL_BOARDOBJ_IDX_INVALID;
pboardobj->type_mask = BIT(pboardobj->type) | devtmp->type_mask;
pboardobj->implements = boardobj_implements_super;
pboardobj->destruct = boardobj_destruct_super;
pboardobj->pmudatainit = boardobj_pmudatainit_super;
nvgpu_list_add(&pboardobj->node, &g->boardobj_head);
return 0;
}
int boardobj_destruct_super(struct boardobj *pboardobj)
{
struct gk20a *g = pboardobj->g;
nvgpu_log_info(g, " ");
if (pboardobj == NULL) {
return -EINVAL;
}
nvgpu_list_del(&pboardobj->node);
if (pboardobj->allocated) {
nvgpu_kfree(pboardobj->g, pboardobj);
}
return 0;
}
bool boardobj_implements_super(struct gk20a *g, struct boardobj *pboardobj,
u8 type)
{
nvgpu_log_info(g, " ");
return (0U != (pboardobj->type_mask & BIT(type)));
}
int boardobj_pmudatainit_super(struct gk20a *g, struct boardobj *pboardobj,
struct nv_pmu_boardobj *pmudata)
{
nvgpu_log_info(g, " ");
if (pboardobj == NULL) {
return -EINVAL;
}
if (pmudata == NULL) {
return -EINVAL;
}
pmudata->type = pboardobj->type;
nvgpu_log_info(g, " Done");
return 0;
}