mirror of
git://nv-tegra.nvidia.com/linux-nvgpu.git
synced 2025-12-23 01:50:07 +03:00
535a27411a
Allocator (bitmap, buddy, page) debugfs files are not cleaned up when the allocators are destroyed. This leads to warning logs from nvgpu like below: [21073.493000] debugfs: File 'gk20a_as_17' in directory 'allocators' already present! [21073.493026] debugfs: File 'gk20a_as_17-sys' in directory 'allocators' already present! Remove the per-allocator debugfs node when destroying an allocator in runtime. While at this, add missing nvgpu_allocator locking to the function nvgpu_bitmap_alloc_destroy. And create nop functions for the functions nvgpu_init_alloc_debug and nvgpu_fini_alloc_debug when CONFIG_DEBUG_FS is not defined to avoid adding the CONFIG checks at multiple places. Move gk20a_debug_deinit to the end of gk20a_free_cb called in nvgpu_put as that tears down all debugfs entries. Allocator destroy happens as part of nvgpu_put call and it can lead to invalid debugfs dentry access if gk20a_debug_deinit is called before it. Bug 3481097 Change-Id: I8a66bcf6ade7e5707f9207c78a54d12d7bd94c02 Signed-off-by: Sagar Kamble <skamble@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2648012 Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
76 lines
1.8 KiB
C
76 lines
1.8 KiB
C
/*
|
|
* Copyright (C) 2017-2022 NVIDIA Corporation. All rights reserved.
|
|
*
|
|
* This software is licensed under the terms of the GNU General Public
|
|
* License version 2, as published by the Free Software Foundation, and
|
|
* may be copied, distributed, and modified under those terms.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
*/
|
|
|
|
#include "debug_allocator.h"
|
|
#include "os_linux.h"
|
|
|
|
#include <linux/debugfs.h>
|
|
#include <linux/seq_file.h>
|
|
|
|
#include <nvgpu/allocator.h>
|
|
|
|
static int __alloc_show(struct seq_file *s, void *unused)
|
|
{
|
|
struct nvgpu_allocator *a = s->private;
|
|
|
|
nvgpu_alloc_print_stats(a, s, 1);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int __alloc_open(struct inode *inode, struct file *file)
|
|
{
|
|
return single_open(file, __alloc_show, inode->i_private);
|
|
}
|
|
|
|
static const struct file_operations __alloc_fops = {
|
|
.open = __alloc_open,
|
|
.read = seq_read,
|
|
.llseek = seq_lseek,
|
|
.release = single_release,
|
|
};
|
|
|
|
void nvgpu_init_alloc_debug(struct gk20a *g, struct nvgpu_allocator *a)
|
|
{
|
|
struct nvgpu_os_linux *l = nvgpu_os_linux_from_gk20a(g);
|
|
|
|
if (!l->debugfs_allocators)
|
|
return;
|
|
|
|
a->debugfs_entry = debugfs_create_file(a->name, S_IRUGO,
|
|
l->debugfs_allocators,
|
|
a, &__alloc_fops);
|
|
}
|
|
|
|
void nvgpu_fini_alloc_debug(struct nvgpu_allocator *a)
|
|
{
|
|
struct nvgpu_os_linux *l = nvgpu_os_linux_from_gk20a(a->g);
|
|
|
|
if (!l->debugfs_allocators)
|
|
return;
|
|
|
|
debugfs_remove(a->debugfs_entry);
|
|
}
|
|
|
|
void nvgpu_alloc_debugfs_init(struct gk20a *g)
|
|
{
|
|
struct nvgpu_os_linux *l = nvgpu_os_linux_from_gk20a(g);
|
|
|
|
l->debugfs_allocators = debugfs_create_dir("allocators", l->debugfs);
|
|
if (IS_ERR_OR_NULL(l->debugfs_allocators)) {
|
|
l->debugfs_allocators = NULL;
|
|
return;
|
|
}
|
|
}
|