Files
linux-nvgpu/drivers/gpu/nvgpu/common/power_features/pg/pg.c
Divya b4b98aba02 gpu: nvgpu: reorder elpg and elpg_ms flags check
- In rmmod path, gr struct is freed first and then
  info_mem_destroy is called which calls elpg_ms
  protected call. This in turn waits for gr init
  where gr struct is accessed. This could lead to
  NULL access.
- move elpg and elpg_ms flag check before checking
  pg initialized and gr wait conditions to avoid
  the NULL access issue.

Bug 3848290

Change-Id: I088d89d7876405cc7abedb777884b442726e992f
Signed-off-by: Divya <dsinghatwari@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2811131
Reviewed-by: svcacv <svcacv@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-cert <svc-mobile-cert@nvidia.com>
Reviewed-by: Sagar Kamble <skamble@nvidia.com>
Reviewed-by: Mahantesh Kumbar <mkumbar@nvidia.com>
GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>
2022-12-01 11:03:05 -08:00

177 lines
4.0 KiB
C

/*
* Copyright (c) 2019-2022, NVIDIA CORPORATION. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
#include <nvgpu/gk20a.h>
#ifdef CONFIG_NVGPU_LS_PMU
#include <nvgpu/pmu.h>
#include <nvgpu/pmu/pmu_pg.h>
#endif
#include <nvgpu/power_features/pg.h>
bool nvgpu_pg_elpg_is_enabled(struct gk20a *g)
{
bool elpg_enabled;
nvgpu_log_fn(g, " ");
nvgpu_mutex_acquire(&g->cg_pg_lock);
elpg_enabled = g->elpg_enabled;
nvgpu_mutex_release(&g->cg_pg_lock);
return elpg_enabled;
}
int nvgpu_pg_elpg_enable(struct gk20a *g)
{
int err = 0;
#ifdef CONFIG_NVGPU_LS_PMU
if (!g->can_elpg) {
return 0;
}
nvgpu_log_fn(g, " ");
g->ops.gr.init.wait_initialized(g);
nvgpu_mutex_acquire(&g->cg_pg_lock);
if (g->elpg_enabled) {
err = nvgpu_pmu_pg_global_enable(g, true);
}
nvgpu_mutex_release(&g->cg_pg_lock);
#endif
return err;
}
int nvgpu_pg_elpg_disable(struct gk20a *g)
{
int err = 0;
#ifdef CONFIG_NVGPU_LS_PMU
if (!g->can_elpg) {
return 0;
}
nvgpu_log_fn(g, " ");
g->ops.gr.init.wait_initialized(g);
nvgpu_mutex_acquire(&g->cg_pg_lock);
if (g->elpg_enabled) {
err = nvgpu_pmu_pg_global_enable(g, false);
}
nvgpu_mutex_release(&g->cg_pg_lock);
#endif
return err;
}
int nvgpu_pg_elpg_set_elpg_enabled(struct gk20a *g, bool enable)
{
int err = 0;
bool change_mode = false;
nvgpu_log_fn(g, " ");
if (!g->can_elpg) {
return 0;
}
g->ops.gr.init.wait_initialized(g);
nvgpu_mutex_acquire(&g->cg_pg_lock);
if (enable) {
if (!g->elpg_enabled) {
change_mode = true;
g->elpg_enabled = true;
}
} else {
if (g->elpg_enabled) {
change_mode = true;
g->elpg_enabled = false;
}
}
if (!change_mode) {
goto done;
}
#ifdef CONFIG_NVGPU_LS_PMU
err = nvgpu_pmu_pg_global_enable(g, enable);
#endif
done:
nvgpu_mutex_release(&g->cg_pg_lock);
return err;
}
int nvgpu_pg_elpg_ms_enable(struct gk20a *g)
{
int err = 0;
#ifdef CONFIG_NVGPU_LS_PMU
nvgpu_log_fn(g, " ");
if (!g->can_elpg) {
return 0;
}
/*
* If elpg and elpg_ms flags are set to true
* and pg is initialized then only we wait
* for gr init. In rmmod path, the gr struct
* could be freed earlier. In order to avoid
* NULL access for gr, we check for these
* conditions then proceed further.
*/
if ((g->elpg_enabled) && (g->elpg_ms_enabled) &&
(g->pmu->pg->initialized)) {
g->ops.gr.init.wait_initialized(g);
nvgpu_mutex_acquire(&g->cg_pg_lock);
err = nvgpu_pmu_enable_elpg_ms(g);
nvgpu_mutex_release(&g->cg_pg_lock);
}
#endif
return err;
}
int nvgpu_pg_elpg_ms_disable(struct gk20a *g)
{
int err = 0;
#ifdef CONFIG_NVGPU_LS_PMU
nvgpu_log_fn(g, " ");
if (!g->can_elpg) {
return 0;
}
/*
* If elpg and elpg_ms flags are set to true
* then only we check further conditions.
*/
if ((g->elpg_enabled) && (g->elpg_ms_enabled)) {
if (g->pmu->pg->initialized) {
g->ops.gr.init.wait_initialized(g);
nvgpu_mutex_acquire(&g->cg_pg_lock);
err = nvgpu_pmu_disable_elpg_ms(g);
nvgpu_mutex_release(&g->cg_pg_lock);
}
}
#endif
return err;
}