mirror of
git://nv-tegra.nvidia.com/linux-nvgpu.git
synced 2025-12-22 17:36:20 +03:00
40064ef1ec
ECC counter structures are freed without removing the node from the stats_list. This can lead to invalid access due to dangling pointers. Update the ecc counter free logic to set them to NULL upon free, to remove them from stats_list and free them by validation. Also updated some of the ecc init paths where error was not propa- gated to callers and full ecc counters deallocation was not done. Now, calling unit ecc_free from any context (with counters alloc- ated or not) is harmless as requisite checks are in place. bug 3326612 bug 3345977 Change-Id: I05eb6ed226cff9197ad37776912da9dcb7e0716d Signed-off-by: Sagar Kamble <skamble@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2565264 Tested-by: Ashish Mhetre <amhetre@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> Reviewed-by: svc_kernel_abi <svc_kernel_abi@nvidia.com> Reviewed-by: Konsta Holtta <kholtta@nvidia.com> Reviewed-by: Deepak Nibade <dnibade@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit
92 lines
2.3 KiB
C
92 lines
2.3 KiB
C
/*
|
|
* Copyright (c) 2018-2021, NVIDIA CORPORATION. All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms and conditions of the GNU General Public License,
|
|
* version 2, as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <nvgpu/ecc.h>
|
|
#include <nvgpu/gk20a.h>
|
|
|
|
#include "os_linux.h"
|
|
|
|
int nvgpu_ecc_sysfs_init(struct gk20a *g)
|
|
{
|
|
struct device *dev = dev_from_gk20a(g);
|
|
struct nvgpu_ecc *ecc = &g->ecc;
|
|
struct dev_ext_attribute *attr;
|
|
struct nvgpu_os_linux *l = nvgpu_os_linux_from_gk20a(g);
|
|
struct nvgpu_ecc_stat *stat;
|
|
int i = 0, err;
|
|
|
|
nvgpu_mutex_acquire(&ecc->stats_lock);
|
|
|
|
attr = nvgpu_kzalloc(g, sizeof(*attr) * ecc->stats_count);
|
|
if (!attr) {
|
|
nvgpu_mutex_release(&ecc->stats_lock);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
nvgpu_list_for_each_entry(stat,
|
|
&ecc->stats_list, nvgpu_ecc_stat, node) {
|
|
if (i >= ecc->stats_count) {
|
|
err = -EINVAL;
|
|
nvgpu_err(g, "stats_list longer than stats_count %d",
|
|
ecc->stats_count);
|
|
break;
|
|
}
|
|
sysfs_attr_init(&attr[i].attr.attr);
|
|
attr[i].attr.attr.name = stat->name;
|
|
attr[i].attr.attr.mode = VERIFY_OCTAL_PERMISSIONS(S_IRUGO);
|
|
attr[i].var = &stat->counter;
|
|
attr[i].attr.show = device_show_int;
|
|
err = device_create_file(dev, &attr[i].attr);
|
|
if (err) {
|
|
nvgpu_err(g, "sysfs node create failed for %s\n",
|
|
stat->name);
|
|
break;
|
|
}
|
|
i++;
|
|
}
|
|
|
|
nvgpu_mutex_release(&ecc->stats_lock);
|
|
|
|
if (err) {
|
|
while (i-- > 0)
|
|
device_remove_file(dev, &attr[i].attr);
|
|
nvgpu_kfree(g, attr);
|
|
return err;
|
|
}
|
|
|
|
l->ecc_attrs = attr;
|
|
|
|
return 0;
|
|
}
|
|
|
|
void nvgpu_ecc_sysfs_remove(struct gk20a *g)
|
|
{
|
|
struct device *dev = dev_from_gk20a(g);
|
|
struct nvgpu_os_linux *l = nvgpu_os_linux_from_gk20a(g);
|
|
struct nvgpu_ecc *ecc = &g->ecc;
|
|
int i;
|
|
|
|
nvgpu_mutex_acquire(&ecc->stats_lock);
|
|
|
|
for (i = 0; i < ecc->stats_count; i++)
|
|
device_remove_file(dev, &l->ecc_attrs[i].attr);
|
|
|
|
nvgpu_mutex_release(&ecc->stats_lock);
|
|
|
|
nvgpu_kfree(g, l->ecc_attrs);
|
|
l->ecc_attrs = NULL;
|
|
}
|