Files
linux-nvgpu/drivers/gpu/nvgpu/os/posix/nvgpu.c
ddutta cd26a9e248 gpu: nvgpu: handle ioctl l2_fb_ops better
Background: There is a race that occurs when l2_fb_ops ioctl is
invoked. The race occurs as part of the flush() call while a
gk20_idle() is in progress.

This patch handles the race by making changes in the l2_fb_ops
ioctl itself. For cases where pm_runtime is disabled or railgate is
disabled, we allow this ioctl call to always go ahead as power is
assumed to be always on.

For the other case, we first check the status of g->power_on. In the
driver, g->power_on is set to true, once unrailgate is completed and is
set to false just before calling railgate.

For linux, the driver invokes gk20a_idle() but there is a delay after
which the call to the rpm_suspend()'s callback gets triggered. This
leads to a scenario where we cannot efficiently rely on the
runtime_pm's APIs to allow us to block an imminent suspend or exit if
the suspend is currently in progress. Previous attempts at solving this
has lead to ineffective solutions and make it much complicated to
maintain the code.

With regards to the above, this patch attempts to simplify the way this
can be solved. The patch calls gk20a_busy() when g->power_on = true.
This prevents the race with gk20a_idle(). Based on the rpm_resume and
rpm_suspend's upstream code, resume is prioritized over a suspend
unless a suspend is already in progress i.e. the delay period has been
served and the suspend invokes the callback. There is a very small
window for this to happen and the ioctl can then power_up the device as
evident from the gk20a_busy's calls.

A new function gk20a_check_poweron() is added. This function protects
the access to g->power_on via a mutex. By preventing a read from
happening simulatenously as a write on g->power_on, the likelihood of
an runtime_suspend triggering before a runtime_resume is further
reduced.

Bug 200507468

Change-Id: I5c02dfa8ea855732e59b759d167152cf45a1131f
Signed-off-by:Debarshi Dutta <ddutta@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2299545
(cherry picked from commit 06942bd268)
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2423879
Tested-by: Amulya Yarlagadda <ayarlagadda@nvidia.com>
Reviewed-by: Amulya Yarlagadda <ayarlagadda@nvidia.com>
2020-10-08 21:53:50 -07:00

150 lines
3.6 KiB
C

/*
* Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
#include <unistd.h>
#include <stdlib.h>
#include <pthread.h>
#include <nvgpu/gk20a.h>
#include <nvgpu/bug.h>
#include <nvgpu/types.h>
#include <nvgpu/atomic.h>
#include <nvgpu/nvgpu_common.h>
#include <nvgpu/os_sched.h>
#include <nvgpu/gk20a.h>
#include <nvgpu/posix/probe.h>
#include "os_posix.h"
void nvgpu_wait_for_deferred_interrupts(struct gk20a *g)
{
/*
* No interrupts in userspace so nothing to wait for.
*/
}
int nvgpu_current_pid(struct gk20a *g)
{
/*
* In the kernel this gets us the PID of the calling process for IOCTLs.
* But since we are in userspace this doesn't quite mean the same thing.
* This simply returns the PID of the currently running process.
*/
return (int)getpid();
}
int nvgpu_current_tid(struct gk20a *g)
{
/*
* In POSIX thread ID is not the same as a process ID. In Linux threads
* and processes are represented by the same thing, but userspace can't
* really rely on that.
*
* We can, however, get a pthread_t for a given thread. But this
* pthread_t need not have any relation to the underlying system's
* representation of "threads".
*/
return (int)pthread_self();
}
void __nvgpu_print_current(struct gk20a *g, const char *func_name, int line,
void *ctx, enum nvgpu_log_type type)
{
__nvgpu_log_msg(g, func_name, line, type,
"Current process: (nvgpu userspace)");
}
/*
* Somewhat meaningless in userspace...
*/
void nvgpu_kernel_restart(void *cmd)
{
BUG();
}
/*
* We have no runtime PM stuff in userspace so these are really just noops.
*/
void gk20a_busy_noresume(struct gk20a *g)
{
}
void gk20a_idle_nosuspend(struct gk20a *g)
{
}
bool gk20a_check_poweron(struct gk20a *g)
{
return false;
}
int gk20a_busy(struct gk20a *g)
{
nvgpu_atomic_inc(&g->usage_count);
return 0;
}
void gk20a_idle(struct gk20a *g)
{
nvgpu_atomic_dec(&g->usage_count);
}
/*
* This function aims to initialize enough stuff to make unit testing worth
* while. There are several interfaces and APIs that rely on the struct gk20a's
* state in order to function: logging, for example, but there are many other
* things, too.
*
* Initialize as much of that as possible here. This is meant to be equivalent
* to the kernel space driver's probe function.
*/
struct gk20a *nvgpu_posix_probe(void)
{
struct gk20a *g;
struct nvgpu_os_posix *p;
int err;
p = malloc(sizeof(*p));
if (p == NULL)
return NULL;
g = &p->g;
err = nvgpu_kmem_init(g);
if (err != 0)
goto fail;
return g;
fail:
free(p);
return NULL;
}
void nvgpu_posix_cleanup(struct gk20a *g)
{
nvgpu_kmem_fini(g, 0);
}