Files
linux-nvgpu/userspace/src/nvgpu.c
asah 03145af1eb gpu: nvgpu: remove RTLD_GLOBAL flag from libnvgpu-drv.so dlopen for QNX tests
currently libnvgpu-drv.so is opened with RTLD_GLOBAL flag which is
required for nvgpu common tests but for qnx tests we dont need any
symbol from libnvgpu-drv.so (except nvgpu_posix_probe and
nvgpu_posix_cleanup which we will eventually remove for qnx) so
RTLD_GLOBAL should not be used in case of qnx tests. If RTLD_GLOBAL is
used for qnx tests then the symbols from libnvgpu-drv.so will be used
instead of from libqnx_mock.so which is wrong.

This change uses -Q command line option to make the decision about
RTLD_GLOBAL flag

After this change qnx unit tests should be run with -Q option and nvgpu
common unit tests should be run without it

JIRA NVGPU-1352

Change-Id: I759db679f5b95696835c8125c21f95bf35df590c
Signed-off-by: asah <asah@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2011271
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-misra <svc-mobile-misra@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Ankur Kishore <ankkishore@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
2019-02-14 22:13:39 -08:00

86 lines
2.9 KiB
C

/*
* Copyright (c) 2018-2019, NVIDIA CORPORATION. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
#include <dlfcn.h>
#include <stdlib.h>
#include <unit/io.h>
#include <unit/core.h>
/*
* Load libnvgpu-drv.so. This is done with dlopen() since this will make
* resolving addresses into symbols easier in the future.
*
* Also, this makes people think carefully about what functions to call in
* nvgpu-drv from the unit test FW. The interaction should really be limited
* and doing explicit name lookups is a good way to prevent too much coupling.
*/
int core_load_nvgpu(struct unit_fw *fw)
{
const char *msg;
int flag = RTLD_NOW;
if (fw->args->is_qnx == 0) {
/*
* Specify a GLOBAL binding so that subsequently loaded
* unit tests see the nvgpu-drv library. They will of course
* need it (and will access it directly). I.e they will link
* against nvgpu-drv and this should satisfy that linkage.
*/
flag |= RTLD_GLOBAL;
}
/* TODO: WAR: remove this dependency of libnvgpu-drv.so for qnx unit
* test, refer NVGPU-1935 for more detail */
fw->nvgpu_so = dlopen("libnvgpu-drv.so", flag);
if (fw->nvgpu_so == NULL) {
msg = dlerror();
core_err(fw, "Failed to load nvgpu-drv: %s\n", msg);
return -1;
}
/*
* We directly check the value of the returned symbol for these
* functions against NULL because if it is NULL then something is
* terribly wrong.
*/
fw->nvgpu.nvgpu_posix_probe = dlsym(fw->nvgpu_so,
"nvgpu_posix_probe");
if (fw->nvgpu.nvgpu_posix_probe == NULL) {
msg = dlerror();
core_err(fw, "Failed to resolve nvgpu_posix_probe: %s\n", msg);
return -1;
}
fw->nvgpu.nvgpu_posix_cleanup = dlsym(fw->nvgpu_so,
"nvgpu_posix_cleanup");
if (fw->nvgpu.nvgpu_posix_cleanup == NULL) {
msg = dlerror();
core_err(fw, "Failed to resolve nvgpu_posix_cleanup: %s\n", msg);
return -1;
}
return 0;
}