nv-tegra-mirror/nvethernetrm
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/kernel/nvethernetrm.git synced 2025-12-22 09:12:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

osi: core: Cleanup MAC start and stop ioctls

Browse Source 
Issue:
Observed STOP MAC ioctl
failure on standard builds.

Fix:
-Update ivc_core_deinit to call
core_deinit command
- As MAC start and stop is part
of init/deinit clean up these IOCTLs

Bug 3889287

Change-Id: I07ba4dd5dc2e9630a4e4001199c6aae24ade6c70
Signed-off-by: Mohan Thadikamalla <mohant@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/kernel/nvethernetrm/+/2819152
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Mohan Thadikamalla
2022-11-30 15:55:32 +05:30
committed by mobile promotions
parent 3db08e6480
commit 0ee7e64669
3 changed files with 1 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
include/osi_core.h
View File

@@ -78,7 +78,6 @@ typedef my_lint_64 nvel64_t;
#define OSI_CMD_PTP_RXQ_ROUTE 35U
#define OSI_CMD_CONFIG_RSS 37U
#define OSI_CMD_CONFIG_FW_ERR 29U
#define OSI_CMD_START_MAC 5U
#define OSI_CMD_SET_MODE 16U
#define OSI_CMD_POLL_FOR_MAC_RST 4U
#define OSI_CMD_GET_MAC_VER 10U
@@ -232,7 +231,6 @@ typedef my_lint_64 nvel64_t;
* @{
*/
#define OSI_CMD_L3L4_FILTER 3U
#define OSI_CMD_STOP_MAC 6U
#define OSI_CMD_COMMON_ISR 7U
#define OSI_CMD_PAD_CALIBRATION 8U
#define OSI_CMD_READ_MMC 9U
@@ -1582,10 +1580,6 @@ nve32_t osi_init_core_ops(struct osi_core_priv_data *const osi_core);
* arg1_u32 - CSR (AXI CBB) clock rate.
* - OSI_CMD_POLL_FOR_MAC_RST
* Poll Software reset bit in MAC HW
* - OSI_CMD_START_MAC
* Start MAC Tx/Rx engine
* - OSI_CMD_STOP_MAC
* Stop MAC Tx/Rx engine
* - OSI_CMD_COMMON_ISR
* Common ISR handler
* - OSI_CMD_PAD_CALIBRATION

3
osi/core/ivc_core.c
View File

@@ -123,8 +123,7 @@ static void ivc_core_deinit(struct osi_core_priv_data *const osi_core)
osi_memset(&msg, 0, sizeof(msg));
msg.cmd = handle_ioctl;
msg.data.ioctl_data.cmd = OSI_CMD_STOP_MAC;
msg.cmd = core_deinit;
ret = osi_core->osd_ops.ivc_send(osi_core, &msg, sizeof(msg));
if (ret < 0) {

13
osi/core/osi_hal.c
View File

@@ -2157,10 +2157,6 @@ static void store_l2_filter(struct osi_core_priv_data *osi_core,
* Restore backup of MAC MMIO address space
* - OSI_CMD_POLL_FOR_MAC_RST
* Poll Software reset bit in MAC HW
* - OSI_CMD_START_MAC
* Start MAC Tx/Rx engine
* - OSI_CMD_STOP_MAC
* Stop MAC Tx/Rx engine
* - OSI_CMD_COMMON_ISR
* Common ISR handler
* - OSI_CMD_PAD_CALIBRATION
@@ -2413,15 +2409,6 @@ static nve32_t osi_hal_handle_ioctl(struct osi_core_priv_data *osi_core,
ret = hw_poll_for_swr(osi_core);
break;
case OSI_CMD_START_MAC:
hw_start_mac(osi_core);
ret = 0;
break;
case OSI_CMD_STOP_MAC:
hw_stop_mac(osi_core);
ret = 0;
break;
case OSI_CMD_GET_MAC_VER:
ret = osi_get_mac_version(osi_core, &data->arg1_u32);
break;