From 07bbe2fdcf637b4c44e82686d7ea4a7d063ce0cf Mon Sep 17 00:00:00 2001 From: Brad Griffis Date: Fri, 13 Dec 2024 23:56:02 +0000 Subject: [PATCH] arm64: tegra: Fix Tegra234 PCIe interrupt-map For interrupt-map entries, the DTS specification requires that #address-cells is defined for both the child node and the interrupt parent. For the PCIe interrupt-map entries, the parent node ("gic") has not specified #address-cells. The existing layout of the PCIe interrupt-map entries indicates that it assumes that #address-cells is zero for this node. Explicitly set #address-cells to zero for "gic" so that it complies with the device tree specification. NVIDIA EDK2 works around this issue by assuming #address-cells is zero in this scenario, but that workaround is being removed and so this update is needed or else NVIDIA EDK2 cannot successfully parse the device tree and the board cannot boot. Fixes: ec142c44b026 ("arm64: tegra: Add P2U and PCIe controller nodes to Tegra234 DT") Signed-off-by: Brad Griffis Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20241213235602.452303-1-bgriffis@nvidia.com Signed-off-by: Thierry Reding (cherry picked from mainline commit b615fbd70fce8582d92b3bdbbf3c9b80cadcfb55) JIRA TEGRAUEFI-3252 Change-Id: I6dfe58de9346f79ed02b5bd0ff427e317b631db3 Signed-off-by: Brad Griffis Reviewed-on: https://git-master.nvidia.com/r/c/device/hardware/nvidia/t23x-public-dts/+/3295646 (cherry picked from commit 6476a872ee9ec5a3e3a344c93cf6d0acaa310174) Reviewed-on: https://git-master.nvidia.com/r/c/device/hardware/nvidia/t23x-public-dts/+/3296123 GVS: buildbot_gerritrpt Reviewed-by: Jon Hunter --- tegra234.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tegra234.dtsi b/tegra234.dtsi index 570331b..ecb9720 100644 --- a/tegra234.dtsi +++ b/tegra234.dtsi @@ -4018,6 +4018,8 @@ #redistributor-regions = <1>; #interrupt-cells = <3>; interrupt-controller; + + #address-cells = <0>; }; smmu_iso: iommu@10000000 {