linux-hwpm

mirror of git://nv-tegra.nvidia.com/linux-hwpm.git synced 2025-12-24 10:13:00 +03:00

Author	SHA1	Message	Date
Jon Hunter	1e751f52f0	tegra: hwpm: Use conftest for get_user_pages The conftest script already has a test for checking which variant of the get_user_pages() function is present in the kernel. So use the definition generated by conftest to select which function variant is used. Bug 4276500 Change-Id: I29d216c8cead657c1daca4ce11b3dc3f74928467 Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-hwpm/+/3015357 (cherry picked from commit `f9360f364f`) Reviewed-on: https://git-master.nvidia.com/r/c/linux-hwpm/+/3017317 Reviewed-by: Vedashree Vidwans <vvidwans@nvidia.com>	2023-11-20 05:09:26 -08:00
Jon Hunter	ee08de6166	tegra: hwpm: Remove class owner The owner member of the class structure was removed in upstream Linux v6.4 because it was never used. Therefore, just remove this from the HWPM driver completely because it is not needed. Bug 4276500 Change-Id: I50f7e59e08edbea26f7ceaa701e4abfe5cc71c71 Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-hwpm/+/3015339 (cherry picked from commit `13a7312154`) Reviewed-on: https://git-master.nvidia.com/r/c/linux-hwpm/+/3017316 Reviewed-by: Vedashree Vidwans <vvidwans@nvidia.com>	2023-11-20 05:09:21 -08:00
Shardar Mohammed	c7c63cd0fe	hwpm: Remove module owner parameter Remove the module owner from the struct class based on following change in core kernel ===== Upstream commit "6e30a66433af" driver core: class: remove struct module owner out of struct class The module owner field for a struct class was never actually used, so remove it as it is not doing anything at all. Cc: "Rafael J. Wysocki" <rafael@kernel.org> Link: https://lore.kernel.org/r/20230313181843.1207845-3-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> ===== Bug 4276500 Change-Id: I0b68273e38f79ee6d903172b8f4d9d1807202abe Signed-off-by: Shardar Mohammed <smohammed@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-hwpm/+/2978633 (cherry picked from commit `f116216688`) Reviewed-on: https://git-master.nvidia.com/r/c/linux-hwpm/+/3015718 Tested-by: Jonathan Hunter <jonathanh@nvidia.com> Reviewed-by: Vedashree Vidwans <vvidwans@nvidia.com> Reviewed-by: Jonathan Hunter <jonathanh@nvidia.com> GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>	2023-11-17 00:24:27 -08:00
Shardar Mohammed	4f84731a0a	hwpm: remove unused vmas parameter from get_user_pages() Remove unused vmas parameter from get_user_pages() based on following change in core kernel. ===== Upstream commit "54d020692b34" mm/gup: remove unused vmas parameter from get_user_pages() Patch series "remove the vmas parameter from GUP APIs", v6. (pin_/get)_user_pages[_remote]() each provide an optional output parameter for an array of VMA objects associated with each page in the input range. These provide the means for VMAs to be returned, as long as mm->mmap_lock is never released during the GUP operation (i.e. the internal flag FOLL_UNLOCKABLE is not specified). In addition, these VMAs can only be accessed with the mmap_lock held and become invalidated the moment it is released. The vast majority of invocations do not use this functionality and of those that do, all but one case retrieve a single VMA to perform checks upon. It is not egregious in the single VMA cases to simply replace the operation with a vma_lookup(). In these cases we duplicate the (fast) lookup on a slow path already under the mmap_lock, abstracted to a new get_user_page_vma_remote() inline helper function which also performs error checking and reference count maintenance. The special case is io_uring, where io_pin_pages() specifically needs to assert that the VMAs underlying the range do not result in broken long-term GUP file-backed mappings. As GUP now internally asserts that FOLL_LONGTERM mappings are not file-backed in a broken fashion (i.e. requiring dirty tracking) - as implemented in "mm/gup: disallow FOLL_LONGTERM GUP-nonfast writing to file-backed mappings" - this logic is no longer required and so we can simply remove it altogether from io_uring. Eliminating the vmas parameter eliminates an entire class of danging pointer errors that might have occured should the lock have been incorrectly released. In addition, the API is simplified and now clearly expresses what it is intended for - applying the specified GUP flags and (if pinning) returning pinned pages. This change additionally opens the door to further potential improvements in GUP and the possible marrying of disparate code paths. I have run this series against gup_test with no issues. Thanks to Matthew Wilcox for suggesting this refactoring! This patch (of 6): No invocation of get_user_pages() use the vmas parameter, so remove it. The GUP API is confusing and caveated. Recent changes have done much to improve that, however there is more we can do. Exporting vmas is a prime target as the caller has to be extremely careful to preclude their use after the mmap_lock has expired or otherwise be left with dangling pointers. Removing the vmas parameter focuses the GUP functions upon their primary purpose - pinning (and outputting) pages as well as performing the actions implied by the input flags. This is part of a patch series aiming to remove the vmas parameter altogether. Signed-off-by: Andrew Morton <akpm@linux-foundation.org> ===== Bug 4276500 Change-Id: Ie2833b7aa4e8fef1362694de6e8a27bba553e3d4 Signed-off-by: Shardar Mohammed <smohammed@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-hwpm/+/2978634 (cherry picked from commit `85732c9084`) Reviewed-on: https://git-master.nvidia.com/r/c/linux-hwpm/+/3015717 Tested-by: Jonathan Hunter <jonathanh@nvidia.com> Reviewed-by: Vedashree Vidwans <vvidwans@nvidia.com> Reviewed-by: Jonathan Hunter <jonathanh@nvidia.com> GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>	2023-11-17 00:24:21 -08:00

2 changed files with 5 additions and 2 deletions

									
										2

drivers/tegra/hwpm/os/linux/driver.c
									
												View File
												
				@@ -23,7 +23,6 @@

				#include <linux/slab.h>

				#include <linux/dma-buf.h>

				#include <linux/debugfs.h>

				#include <linux/version.h>

				#include <tegra_hwpm.h>

				#include <tegra_hwpm_ip.h>

				@@ -112,7 +111,6 @@ static int tegra_hwpm_probe(struct platform_device *pdev)

					hwpm_linux->pdev = pdev;

					hwpm_linux->dev = &pdev->dev;

					hwpm_linux->np = pdev->dev.of_node;

					hwpm_linux->class.owner = THIS_MODULE;

					hwpm_linux->class.name = TEGRA_SOC_HWPM_MODULE_NAME;

					hwpm = &hwpm_linux->hwpm;

									
										5

drivers/tegra/hwpm/os/linux/mem_mgmt_utils.c
									
												View File
												
				@@ -457,8 +457,13 @@ int tegra_hwpm_map_update_allowlist(struct tegra_soc_hwpm *hwpm,

						goto fail;

					}

				#if defined(NV_GET_USER_PAGES_HAS_ARGS_FLAGS) /* Linux v6.5 */

					pinned_pages = get_user_pages(user_va & PAGE_MASK,

						hwpm->alist_map->num_pages, 0, hwpm->alist_map->pages);

				#else

					pinned_pages = get_user_pages(user_va & PAGE_MASK,

						hwpm->alist_map->num_pages, 0, hwpm->alist_map->pages, NULL);

				#endif

					if (pinned_pages != hwpm->alist_map->num_pages) {

						tegra_hwpm_err(hwpm, "Requested %llu pages / Got %ld pages",

							hwpm->alist_map->num_pages, pinned_pages);

Compare commits

4 Commits

jetson_36. ... rel-36-lws

2

drivers/tegra/hwpm/os/linux/driver.c

View File

5

drivers/tegra/hwpm/os/linux/mem_mgmt_utils.c

View File

Compare commits

4 Commits jetson_36. ... rel-36-lws

2 drivers/tegra/hwpm/os/linux/driver.c Unescape Escape Copy filename View File

5 drivers/tegra/hwpm/os/linux/mem_mgmt_utils.c Unescape Escape Copy filename View File

4 Commits

jetson_36. ... rel-36-lws

2

drivers/tegra/hwpm/os/linux/driver.c

View File

5

drivers/tegra/hwpm/os/linux/mem_mgmt_utils.c

View File