kernel-nvidia-oot: Restrict enabling MACSec in PHY

Restrict enabling MACSec support in below PHYs via MDIO

- MV-Q3244
- 88Q2221M

Jira NET-2795

Change-Id: I2cf767ad89762a5daa8ac29e753365af2e5d24fb
Signed-off-by: Sanath Kumar Gampa <sgampa@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3308513
Reviewed-by: Ashutosh Jha <ajha@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: buildbot_gerritrpt <buildbot_gerritrpt@nvidia.com>
Reviewed-by: Rakesh Goyal <rgoyal@nvidia.com>
Reviewed-by: Narayana Reddy P <narayanr@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Sanath Kumar Gampa
2025-02-24 08:59:42 +00:00
committed by Jon Hunter
parent 247613d6ce
commit 5193e86207
2 changed files with 82 additions and 2 deletions

View File

@@ -1,5 +1,18 @@
// SPDX-License-Identifier: GPL-2.0-only // SPDX-License-Identifier: GPL-2.0-only
// SPDX-FileCopyrightText: Copyright (c) 2019-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. /* SPDX-FileCopyrightText: Copyright (c) 2019-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms and conditions of the GNU General Public License,
* version 2, as published by the Free Software Foundation.
*
* This program is distributed in the hope it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include <nvidia/conftest.h> #include <nvidia/conftest.h>
#include <linux/version.h> #include <linux/version.h>
@@ -2868,6 +2881,26 @@ static int ether_mdio_write(struct mii_bus *bus, int phyaddr, int phyreg,
"%s:No clks available, skipping PHY write\n", __func__); "%s:No clks available, skipping PHY write\n", __func__);
return -ENODEV; return -ENODEV;
} }
if (pdata->phy_str != NULL) {
// For MV-Q3244 0x401e002a is pointing to 0x407C2780 value pointed by Sau Loh from Mrvl
if (strcmp(pdata->phy_str, "MVQ3244") == 0) {
if ((phyreg == MACSEC_REG_MVQ3244) && ((phydata & OSI_BIT(1)) == 0U)) {
dev_err(pdata->dev,
"restricting access to enable macsec in MVQ3244 PHY \n");
return -ENODEV;
}
// For 88Q2221M dev 0x1F and Register 0xa008 is pointed to 0x401fa008
} else if (strcmp(pdata->phy_str, "88Q2221M") == 0) {
if ((phyaddr == MACSEC_REG_88Q2221M) &&
(((phydata & OSI_BIT(5)) == 0U) || ((phydata & OSI_BIT(6)) == 0U))) {
dev_err(pdata->dev,
"restricting access to enable macsec in 88Q221M PHY \n");
return -ENODEV;
}
} else {
/** Do Nothing for other PHY types */
}
}
return osi_write_phy_reg(pdata->osi_core, (unsigned int)phyaddr, return osi_write_phy_reg(pdata->osi_core, (unsigned int)phyaddr,
(unsigned int)phyreg, phydata); (unsigned int)phyreg, phydata);
@@ -4272,6 +4305,29 @@ static int ether_handle_priv_wmdio_ioctl(struct ether_priv_data *pdata,
prtad = mdio_phy_id_prtad(mii_data->phy_id); prtad = mdio_phy_id_prtad(mii_data->phy_id);
devad = mdio_phy_id_devad(mii_data->phy_id); devad = mdio_phy_id_devad(mii_data->phy_id);
devad = ether_mdio_c45_addr(devad, mii_data->reg_num); devad = ether_mdio_c45_addr(devad, mii_data->reg_num);
if (pdata->phy_str != NULL) {
// For MV-Q3244 0x401e002a is pointing to 0x407C2780 value pointed by Sau Loh from Mrvl
if (strcmp(pdata->phy_str, "MVQ3244") == 0) {
if ((devad == MACSEC_REG_MVQ3244) &&
((mii_data->val_in & OSI_BIT(1)) == 0U)) {
dev_err(pdata->dev,
"restricting access to enable macsec in MVQ3244 PHY \n");
return -ENODEV;
}
// For 88Q2221M dev 0x1F and Register 0xa008 is pointed to 0x401fa008
} else if (strcmp(pdata->phy_str, "88Q2221M") == 0) {
if ((devad == MACSEC_REG_88Q2221M) &&
(((mii_data->val_in & OSI_BIT(5)) == 0U) ||
((mii_data->val_in & OSI_BIT(6)) == 0U))) {
dev_err(pdata->dev,
"restricting access to enable macsec in 88Q2221M PHY \n");
return -ENODEV;
}
} else {
/** Do Nothing for other PHY types */
}
}
} else { } else {
prtad = mii_data->phy_id; prtad = mii_data->phy_id;
devad = mii_data->reg_num; devad = mii_data->reg_num;
@@ -7403,6 +7459,9 @@ int ether_probe(struct platform_device *pdev)
} }
} }
/* Read PHY type from DT */
(void)of_property_read_string(pdata->dev->of_node,
"nvidia,phy_type", &pdata->phy_str);
/* Set netdev features based on hw features */ /* Set netdev features based on hw features */
ether_set_ndev_features(ndev, pdata); ether_set_ndev_features(ndev, pdata);

View File

@@ -1,5 +1,18 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
/* Copyright (c) 2019-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved */ /* SPDX-FileCopyrightText: Copyright (c) 2019-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms and conditions of the GNU General Public License,
* version 2, as published by the Free Software Foundation.
*
* This program is distributed in the hope it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef ETHER_LINUX_H #ifndef ETHER_LINUX_H
#define ETHER_LINUX_H #define ETHER_LINUX_H
@@ -250,6 +263,12 @@
*/ */
#define FIXED_PHY_INVALID_MDIO_ADDR 0xFFU #define FIXED_PHY_INVALID_MDIO_ADDR 0xFFU
/**
* @brief PHY register address to enable MACSEc feature in PHY
*/
#define MACSEC_REG_MVQ3244 0x401e002aU
#define MACSEC_REG_88Q2221M 0x401fa008U
#define ETHER_ADDRESS_32BIT 0 #define ETHER_ADDRESS_32BIT 0
#define ETHER_ADDRESS_40BIT 1 #define ETHER_ADDRESS_40BIT 1
#define ETHER_ADDRESS_48BIT 2 #define ETHER_ADDRESS_48BIT 2
@@ -662,6 +681,8 @@ struct ether_priv_data {
int phy_reset_post_delay; int phy_reset_post_delay;
/** PHY reset duration delay */ /** PHY reset duration delay */
int phy_reset_duration; int phy_reset_duration;
/** Pointer to the phy type being used */
const char *phy_str;
#ifdef ETHER_NVGRO #ifdef ETHER_NVGRO
/** Master queue */ /** Master queue */
struct sk_buff_head mq; struct sk_buff_head mq;