nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-22 17:25:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

nvethernet: Fix coverity "unused value"

Browse Source 
Bug 3952896

Change-Id: Ie30c3da4d0979f664cb3c951794e905b52e5c005
Signed-off-by: Mahesh Patil <maheshp@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2952208
Reviewed-by: Nagaraj Annaiah <nannaiah@nvidia.com>
Reviewed-by: Bhadram Varka <vbhadram@nvidia.com>
Reviewed-by: Ashutosh Jha <ajha@nvidia.com>
This commit is contained in:
Mahesh Patil
2023-08-07 23:00:18 -07:00
committed by mobile promotions
parent d6bcba5193
commit 6883238a21
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/net/ethernet/nvidia/nvethernet/ether_linux.c
View File

@@ -6086,13 +6086,12 @@ static int ether_parse_dt(struct ether_priv_data *pdata)
} }
/* Read pad calibration config reg offset, default 0 */ /* Read pad calibration config reg offset, default 0 */
ret = of_property_read_u32(np, "nvidia,pad_auto_cal_pu_offset", ret_val = of_property_read_u32(np, "nvidia,pad_auto_cal_pu_offset",
&dt_pad_auto_cal_pu_offset); &dt_pad_auto_cal_pu_offset);
if (ret < 0) { if (ret_val < 0) {
dev_info(dev, "missing nvidia,pad_auto_cal_pu_offset, " dev_info(dev, "missing nvidia,pad_auto_cal_pu_offset, "
"setting default 0\n"); "setting default 0\n");
osi_core->padctrl.pad_auto_cal_pu_offset = 0U; osi_core->padctrl.pad_auto_cal_pu_offset = 0U;
ret = 0;
} else if (dt_pad_auto_cal_pu_offset > } else if (dt_pad_auto_cal_pu_offset >
OSI_PAD_CAL_CONFIG_PD_PU_OFFSET_MAX) { OSI_PAD_CAL_CONFIG_PD_PU_OFFSET_MAX) {
dev_err(dev, "Error: Invalid dt " dev_err(dev, "Error: Invalid dt "
@@ -6104,13 +6103,12 @@ static int ether_parse_dt(struct ether_priv_data *pdata)
osi_core->padctrl.pad_auto_cal_pu_offset = osi_core->padctrl.pad_auto_cal_pu_offset =
dt_pad_auto_cal_pu_offset; dt_pad_auto_cal_pu_offset;
} }
ret = of_property_read_u32(np, "nvidia,pad_auto_cal_pd_offset", ret_val = of_property_read_u32(np, "nvidia,pad_auto_cal_pd_offset",
&dt_pad_auto_cal_pd_offset); &dt_pad_auto_cal_pd_offset);
if (ret < 0) { if (ret_val < 0) {
dev_info(dev, "missing nvidia,pad_auto_cal_pd_offset, " dev_info(dev, "missing nvidia,pad_auto_cal_pd_offset, "
"setting default 0\n"); "setting default 0\n");
osi_core->padctrl.pad_auto_cal_pd_offset = 0U; osi_core->padctrl.pad_auto_cal_pd_offset = 0U;
ret = 0;
} else if (dt_pad_auto_cal_pd_offset > } else if (dt_pad_auto_cal_pd_offset >
OSI_PAD_CAL_CONFIG_PD_PU_OFFSET_MAX) { OSI_PAD_CAL_CONFIG_PD_PU_OFFSET_MAX) {
dev_err(dev, "Error: Invalid dt " dev_err(dev, "Error: Invalid dt "