nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-24 10:11:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

camera: csi: fix coverity defect

Browse Source 
Out-of-bounds read
CID: 10132982

Bug 3952896

Change-Id: Iefcdeaf46e46a1e27feb4ab13e0f76d8ee4b5b10
Signed-off-by: Ankur Pawar <ankurp@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2885123
Reviewed-by: svcacv <svcacv@nvidia.com>
Reviewed-by: Frank Chen <frankc@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-cert <svc-mobile-cert@nvidia.com>
Reviewed-by: Praveen AC <pac@nvidia.com>
Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>
This commit is contained in:
Ankur Pawar
2023-04-10 07:43:28 +00:00
committed by mobile promotions
parent 94064b64d3
commit 9a9e8f8cdf
1 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/media/platform/tegra/camera/nvcsi/csi5_fops.c
View File

@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/*
* Tegra CSI5 device common APIs
* Copyright (c) 2016-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
*
* Copyright (c) 2016-2023, NVIDIA CORPORATION. All rights reserved.
* Tegra CSI5 device common APIs
*/
#include <linux/log2.h>
#include <media/csi.h>
@@ -360,8 +360,10 @@ static void csi5_stream_tpg_stop(struct tegra_csi_channel *chan, u32 stream_id,
* gain setting by 8, before v4l2 ioctl call. It is tranformed before
* IVC message
*/
static uint32_t get_tpg_gain_ratio_setting(int gain_ratio_tpg)
static int get_tpg_gain_ratio_setting(int gain_ratio_tpg,
uint32_t *apply_gain_ratio)
{
uint8_t idx;
const uint32_t tpg_gain_ratio_settings[] = {
CAPTURE_CSI_STREAM_TPG_GAIN_RATIO_ONE_EIGHTH,
CAPTURE_CSI_STREAM_TPG_GAIN_RATIO_ONE_FOURTH,
@@ -371,7 +373,12 @@ static uint32_t get_tpg_gain_ratio_setting(int gain_ratio_tpg)
CAPTURE_CSI_STREAM_TPG_GAIN_RATIO_FOUR_TO_ONE,
CAPTURE_CSI_STREAM_TPG_GAIN_RATIO_EIGHT_TO_ONE};
return tpg_gain_ratio_settings[order_base_2(gain_ratio_tpg)];
idx = order_base_2(gain_ratio_tpg);
if (idx >= ARRAY_SIZE(tpg_gain_ratio_settings))
return -EINVAL;
*apply_gain_ratio = tpg_gain_ratio_settings[idx];
return 0;
}
int csi5_tpg_set_gain(struct tegra_csi_channel *chan, int gain_ratio_tpg)
@@ -401,8 +408,13 @@ int csi5_tpg_set_gain(struct tegra_csi_channel *chan, int gain_ratio_tpg)
msg.csi_stream_tpg_apply_gain_req.stream_id = port->stream_id;
msg.csi_stream_tpg_apply_gain_req.virtual_channel_id =
port->virtual_channel_id;
msg.csi_stream_tpg_apply_gain_req.gain_ratio =
get_tpg_gain_ratio_setting(gain_ratio_tpg);
err = get_tpg_gain_ratio_setting(gain_ratio_tpg,
&msg.csi_stream_tpg_apply_gain_req.gain_ratio);
if (err < 0) {
dev_err(csi->dev, "%s: Error in setting TPG gain ratio\n",
__func__);
return err;
}
err = csi5_send_control_message(tegra_chan->tegra_vi_channel[0], &msg,
&msg.csi_stream_tpg_apply_gain_resp.result);