nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-22 17:25:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

linux: kmd: static analysis TOP25 04/02 Part 9

Browse Source 
fix CERT INT08-C under the following path:
- drivers/platform/tegra/rtcpu/camera-diagnostics.c

Jira CAMERASW-32960

Change-Id: I592cab86961df8e3a23d95acadced0717f424616
Signed-off-by: Zhiyuan Wang <zhiwang@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3334867
Reviewed-by: Semi Malinen <smalinen@nvidia.com>
Reviewed-by: svcacv <svcacv@nvidia.com>
Reviewed-by: Vishal Agrawal (SW) <visagrawal@nvidia.com>
Reviewed-by: Frank Chen <frankc@nvidia.com>
GVS: buildbot_gerritrpt <buildbot_gerritrpt@nvidia.com>
Reviewed-by: Patrick Young <payoung@nvidia.com>
This commit is contained in:
Zhiyuan Wang
2025-04-07 09:27:01 +00:00
committed by Jon Hunter
parent 02a104cbb2
commit c9f69ea5d8
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/platform/tegra/rtcpu/camera-diagnostics.c
View File

@@ -888,14 +888,17 @@ static ssize_t status_show(struct device *dev, struct device_attribute *attr, ch
for (i = 0; i < ch->num_isp_instances; i++) { for (i = 0; i < ch->num_isp_instances; i++) {
/* Skip second instance if not enabled */ /* Skip second instance if not enabled */
if (i > 0 && !ISP_SECOND_INSTANCE_ENABLED) { if (i > 0 && !ISP_SECOND_INSTANCE_ENABLED) {
pos += sprintf(buf + pos, "\nISP%d: DISABLED\n", i); int len = sprintf(buf + pos, "\nISP%d: DISABLED\n", i);
(void)__builtin_add_overflow(pos, len, &pos);
continue; continue;
} }
start_time = jiffies; start_time = jiffies;
err = camera_diag_isp_sdl_status(ch, &status, i); err = camera_diag_isp_sdl_status(ch, &status, i);
if (time_after(jiffies, start_time + msecs_to_jiffies(1000)) || err != 0) { unsigned long end_time = 0U;
(void)__builtin_add_overflow(start_time, msecs_to_jiffies(1000), &end_time);
if (time_after(jiffies, end_time) || err != 0) {
pos += sprintf(buf + pos, "\nISP%d: Error getting diagnostic status: %d\n", i, err); pos += sprintf(buf + pos, "\nISP%d: Error getting diagnostic status: %d\n", i, err);
continue; continue;
} }