nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 10:34:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: fix user input string preparation in gk20a_power_write

Browse Source 
String parameter to kstrtouint has to be null terminated.
If the input string to gk20a_power_write doesn't have the
terminating null character then gk20a_power_write passed
string without appending null character to kstrtouint.

Fix this by preparing string to occupy null character in
the end after user supplied string characters.

Bug 3388725

Change-Id: I521f879326908e296dd9a32b5781db490d40bdd2
Signed-off-by: Sagar Kamble <skamble@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2603985
Reviewed-by: Debarshi Dutta <ddutta@nvidia.com>
Reviewed-by: Konsta Holtta <kholtta@nvidia.com>
Reviewed-by: Martin Radev <mradev@nvidia.com>
Reviewed-by: Vijayakumar Subbu <vsubbu@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
This commit is contained in:
Sagar Kamble
2021-10-01 20:07:16 +05:30
committed by mobile promotions
parent f80670915e
commit 18239c3a25
1 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/gpu/nvgpu/os/linux/power_ops.c
View File

@@ -95,38 +95,35 @@ int gk20a_power_write(struct file *filp, const char __user *buf,
size_t size, loff_t *off)
{
struct gk20a *g = filp->private_data;
unsigned char userinput[3] = {0};
u32 power_status = 0U;
int err = 0;
unsigned char *userinput = NULL;
if (!g) {
return -ENODEV;
}
userinput = (unsigned char *)kzalloc(size, GFP_KERNEL);
if (!userinput) {
return -ENOMEM;
/* Valid inputs are "0", "1", "0\n", "1\n". */
if (size >= sizeof(userinput)) {
return -EINVAL;
}
if (copy_from_user(userinput, buf, size)) {
kfree(userinput);
return -EFAULT;
}
if (kstrtouint(userinput, 10, &power_status)) {
kfree(userinput);
return -EINVAL;
}
if (power_status == NVGPU_DRIVER_POWER_ON_NEEDED) {
if (nvgpu_poweron_started(g)) {
goto free_input;
goto out;
}
err = gk20a_busy(g);
if (err) {
nvgpu_err(g, "power_node_write failed at busy");
kfree(userinput);
return err;
}
@@ -135,18 +132,15 @@ int gk20a_power_write(struct file *filp, const char __user *buf,
err = gk20a_driver_force_power_off(g);
if (err) {
nvgpu_err(g, "power_node_write failed at busy");
kfree(userinput);
return err;
}
} else {
nvgpu_err(g, "1/0 are the valid values to power-on the GPU");
kfree(userinput);
return -EINVAL;
}
free_input:
out:
*off += size;
kfree(userinput);
return size;
}