nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 02:22:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: netlist: fix CERT-C violations

Browse Source 
CERT-C Rule INT30-C Requires that unsigned integer operations do not
wrap. Fix these violations by using the safe ops.

JIRA NVGPU-3868

Change-Id: Ic1a4c19e565a061302b681b191318c6aede8e676
Signed-off-by: Philip Elcan <pelcan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2168574
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-misra <svc-mobile-misra@nvidia.com>
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vinod Gopalakrishnakurup <vinodg@nvidia.com>
Reviewed-by: Nitin Kumbhar <nkumbhar@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Philip Elcan
2019-08-01 17:27:21 -04:00
committed by mobile promotions
parent fece8bb1b7
commit 345ffb47e4
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/gpu/nvgpu/common/netlist/netlist.c
View File

@@ -30,6 +30,7 @@
#include <nvgpu/gk20a.h>
#include <nvgpu/netlist.h>
#include <nvgpu/string.h>
#include <nvgpu/safe_ops.h>
#include "netlist_priv.h"
#include "netlist_defs.h"
@@ -49,35 +50,41 @@
struct netlist_av *nvgpu_netlist_alloc_av_list(struct gk20a *g,
struct netlist_av_list *avl)
{
avl->l = nvgpu_kzalloc(g, avl->count * sizeof(*avl->l));
avl->l = nvgpu_kzalloc(g, nvgpu_safe_mult_u64(avl->count,
sizeof(*avl->l)));
return avl->l;
}
struct netlist_av64 *nvgpu_netlist_alloc_av64_list(struct gk20a *g,
struct netlist_av64_list *avl)
{
avl->l = nvgpu_kzalloc(g, avl->count * sizeof(*avl->l));
avl->l = nvgpu_kzalloc(g, nvgpu_safe_mult_u64(avl->count,
sizeof(*avl->l)));
return avl->l;
}
struct netlist_aiv *nvgpu_netlist_alloc_aiv_list(struct gk20a *g,
struct netlist_aiv_list *aivl)
{
aivl->l = nvgpu_kzalloc(g, aivl->count * sizeof(*aivl->l));
aivl->l = nvgpu_kzalloc(g, nvgpu_safe_mult_u64(aivl->count,
sizeof(*aivl->l)));
return aivl->l;
}
u32 *nvgpu_netlist_alloc_u32_list(struct gk20a *g,
struct netlist_u32_list *u32l)
{
u32l->l = nvgpu_kzalloc(g, u32l->count * sizeof(*u32l->l));
u32l->l = nvgpu_kzalloc(g, nvgpu_safe_mult_u64(u32l->count,
sizeof(*u32l->l)));
return u32l->l;
}
static int nvgpu_netlist_alloc_load_u32_list(struct gk20a *g, u8 *src, u32 len,
struct netlist_u32_list *u32_list)
{
u32_list->count = (len + U32(sizeof(u32)) - 1U) / U32(sizeof(u32));
u32_list->count = nvgpu_safe_add_u32(len,
nvgpu_safe_cast_u64_to_u32(sizeof(u32) - 1UL))
/ U32(sizeof(u32));
if (nvgpu_netlist_alloc_u32_list(g, u32_list) == NULL) {
return -ENOMEM;
}