gpu: nvgpu: fix DVR issues in ltc unit

1. Move ecc_init from public to private, since it is
   used only in init_ltc_support. Also, added description
   about initializing ltc-lts ecc counters in
   init_ltc_support function description.
2. Few documentation update to fix incorrect variable names
   and spellings.

JIRA NVGPU-6599

Change-Id: I2be5952d6188cbe9270f60d334fe2f696bc14ed6
Signed-off-by: Seshendra Gadagottu <sgadagottu@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2543502
(cherry picked from commit 03357b9dea7478924fd7e59f4f88c809a5b9504c)
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2551108
Reviewed-by: svcacv <svcacv@nvidia.com>
Reviewed-by: svc_kernel_abi <svc_kernel_abi@nvidia.com>
Reviewed-by: Sagar Kamble <skamble@nvidia.com>
Reviewed-by: Seema Khowala <seemaj@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
This commit is contained in:
Seshendra Gadagottu
2021-06-15 12:20:50 -07:00
committed by mobile promotions
parent c98ef9d850
commit 42dfcfb317
2 changed files with 18 additions and 17 deletions

View File

@@ -67,25 +67,14 @@ struct gops_ltc_intr {
* @see gpu_ops
*/
struct gops_ltc {
/**
* @brief Initialize LTC unit ECC support.
*
* @param g [in] Pointer to GPU driver struct.
*
* This function allocates memory to track the ecc error counts
* for LTC unit.
*
* @return 0 in case of success, < 0 in case of failure.
*/
int (*ecc_init)(struct gk20a *g);
/**
* @brief Initialize LTC support.
*
* @param g [in] Pointer to GPU driver struct.
*
* This function reads ltc unit info from GPU h/w and stores
* it in #nvgpu_ltc structure.
* it in #nvgpu_ltc structure. This function also initializes
* LTC unit ecc counters.
*
* @return 0 in case of success, < 0 in case of failure.
* @retval -ENOMEM if memory allocation fails for #nvgpu_ltc.
@@ -134,6 +123,18 @@ struct gops_ltc {
struct gops_ltc_intr intr;
/** @cond DOXYGEN_SHOULD_SKIP_THIS */
/**
* @brief Initialize LTC unit ECC support.
*
* @param g [in] Pointer to GPU driver struct.
*
* This function allocates memory to track the ecc error counts
* for LTC unit.
*
* @return 0 in case of success, < 0 in case of failure.
*/
int (*ecc_init)(struct gk20a *g);
void (*init_fs_state)(struct gk20a *g);
void (*set_enabled)(struct gk20a *g, bool enabled);
#ifdef CONFIG_NVGPU_GRAPHICS

View File

@@ -57,7 +57,7 @@ struct nvgpu_ltc {
* @brief Allocate and initialize a error counters for all ltc-lts instances.
*
* @param g [in] The GPU driver struct.
* @param stat [out] Pointer to array of tpc error counters.
* @param stat [out] Pointer to array of ltc-lts error counters.
* @param name [in] Unique name for error counter.
*
* Calculates the total number of ltc-lts instances, allocates memory for each
@@ -122,11 +122,11 @@ void nvgpu_ltc_remove_support(struct gk20a *g);
* @param g [in] Pointer to GPU driver struct.
*
* This function will enable/disable caching feature of L2 based on
* #mm.ltc_enable_target. With #mm.ltc_enable_target set to true,
* gpu l2 caching feature will be enabled. Gpu L2 cahching is enabled with h/w
* #mm.ltc_enabled_target. With #mm.ltc_enabled_target set to true,
* gpu l2 caching feature will be enabled. Gpu L2 caching is enabled with h/w
* power-on and can only be changed after h/w reset, before the first
* transaction received by L2.
* With #mm.ltc_enable_target set to false, Gpu L2 caching will be disabled.
* With #mm.ltc_enabled_target set to false, Gpu L2 caching will be disabled.
* With Gpu L2 cache disabled, all transactions will miss in L2 and data will
* be always write-through to main memory.
*