nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 10:34:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: Fix LibC MISRA 17.7 in os/posix

Browse Source 
MISRA Rule-17.7 requires the return value of all functions to be used.
Fix is either to use the return value or change the function to return
void. This patch contains fix for all 17.7 violations instandard C functions
in OS/Posix interface.

JIRA NVGPU-1036

Change-Id: I2da417edc992f16de24cdff536c0538f1fde8b61
Signed-off-by: Nicolas Benech <nbenech@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1929901
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Nicolas Benech
2018-10-18 10:51:12 -04:00
committed by mobile promotions
parent b9e7ea65e1
commit 4e41a0b199
6 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/nvgpu/os/posix/log.c
View File

@@ -68,7 +68,7 @@ void __nvgpu_log_msg(struct gk20a *g, const char *func_name, int line,
va_list args;
va_start(args, fmt);
vsnprintf(log, LOG_BUFFER_LENGTH, fmt, args);
(void) vsnprintf(log, LOG_BUFFER_LENGTH, fmt, args);
va_end(args);
__nvgpu_really_print_log(nvgpu_log_name(g),
@@ -87,7 +87,7 @@ void __nvgpu_log_dbg(struct gk20a *g, u64 log_mask,
return;
va_start(args, fmt);
vsnprintf(log, LOG_BUFFER_LENGTH, fmt, args);
(void) vsnprintf(log, LOG_BUFFER_LENGTH, fmt, args);
va_end(args);
__nvgpu_really_print_log(nvgpu_log_name(g),

2
drivers/gpu/nvgpu/os/posix/posix-dma.c
View File

@@ -97,7 +97,7 @@ void nvgpu_dma_free_sys(struct gk20a *g, struct nvgpu_mem *mem)
if (!(mem->mem_flags & NVGPU_MEM_FLAG_SHADOW_COPY))
free(mem->cpu_va);
memset(mem, 0, sizeof(*mem));
(void) memset(mem, 0, sizeof(*mem));
}
void nvgpu_dma_free_vid(struct gk20a *g, struct nvgpu_mem *mem)

2
drivers/gpu/nvgpu/os/posix/posix-nvgpu_mem.c
View File

@@ -151,7 +151,7 @@ int nvgpu_mem_create_from_mem(struct gk20a *g,
if ((start + size) > src->size)
return -EINVAL;
memset(dest, 0, sizeof(*dest));
(void) memset(dest, 0, sizeof(*dest));
dest->cpu_va = ((char *)src->cpu_va) + start;
dest->mem_flags = src->mem_flags | NVGPU_MEM_FLAG_SHADOW_COPY;

2
drivers/gpu/nvgpu/os/posix/rwsem.c
View File

@@ -28,7 +28,7 @@
void nvgpu_rwsem_init(struct nvgpu_rwsem *rwsem)
{
memset(rwsem, 0, sizeof(*rwsem));
(void) memset(rwsem, 0, sizeof(*rwsem));
nvgpu_spinlock_init(&rwsem->lock);
}

5
drivers/gpu/nvgpu/os/posix/thread.c
View File

@@ -54,13 +54,14 @@ int nvgpu_thread_create(struct nvgpu_thread *thread,
BUG_ON(thread->running);
memset(thread, 0, sizeof(*thread));
(void) memset(thread, 0, sizeof(*thread));
/*
* By subtracting 1 the above memset ensures that we have a zero
* terminated string.
*/
strncpy(thread->tname, name, NVGPU_THREAD_POSIX_MAX_NAMELEN - 1);
(void) strncpy(thread->tname, name,
NVGPU_THREAD_POSIX_MAX_NAMELEN - 1);
thread->nvgpu.data = data;
thread->nvgpu.fn = threadfn;

6
drivers/gpu/nvgpu/os/posix/timers.c
View File

@@ -45,7 +45,7 @@ int nvgpu_timeout_init(struct gk20a *g, struct nvgpu_timeout *timeout,
if (flags & ~NVGPU_TIMER_FLAG_MASK)
return -EINVAL;
memset(timeout, 0, sizeof(*timeout));
(void) memset(timeout, 0, sizeof(*timeout));
timeout->g = g;
timeout->flags = flags;
@@ -68,7 +68,7 @@ static int __nvgpu_timeout_expired_msg_cpu(struct nvgpu_timeout *timeout,
if (!(timeout->flags & NVGPU_TIMER_SILENT_TIMEOUT)) {
char buf[128];
vsnprintf(buf, sizeof(buf), fmt, args);
(void) vsnprintf(buf, sizeof(buf), fmt, args);
nvgpu_err(g, "Timeout detected @ %p %s", caller, buf);
}
@@ -89,7 +89,7 @@ static int __nvgpu_timeout_expired_msg_retry(struct nvgpu_timeout *timeout,
if (!(timeout->flags & NVGPU_TIMER_SILENT_TIMEOUT)) {
char buf[128];
vsnprintf(buf, sizeof(buf), fmt, args);
(void) vsnprintf(buf, sizeof(buf), fmt, args);
nvgpu_err(g, "No more retries @ %p %s", caller, buf);
}