nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 02:22:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: Skip checking for null in error path

Browse Source 
vfe_var_construct_single_sensed_fuse() first constructs boardobj and
then does further validity checks. If the checks fail, it calls exit
label. The exit label checks if boardobj is NULL and calls destructor
if it is.

As there is no path to get to exit label with boardobj NULL, skip
the check.

Coverity ID 2011368

Change-Id: Ifea931113a7b862830b4b3f9852d9c16310a1549
Signed-off-by: Terje Bergstrom <tbergstrom@nvidia.com>
Reviewed-on: http://git-master/r/1291685
Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com>
GVS: Gerrit_Virtual_Submit
This commit is contained in:
Terje Bergstrom
2017-01-19 15:45:02 -08:00
committed by mobile promotions
parent 52ecd593c2
commit a2d7dfdfb4
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/gpu/nvgpu/perf/vfe_var.c
View File

@@ -678,10 +678,9 @@ static u32 vfe_var_construct_single_sensed_fuse(struct gk20a *g,
goto exit;
}
exit:
if (status) {
if (*ppboardobj != NULL)
(*ppboardobj)->destruct(*ppboardobj);
}
if (status)
(*ppboardobj)->destruct(*ppboardobj);
return status;
}