gpu: nvgpu: MISRA 14.4 err/ret/status as boolean

MISRA rule 14.4 doesn't allow the usage of integer types as booleans
in the controlling expression of an if statement or an iteration
statement.

Fix violations where the integer variables err, ret, status are used
as booleans in the controlling expression of if and loop statements.

JIRA NVGPU-1019

Change-Id: I9e18ffc961d485225732c34d3ca561e84d182d07
Signed-off-by: Amurthyreddy <amurthyreddy@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1921370
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>

drivers/gpu/nvgpu/volt/volt_dev.c

@@ -47,7 +47,7 @@ static int volt_device_pmu_data_init_super(struct gk20a *g,
 	struct nv_pmu_volt_volt_device_boardobj_set *pset;
 
 	status = boardobj_pmudatainit_super(g, pboard_obj, ppmudata);
-	if (status) {
+	if (status != 0) {
 		return status;
 	}
 
@@ -70,7 +70,7 @@ static int volt_device_pmu_data_init_pwm(struct gk20a *g,
 	struct nv_pmu_volt_volt_device_pwm_boardobj_set *pset;
 
 	status = volt_device_pmu_data_init_super(g, pboard_obj, ppmudata);
-	if (status) {
+	if (status != 0) {
 		return  status;
 	}
 
@@ -93,7 +93,7 @@ static int construct_volt_device(struct gk20a *g,
 	int status = 0;
 
 	status = boardobj_construct_super(g, ppboardobj, size, pargs);
-	if (status) {
+	if (status != 0) {
 		return status;
 	}
 
@@ -125,7 +125,7 @@ static int construct_pwm_volt_device(struct gk20a *g,
 	int status = 0;
 
 	status = construct_volt_device(g, ppboardobj, size, pargs);
-	if (status) {
+	if (status != 0) {
 		return status;
 	}
 
@@ -191,7 +191,7 @@ static struct voltage_device *volt_volt_device_construct(struct gk20a *g,
 	if (BOARDOBJ_GET_TYPE(pargs) == CTRL_VOLT_DEVICE_TYPE_PWM) {
 		int status = construct_pwm_volt_device(g, &pboard_obj,
 				sizeof(struct voltage_device_pwm), pargs);
-		if (status) {
+		if (status != 0) {
 			nvgpu_err(g,
 				" Could not allocate memory for VOLTAGE_DEVICE type (%x).",
 				BOARDOBJ_GET_TYPE(pargs));
@@ -329,7 +329,7 @@ static int volt_get_voltage_device_table_1x_psv(struct gk20a *g,
 	status = boardobjgrp_objinsert(
 				&p_Volt_Device_Meta_Data->volt_devices.super,
 				(struct boardobj *)pvolt_dev, entry_Idx);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"could not add VOLTAGE_DEVICE for entry %d into boardobjgrp ",
 			entry_Idx);
@@ -394,10 +394,10 @@ done:
 	return status;
 }
 
-static u32 volt_get_volt_devices_table(struct gk20a *g,
+static int volt_get_volt_devices_table(struct gk20a *g,
 		struct voltage_device_metadata *pvolt_device_metadata)
 {
-	u32 status = 0;
+	int status = 0;
 	u8 *volt_device_table_ptr = NULL;
 	struct vbios_voltage_device_table_1x_header header = { 0 };
 	struct vbios_voltage_device_table_1x_entry entry  = { 0 };
@@ -482,10 +482,10 @@ static int volt_device_volt_cmp(const void *a, const void *b)
 	return (int)a_entry->voltage_uv - (int)b_entry->voltage_uv;
 }
 
-static u32 volt_device_state_init(struct gk20a *g,
+static int volt_device_state_init(struct gk20a *g,
 			struct voltage_device *pvolt_dev)
 {
-	u32 status = 0;
+	int status = 0;
 	struct voltage_rail *pRail = NULL;
 	u8 rail_idx = 0;
 
@@ -523,7 +523,7 @@ static u32 volt_device_state_init(struct gk20a *g,
 
 		status = volt_rail_volt_dev_register(g, pRail,
 			BOARDOBJ_GET_IDX(pvolt_dev), pvolt_dev->operation_type);
-		if (status) {
+		if (status != 0) {
 			nvgpu_err(g,
 				"Failed to register the device with rail obj");
 			goto done;
@@ -531,7 +531,7 @@ static u32 volt_device_state_init(struct gk20a *g,
 	}
 
 done:
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g, "Error in building rail sw state device sw");
 	}
 
@@ -557,9 +557,9 @@ int volt_dev_pmu_setup(struct gk20a *g)
 	return status;
 }
 
-u32 volt_dev_sw_setup(struct gk20a *g)
+int volt_dev_sw_setup(struct gk20a *g)
 {
-	u32 status = 0;
+	int status = 0;
 	struct boardobjgrp *pboardobjgrp = NULL;
 	struct voltage_device *pvolt_device;
 	u8 i;
@@ -568,7 +568,7 @@ u32 volt_dev_sw_setup(struct gk20a *g)
 
 	status = boardobjgrpconstruct_e32(g,
 			&g->perf_pmu.volt.volt_dev_metadata.volt_devices);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error creating boardobjgrp for volt rail, status - 0x%x",
 			status);
@@ -583,7 +583,7 @@ u32 volt_dev_sw_setup(struct gk20a *g)
 	/* Obtain Voltage Rail Table from VBIOS */
 	status = volt_get_volt_devices_table(g, &g->perf_pmu.volt.
 			volt_dev_metadata);
-	if (status) {
+	if (status != 0) {
 		goto done;
 	}
 
@@ -592,7 +592,7 @@ u32 volt_dev_sw_setup(struct gk20a *g)
 
 	status = BOARDOBJGRP_PMU_CMD_GRP_SET_CONSTRUCT(g, pboardobjgrp,
 			volt, VOLT, volt_device, VOLT_DEVICE);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error constructing PMU_BOARDOBJ_CMD_GRP_SET interface - 0x%x",
 			status);
@@ -602,7 +602,7 @@ u32 volt_dev_sw_setup(struct gk20a *g)
 	status = BOARDOBJGRP_PMU_CMD_GRP_GET_STATUS_CONSTRUCT(g,
 			&g->perf_pmu.volt.volt_dev_metadata.volt_devices.super,
 			volt, VOLT, volt_device, VOLT_DEVICE);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error constructing PMU_BOARDOBJ_CMD_GRP_SET interface - 0x%x",
 			status);
@@ -614,7 +614,7 @@ u32 volt_dev_sw_setup(struct gk20a *g)
 			       super),
 			     struct voltage_device *, pvolt_device, i) {
 		status = volt_device_state_init(g, pvolt_device);
-		if (status) {
+		if (status != 0) {
 			nvgpu_err(g,
 				"failure while executing devices's state init interface");
 			nvgpu_err(g,

drivers/gpu/nvgpu/volt/volt_dev.h

@@ -71,7 +71,7 @@ struct voltage_device_pwm_entry {
 };
 /* PWM end */
 
-u32 volt_dev_sw_setup(struct gk20a *g);
+int volt_dev_sw_setup(struct gk20a *g);
 int volt_dev_pmu_setup(struct gk20a *g);
 
 #endif /* NVGPU_VOLT_DEV_H */

drivers/gpu/nvgpu/volt/volt_pmu.c

@@ -60,13 +60,13 @@ static void volt_rpc_pmucmdhandler(struct gk20a *g, struct pmu_msg *msg,
 }
 
 
-static u32 volt_pmu_rpc_execute(struct gk20a *g,
+static int volt_pmu_rpc_execute(struct gk20a *g,
 	struct nv_pmu_volt_rpc *prpc_call)
 {
 	struct pmu_cmd cmd;
 	struct pmu_msg msg;
 	struct pmu_payload payload;
-	u32 status = 0;
+	int status = 0;
 	u32 seqdesc;
 	struct volt_rpc_pmucmdhandler_params handler;
 
@@ -98,7 +98,7 @@ static u32 volt_pmu_rpc_execute(struct gk20a *g,
 			PMU_COMMAND_QUEUE_LPQ,
 			volt_rpc_pmucmdhandler, (void *)&handler,
 			&seqdesc, ~0);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g, "unable to post volt RPC cmd %x",
 			cmd.cmd.volt.cmd_type);
 		goto volt_pmu_rpc_execute;
@@ -117,15 +117,15 @@ volt_pmu_rpc_execute:
 	return status;
 }
 
-u32 nvgpu_volt_send_load_cmd_to_pmu_gp10x(struct gk20a *g)
+int nvgpu_volt_send_load_cmd_to_pmu_gp10x(struct gk20a *g)
 {
 	struct nv_pmu_volt_rpc rpc_call = { 0 };
-	u32 status = 0;
+	int status = 0;
 
 	rpc_call.function = NV_PMU_VOLT_RPC_ID_LOAD;
 
 	status =  volt_pmu_rpc_execute(g, &rpc_call);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"Error while executing LOAD RPC: status = 0x%08x.",
 			status);
@@ -134,15 +134,15 @@ u32 nvgpu_volt_send_load_cmd_to_pmu_gp10x(struct gk20a *g)
 	return status;
 }
 
-u32 nvgpu_volt_send_load_cmd_to_pmu_gv10x(struct gk20a *g)
+int nvgpu_volt_send_load_cmd_to_pmu_gv10x(struct gk20a *g)
 {
 	struct nvgpu_pmu *pmu = &g->pmu;
 	struct nv_pmu_rpc_struct_volt_load rpc;
-	u32 status = 0;
+	int status = 0;
 
 	memset(&rpc, 0, sizeof(struct nv_pmu_rpc_struct_volt_load));
 	PMU_RPC_EXECUTE(status, pmu, VOLT, LOAD, &rpc, 0);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g, "Failed to execute RPC status=0x%x",
 			status);
 	}
@@ -150,11 +150,11 @@ u32 nvgpu_volt_send_load_cmd_to_pmu_gv10x(struct gk20a *g)
 	return status;
 }
 
-u32 nvgpu_volt_rail_get_voltage_gp10x(struct gk20a *g,
+int nvgpu_volt_rail_get_voltage_gp10x(struct gk20a *g,
 	u8 volt_domain, u32 *pvoltage_uv)
 {
 	struct nv_pmu_volt_rpc rpc_call = { 0 };
-	u32 status  = 0;
+	int status  = 0;
 	u8 rail_idx;
 
 	rail_idx = volt_rail_volt_domain_convert_to_idx(g, volt_domain);
@@ -172,7 +172,7 @@ u32 nvgpu_volt_rail_get_voltage_gp10x(struct gk20a *g,
 
 	/* Execute the voltage get request via PMU RPC. */
 	status = volt_pmu_rpc_execute(g, &rpc_call);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"Error while executing volt_rail_get_voltage rpc");
 		return status;
@@ -184,12 +184,12 @@ u32 nvgpu_volt_rail_get_voltage_gp10x(struct gk20a *g,
 	return status;
 }
 
-u32 nvgpu_volt_rail_get_voltage_gv10x(struct gk20a *g,
+int nvgpu_volt_rail_get_voltage_gv10x(struct gk20a *g,
 	u8 volt_domain, u32 *pvoltage_uv)
 {
 	struct nvgpu_pmu *pmu = &g->pmu;
 	struct nv_pmu_rpc_struct_volt_volt_rail_get_voltage rpc;
-	u32 status  = 0;
+	int status  = 0;
 	u8 rail_idx;
 
 	rail_idx = volt_rail_volt_domain_convert_to_idx(g, volt_domain);
@@ -206,7 +206,7 @@ u32 nvgpu_volt_rail_get_voltage_gv10x(struct gk20a *g,
 	rpc.rail_idx = rail_idx;
 
 	PMU_RPC_EXECUTE_CPB(status, pmu, VOLT, VOLT_RAIL_GET_VOLTAGE, &rpc, 0);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g, "Failed to execute RPC status=0x%x",
 			status);
 	}
@@ -216,12 +216,12 @@ u32 nvgpu_volt_rail_get_voltage_gv10x(struct gk20a *g,
 	return status;
 }
 
-static u32 volt_policy_set_voltage(struct gk20a *g, u8 client_id,
+static int volt_policy_set_voltage(struct gk20a *g, u8 client_id,
 		struct ctrl_perf_volt_rail_list *prail_list)
 {
 	struct nv_pmu_volt_rpc rpc_call = { 0 };
 	struct obj_volt *pvolt = &g->perf_pmu.volt;
-	u32 status = 0;
+	int status = 0;
 	u8 policy_idx = CTRL_VOLT_POLICY_INDEX_INVALID;
 	u8 i = 0;
 
@@ -260,7 +260,7 @@ static u32 volt_policy_set_voltage(struct gk20a *g, u8 client_id,
 
 	/* Execute the voltage change request via PMU RPC. */
 	status = volt_pmu_rpc_execute(g, &rpc_call);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"Error while executing VOLT_POLICY_SET_VOLTAGE RPC");
 	}
@@ -269,7 +269,7 @@ exit:
 	return status;
 }
 
-static u32 volt_set_voltage_gv10x_rpc(struct gk20a *g, u8 client_id,
+static int volt_set_voltage_gv10x_rpc(struct gk20a *g, u8 client_id,
 		struct ctrl_volt_volt_rail_list_v1 *prail_list)
 {
 	struct nvgpu_pmu *pmu = &g->pmu;
@@ -281,7 +281,7 @@ static u32 volt_set_voltage_gv10x_rpc(struct gk20a *g, u8 client_id,
 	rpc.rail_list = *prail_list;
 
 	PMU_RPC_EXECUTE_CPB(status, pmu, VOLT, VOLT_SET_VOLTAGE, &rpc, 0);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g, "Failed to execute RPC status=0x%x",
 			status);
 	}
@@ -289,7 +289,7 @@ static u32 volt_set_voltage_gv10x_rpc(struct gk20a *g, u8 client_id,
 	return status;
 }
 
-u32 nvgpu_volt_set_voltage_gv10x(struct gk20a *g, u32 logic_voltage_uv,
+int nvgpu_volt_set_voltage_gv10x(struct gk20a *g, u32 logic_voltage_uv,
 		u32 sram_voltage_uv)
 {
 	int status = 0;
@@ -308,7 +308,7 @@ u32 nvgpu_volt_set_voltage_gv10x(struct gk20a *g, u32 logic_voltage_uv,
 	return status;
 }
 
-u32 nvgpu_volt_set_voltage_gp10x(struct gk20a *g, u32 logic_voltage_uv,
+int nvgpu_volt_set_voltage_gp10x(struct gk20a *g, u32 logic_voltage_uv,
 		u32 sram_voltage_uv)
 {
 	int status = 0;
@@ -328,13 +328,13 @@ u32 nvgpu_volt_set_voltage_gp10x(struct gk20a *g, u32 logic_voltage_uv,
 	return status;
 }
 
-u32 volt_set_voltage(struct gk20a *g, u32 logic_voltage_uv, u32 sram_voltage_uv)
+int volt_set_voltage(struct gk20a *g, u32 logic_voltage_uv, u32 sram_voltage_uv)
 {
 	return g->ops.pmu_ver.volt.volt_set_voltage(g,
 		logic_voltage_uv, sram_voltage_uv);
 }
 
-u32 volt_get_voltage(struct gk20a *g, u32 volt_domain, u32 *voltage_uv)
+int volt_get_voltage(struct gk20a *g, u32 volt_domain, u32 *voltage_uv)
 {
 	return g->ops.pmu_ver.volt.volt_get_voltage(g,
 		volt_domain, voltage_uv);
@@ -344,7 +344,7 @@ static int volt_policy_set_noiseaware_vmin(struct gk20a *g,
 		struct ctrl_volt_volt_rail_list *prail_list)
 {
 	struct nv_pmu_volt_rpc rpc_call = { 0 };
-	u32 status = 0;
+	int status = 0;
 
 	/* Set RPC parameters. */
 	rpc_call.function = NV_PMU_VOLT_RPC_ID_VOLT_RAIL_SET_NOISE_UNAWARE_VMIN;
@@ -355,7 +355,7 @@ static int volt_policy_set_noiseaware_vmin(struct gk20a *g,
 
 	/* Execute the voltage change request via PMU RPC. */
 	status = volt_pmu_rpc_execute(g, &rpc_call);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"Error while executing VOLT_POLICY_SET_VOLTAGE RPC");
 		return -EINVAL;

drivers/gpu/nvgpu/volt/volt_pmu.h

@@ -24,23 +24,23 @@
 #define NVGPU_VOLT_PMU_H
 
 u32 volt_pmu_send_load_cmd_to_pmu(struct gk20a *g);
-u32 volt_set_voltage(struct gk20a *g, u32 logic_voltage_uv,
+int volt_set_voltage(struct gk20a *g, u32 logic_voltage_uv,
 		u32 sram_voltage_uv);
-u32 volt_get_voltage(struct gk20a *g, u32 volt_domain, u32 *voltage_uv);
+int volt_get_voltage(struct gk20a *g, u32 volt_domain, u32 *voltage_uv);
 int volt_set_noiseaware_vmin(struct gk20a *g, u32 logic_voltage_uv,
 		u32 sram_voltage_uv);
 
-u32 nvgpu_volt_set_voltage_gp10x(struct gk20a *g, u32 logic_voltage_uv,
+int nvgpu_volt_set_voltage_gp10x(struct gk20a *g, u32 logic_voltage_uv,
 	u32 sram_voltage_uv);
-u32 nvgpu_volt_rail_get_voltage_gp10x(struct gk20a *g,
+int nvgpu_volt_rail_get_voltage_gp10x(struct gk20a *g,
 	u8 volt_domain, u32 *pvoltage_uv);
-u32 nvgpu_volt_send_load_cmd_to_pmu_gp10x(struct gk20a *g);
+int nvgpu_volt_send_load_cmd_to_pmu_gp10x(struct gk20a *g);
 
-u32 nvgpu_volt_set_voltage_gv10x(struct gk20a *g, u32 logic_voltage_uv,
+int nvgpu_volt_set_voltage_gv10x(struct gk20a *g, u32 logic_voltage_uv,
 	u32 sram_voltage_uv);
-u32 nvgpu_volt_rail_get_voltage_gv10x(struct gk20a *g,
+int nvgpu_volt_rail_get_voltage_gv10x(struct gk20a *g,
 	u8 volt_domain, u32 *pvoltage_uv);
-u32 nvgpu_volt_send_load_cmd_to_pmu_gv10x(struct gk20a *g);
+int nvgpu_volt_send_load_cmd_to_pmu_gv10x(struct gk20a *g);
 
 
 #endif /* NVGPU_VOLT_PMU_H */

drivers/gpu/nvgpu/volt/volt_policy.c

@@ -44,7 +44,7 @@ static int construct_volt_policy(struct gk20a *g,
 	int status = 0;
 
 	status = boardobj_construct_super(g, ppboardobj, size, pArgs);
-	if (status) {
+	if (status != 0) {
 		return status;
 	}
 
@@ -64,7 +64,7 @@ static int construct_volt_policy_split_rail(struct gk20a *g,
 	int status = 0;
 
 	status = construct_volt_policy(g, ppboardobj, size, pArgs);
-	if (status) {
+	if (status != 0) {
 		return status;
 	}
 
@@ -89,7 +89,7 @@ static int construct_volt_policy_single_rail(struct gk20a *g,
 	int status = 0;
 
 	status = construct_volt_policy(g, ppboardobj, size, pArgs);
-	if (status) {
+	if (status != 0) {
 		return status;
 	}
 
@@ -108,7 +108,7 @@ static int volt_policy_pmu_data_init_single_rail(struct gk20a *g,
 	struct nv_pmu_volt_volt_policy_sr_boardobj_set *pset;
 
 	status = volt_policy_pmu_data_init_super(g, pboardobj, ppmudata);
-	if (status) {
+	if (status != 0) {
 		goto done;
 	}
 
@@ -146,7 +146,7 @@ static int volt_policy_pmu_data_init_sr_multi_step(struct gk20a *g,
 	struct nv_pmu_volt_volt_policy_sr_multi_step_boardobj_set *pset;
 
 	status = volt_policy_pmu_data_init_single_rail(g, pboardobj, ppmudata);
-	if (status) {
+	if (status != 0) {
 		goto done;
 	}
 
@@ -172,7 +172,7 @@ static int volt_construct_volt_policy_single_rail_multi_step(struct gk20a *g,
 	int status = 0;
 
 	status = construct_volt_policy_single_rail(g, ppboardobj, size, pargs);
-	if (status) {
+	if (status != 0) {
 		return status;
 	}
 
@@ -200,7 +200,7 @@ static int volt_policy_pmu_data_init_split_rail(struct gk20a *g,
 	struct nv_pmu_volt_volt_policy_splt_r_boardobj_set *pset;
 
 	status = volt_policy_pmu_data_init_super(g, pboardobj, ppmudata);
-	if (status) {
+	if (status != 0) {
 		goto done;
 	}
 
@@ -226,7 +226,7 @@ static int volt_construct_volt_policy_split_rail_single_step(struct gk20a *g,
 	int status = 0;
 
 	status = construct_volt_policy_split_rail(g, ppboardobj, size, pargs);
-	if (status) {
+	if (status != 0) {
 		return status;
 	}
 
@@ -247,7 +247,7 @@ static struct voltage_policy *volt_volt_policy_construct(struct gk20a *g, void *
 			&pboard_obj,
 			sizeof(struct voltage_policy_split_rail_single_step),
 			pargs);
-		if (status) {
+		if (status != 0) {
 			nvgpu_err(g,
 				"Could not allocate memory for voltage_policy");
 			pboard_obj = NULL;
@@ -258,7 +258,7 @@ static struct voltage_policy *volt_volt_policy_construct(struct gk20a *g, void *
 			&pboard_obj,
 			sizeof(struct voltage_policy_single_rail_multi_step),
 			pargs);
-		if (status) {
+		if (status != 0) {
 			nvgpu_err(g,
 				"Could not allocate memory for voltage_policy");
 			pboard_obj = NULL;
@@ -394,7 +394,7 @@ static int volt_get_volt_policy_table(struct gk20a *g,
 		status = boardobjgrp_objinsert(
 				&pvolt_policy_metadata->volt_policies.super,
 				(struct boardobj *)ppolicy, i);
-		if (status) {
+		if (status != 0) {
 			nvgpu_err(g,
 				"could not add volt_policy for entry %d into boardobjgrp ",
 				i);
@@ -457,7 +457,7 @@ static int _volt_policy_grp_pmudatainit_super(struct gk20a *g,
 	int status = 0;
 
 	status = boardobjgrp_pmudatainit_e32(g, pboardobjgrp, pboardobjgrppmu);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error updating pmu boardobjgrp for volt policy 0x%x",
 			 status);
@@ -499,7 +499,7 @@ int volt_policy_sw_setup(struct gk20a *g)
 
 	status = boardobjgrpconstruct_e32(g,
 			&g->perf_pmu.volt.volt_policy_metadata.volt_policies);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error creating boardobjgrp for volt rail, status - 0x%x",
 			status);
@@ -516,7 +516,7 @@ int volt_policy_sw_setup(struct gk20a *g)
 	/* Obtain Voltage Rail Table from VBIOS */
 	status = volt_get_volt_policy_table(g, &g->perf_pmu.volt.
 			volt_policy_metadata);
-	if (status) {
+	if (status != 0) {
 		goto done;
 	}
 
@@ -525,7 +525,7 @@ int volt_policy_sw_setup(struct gk20a *g)
 
 	status = BOARDOBJGRP_PMU_CMD_GRP_SET_CONSTRUCT(g, pboardobjgrp,
 			volt, VOLT, volt_policy, VOLT_POLICY);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error constructing PMU_BOARDOBJ_CMD_GRP_SET interface - 0x%x",
 			status);
@@ -535,7 +535,7 @@ int volt_policy_sw_setup(struct gk20a *g)
 	status = BOARDOBJGRP_PMU_CMD_GRP_GET_STATUS_CONSTRUCT(g,
 		&g->perf_pmu.volt.volt_policy_metadata.volt_policies.super,
 			volt, VOLT, volt_policy, VOLT_POLICY);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error constructing PMU_BOARDOBJ_CMD_GRP_SET interface - 0x%x",
 			status);

drivers/gpu/nvgpu/volt/volt_rail.c

@@ -53,10 +53,10 @@ u8 volt_rail_volt_domain_convert_to_idx(struct gk20a *g, u8 volt_domain)
 	return CTRL_BOARDOBJ_IDX_INVALID;
 }
 
-u32 volt_rail_volt_dev_register(struct gk20a *g, struct voltage_rail
+int volt_rail_volt_dev_register(struct gk20a *g, struct voltage_rail
 	*pvolt_rail, u8 volt_dev_idx, u8 operation_type)
 {
-	u32 status = 0;
+	int status = 0;
 
 	if (operation_type == CTRL_VOLT_DEVICE_OPERATION_TYPE_DEFAULT) {
 		if (pvolt_rail->volt_dev_idx_default ==
@@ -90,17 +90,17 @@ u32 volt_rail_volt_dev_register(struct gk20a *g, struct voltage_rail
 			volt_dev_idx);
 
 exit:
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g, "Failed to register VOLTAGE_DEVICE");
 	}
 
 	return status;
 }
 
-static u32 volt_rail_state_init(struct gk20a *g,
+static int volt_rail_state_init(struct gk20a *g,
 		struct voltage_rail *pvolt_rail)
 {
-	u32 status = 0;
+	int status = 0;
 	u32 i;
 
 	pvolt_rail->volt_dev_idx_default = CTRL_BOARDOBJ_IDX_INVALID;
@@ -122,7 +122,7 @@ static u32 volt_rail_state_init(struct gk20a *g,
 		NV_PMU_PERF_RPC_VFE_EQU_MONITOR_COUNT_MAX;
 
 	status = boardobjgrpmask_e32_init(&pvolt_rail->volt_dev_mask, NULL);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"Failed to initialize BOARDOBJGRPMASK of VOLTAGE_DEVICEs");
 	}
@@ -141,7 +141,7 @@ static int volt_rail_init_pmudata_super(struct gk20a *g,
 	nvgpu_log_info(g, " ");
 
 	status = boardobj_pmudatainit_super(g, board_obj_ptr, ppmudata);
-	if (status) {
+	if (status != 0) {
 		return status;
 	}
 
@@ -170,7 +170,7 @@ static int volt_rail_init_pmudata_super(struct gk20a *g,
 	status = boardobjgrpmask_export(&prail->volt_dev_mask.super,
 				prail->volt_dev_mask.super.bitcount,
 				&rail_pmu_data->volt_dev_mask.super);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"Failed to export BOARDOBJGRPMASK of VOLTAGE_DEVICEs");
 	}
@@ -190,7 +190,7 @@ static struct voltage_rail *construct_volt_rail(struct gk20a *g, void *pargs)
 	nvgpu_log_info(g, " ");
 	status = boardobj_construct_super(g, &board_obj_ptr,
 		sizeof(struct voltage_rail), pargs);
-	if (status) {
+	if (status != 0) {
 		return NULL;
 	}
 
@@ -424,7 +424,7 @@ int volt_rail_sw_setup(struct gk20a *g)
 
 	status = boardobjgrpconstruct_e32(g,
 			&g->perf_pmu.volt.volt_rail_metadata.volt_rails);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error creating boardobjgrp for volt rail, status - 0x%x",
 			status);
@@ -442,7 +442,7 @@ int volt_rail_sw_setup(struct gk20a *g)
 	/* Obtain Voltage Rail Table from VBIOS */
 	status = volt_get_volt_rail_table(g, &g->perf_pmu.volt.
 			volt_rail_metadata);
-	if (status) {
+	if (status != 0) {
 		goto done;
 	}
 
@@ -451,7 +451,7 @@ int volt_rail_sw_setup(struct gk20a *g)
 
 	status = BOARDOBJGRP_PMU_CMD_GRP_SET_CONSTRUCT(g, pboardobjgrp,
 			volt, VOLT, volt_rail, VOLT_RAIL);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error constructing PMU_BOARDOBJ_CMD_GRP_SET interface - 0x%x",
 			status);
@@ -461,7 +461,7 @@ int volt_rail_sw_setup(struct gk20a *g)
 	status = BOARDOBJGRP_PMU_CMD_GRP_GET_STATUS_CONSTRUCT(g,
 		&g->perf_pmu.volt.volt_rail_metadata.volt_rails.super,
 			volt, VOLT, volt_rail, VOLT_RAIL);
-	if (status) {
+	if (status != 0) {
 		nvgpu_err(g,
 			"error constructing PMU_BOARDOBJ_CMD_GRP_SET interface - 0x%x",
 			status);
@@ -473,7 +473,7 @@ int volt_rail_sw_setup(struct gk20a *g)
 			       volt_rails.super),
 			     struct voltage_rail *, pvolt_rail, i) {
 		status = volt_rail_state_init(g, pvolt_rail);
-		if (status) {
+		if (status != 0) {
 			nvgpu_err(g,
 				"Failure while executing RAIL's state init railIdx = %d",
 				i);

drivers/gpu/nvgpu/volt/volt_rail.h

@@ -80,7 +80,7 @@ struct voltage_rail_metadata {
 u8 volt_rail_vbios_volt_domain_convert_to_internal
 	(struct gk20a *g, u8 vbios_volt_domain);
 
-u32 volt_rail_volt_dev_register(struct gk20a *g, struct voltage_rail
+int volt_rail_volt_dev_register(struct gk20a *g, struct voltage_rail
 	*pvolt_rail, u8 volt_dev_idx, u8 operation_type);
 
 u8 volt_rail_volt_domain_convert_to_idx(struct gk20a *g, u8 volt_domain);