nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 18:42:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: fix MISRA violations in atomic unit

Browse Source 
MISRA rule 20.7 requires macro paramaters to be wrapped in parantheses
when the parameter expands into an expression.  Fix violations of rule
20.7 in atomic unit.
MISRA rule 10.3 prohibits the assignment of the value of an expression
to an object with narrower essential type or of a different essential
type category.  Fix violations of rule 10.3 in atomic unit.

Jira NVGPU-3296

Change-Id: I087a6d15c5d03885aea29f22853e5bbde7880014
Signed-off-by: ajesh <akv@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2116306
GVS: Gerrit_Virtual_Submit
Reviewed-by: Philip Elcan <pelcan@nvidia.com>
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
ajesh
2019-05-10 12:28:40 +05:30
committed by mobile promotions
parent defc27ac9b
commit de9e914670
1 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
drivers/gpu/nvgpu/include/nvgpu/posix/atomic.h
View File

@@ -47,49 +47,49 @@ typedef struct __nvgpu_posix_atomic64 {
* between the 32bit and 64bit cases.
* The static inline functions are maintained to provide type checking.
*/
#define NVGPU_POSIX_ATOMIC_SET(v, i) atomic_store(&(v->v), i)
#define NVGPU_POSIX_ATOMIC_SET(v, i) atomic_store(&((v)->v), (i))
#define NVGPU_POSIX_ATOMIC_READ(v) atomic_load(&(v->v))
#define NVGPU_POSIX_ATOMIC_READ(v) atomic_load(&((v)->v))
#define NVGPU_POSIX_ATOMIC_ADD_RETURN(v, i) \
({ \
typeof(v->v) tmp; \
typeof((v)->v) tmp; \
\
tmp = atomic_fetch_add(&(v->v), i); \
tmp += i; \
tmp = (typeof((v)->v))atomic_fetch_add(&((v)->v), (i)); \
tmp += (i); \
tmp; \
})
#define NVGPU_POSIX_ATOMIC_SUB_RETURN(v, i) \
({ \
typeof(v->v) tmp; \
typeof((v)->v) tmp; \
\
tmp = atomic_fetch_sub(&(v->v), i); \
tmp -= i; \
tmp = (typeof((v)->v))atomic_fetch_sub(&((v)->v), (i)); \
tmp -= (i); \
tmp; \
})
#define NVGPU_POSIX_ATOMIC_CMPXCHG(v, old, new) \
#define NVGPU_POSIX_ATOMIC_CMPXCHG(v, old, new) \
({ \
typeof(v->v) tmp = old; \
typeof((v)->v) tmp = (old); \
\
atomic_compare_exchange_strong(&(v->v), &tmp, new); \
atomic_compare_exchange_strong(&((v)->v), &tmp, (new)); \
tmp; \
})
#define NVGPU_POSIX_ATOMIC_XCHG(v, new) atomic_exchange(&(v->v), new)
#define NVGPU_POSIX_ATOMIC_XCHG(v, new) atomic_exchange(&((v)->v), (new))
#define NVGPU_POSIX_ATOMIC_ADD_UNLESS(v, a, u) \
#define NVGPU_POSIX_ATOMIC_ADD_UNLESS(v, a, u) \
({ \
typeof(v->v) old; \
typeof((v)->v) old; \
\
do { \
old = atomic_load(&(v->v)); \
if (old == u) { \
old = atomic_load(&((v)->v)); \
if (old == (u)) { \
break; \
} \
} while (!atomic_compare_exchange_strong(&(v->v), &old, \
old + a)); \
} while (!atomic_compare_exchange_strong(&((v)->v), \
&old, old + (a))); \
old; \
})
@@ -262,10 +262,10 @@ static inline bool nvgpu_atomic64_sub_and_test_impl(long x, nvgpu_atomic64_t *v)
*/
#define cmpxchg(p, old, new) \
({ \
typeof(*(p)) tmp = old; \
typeof(*(p)) tmp = (old); \
\
(void) nvgpu_atomic_cmpxchg((nvgpu_atomic_t *) p, tmp, \
new); \
(void) nvgpu_atomic_cmpxchg((nvgpu_atomic_t *) (p), tmp,\
(new)); \
tmp; \
})