nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 10:34:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: mm: fix CERT-C INT31 violations in page_allocator

Browse Source 
CERT-C Rule INT31 requires checking that no data is lost when doing
casts, so use the safe cast operations in page_allocator.c

JIRA NVGPU-3586

Change-Id: I0cf0de7eda0c117a65a08930dbc70f9c699a0219
Signed-off-by: Philip Elcan <pelcan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2131159
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-misra <svc-mobile-misra@nvidia.com>
Reviewed-by: Alex Waterman <alexw@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Nitin Kumbhar <nkumbhar@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Philip Elcan
2019-06-05 15:04:21 -04:00
committed by mobile promotions
parent 0a645e66ee
commit fbbfc9717f
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/gpu/nvgpu/common/mm/allocators/page_allocator.c
View File

@@ -306,7 +306,8 @@ static struct page_alloc_slab_page *alloc_slab_page(
nvgpu_init_list_node(&slab_page->list_entry);
slab_page->slab_size = slab->slab_size;
slab_page->nr_objects = (u32)a->page_size / slab->slab_size;
slab_page->nr_objects = nvgpu_safe_cast_u64_to_u32(a->page_size) /
slab->slab_size;
slab_page->nr_objects_alloced = 0;
slab_page->owner = slab;
slab_page->state = SP_NONE;
@@ -484,8 +485,9 @@ static void nvgpu_free_slab(struct nvgpu_page_allocator *a,
enum slab_page_state new_state;
u32 offs;
offs = (u32)nvgpu_safe_sub_u64(alloc->base, slab_page->page_addr) /
slab_page->slab_size;
offs = nvgpu_safe_cast_u64_to_u32(nvgpu_safe_sub_u64(alloc->base,
slab_page->page_addr)) /
slab_page->slab_size;
nvgpu_bitmap_clear(&slab_page->bitmap, offs, 1U);
nvgpu_assert(slab_page->nr_objects_alloced < U32_MAX);
@@ -1009,7 +1011,7 @@ static int nvgpu_page_alloc_init_slabs(struct nvgpu_page_allocator *a)
{
/* Use temp var for MISRA 10.8 */
unsigned long tmp_nr_slabs = ilog2(a->page_size >> 12);
u32 nr_slabs = U32(tmp_nr_slabs);
u32 nr_slabs = nvgpu_safe_cast_u64_to_u32(tmp_nr_slabs);
u32 i;
/*
@@ -1080,7 +1082,7 @@ int nvgpu_page_allocator_init(struct gk20a *g, struct nvgpu_allocator *na,
a->base = base;
a->length = length;
a->page_size = blk_size;
a->page_shift = U32((ffs(blk_size) - 1UL));
a->page_shift = nvgpu_safe_cast_u64_to_u32((ffs(blk_size) - 1UL));
a->allocs = NULL;
a->owner = na;
a->flags = flags;