nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 10:34:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: fix MISRA 17.7 violation in nvgpu.common.mm.mm

Browse Source 
Below MISRA 17.7 violation is reported in nvgpu.common.mm.mm

${TEGRA_TOP}/kernel/nvgpu/drivers/gpu/nvgpu/common/mm/mm.c:645:
misra_c_2012_rule_17_7: The return value of a non-void function
"*g->ops.bus.bar1_bind" is unused.

Fix this by checking return value and returning an error in
case of failure.

Jira NVGPU-3331

Change-Id: Iab43d630163af782d3cc87989a64062516a4cd92
Signed-off-by: Thomas Fleury <tfleury@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2116706
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vinod Gopalakrishnakurup <vinodg@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Thomas Fleury
2019-05-10 11:29:29 -07:00
committed by mobile promotions
parent 4cd0e88065
commit 310471bf77
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/nvgpu/common/mm/mm.c
View File

@@ -642,7 +642,10 @@ int nvgpu_mm_setup_hw(struct gk20a *g)
g->ops.fb.init_hw(g);
if (g->ops.bus.bar1_bind != NULL) {
g->ops.bus.bar1_bind(g, &mm->bar1.inst_block);
err = g->ops.bus.bar1_bind(g, &mm->bar1.inst_block);
if (err != 0) {
return err;
}
}
if (g->ops.bus.bar2_bind != NULL) {