nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 10:34:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: Fix MISRA 17.7 violations for PMU-FW unit

Browse Source 
- Rule 17.7 states that the value returned by a
  function having non-void return type shall be used.
- Fix this violation by proper error handling.

JIRA NVGPU-3419

Change-Id: Ia66906747cc2a95ea7f1ce5da16e4251ff521e53
Signed-off-by: Divya Singhatwaria <dsinghatwari@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2121936
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-misra <svc-mobile-misra@nvidia.com>
Reviewed-by: Sagar Kamble <skamble@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vaibhav Kachore <vkachore@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Divya Singhatwaria
2019-05-17 14:47:09 +05:30
committed by mobile promotions
parent 1e570d5a16
commit 3e5fda3730
1 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/gpu/nvgpu/common/pmu/fw/fw_ns_bootstrap.c
View File

@@ -56,6 +56,20 @@ exit:
return err;
}
static void pmu_free_ns_ucode_blob(struct gk20a *g)
{
struct nvgpu_pmu *pmu = g->pmu;
struct mm_gk20a *mm = &g->mm;
struct vm_gk20a *vm = mm->pmu.vm;
struct pmu_rtos_fw *rtos_fw = pmu->fw;
nvgpu_log_fn(g, " ");
if (nvgpu_mem_is_valid(&rtos_fw->ucode)) {
nvgpu_dma_unmap_free(vm, &rtos_fw->ucode);
}
}
int nvgpu_pmu_ns_fw_bootstrap(struct gk20a *g, struct nvgpu_pmu *pmu)
{
int err;
@@ -70,7 +84,14 @@ int nvgpu_pmu_ns_fw_bootstrap(struct gk20a *g, struct nvgpu_pmu *pmu)
/* Do non-secure PMU boot */
nvgpu_mutex_acquire(&pmu->isr_mutex);
nvgpu_falcon_reset(pmu->flcn);
err = nvgpu_falcon_reset(pmu->flcn);
if (err != 0) {
nvgpu_err(g, "falcon reset failed");
/* free the ns ucode blob */
pmu_free_ns_ucode_blob(g);
nvgpu_mutex_release(&pmu->isr_mutex);
return err;
}
pmu->isr_enabled = true;
nvgpu_mutex_release(&pmu->isr_mutex);