nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-24 10:34:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: ptimer: fix CERT-C violations

Browse Source 
Rule INT30-C requires that unsigned integer operations do not
wrap. Fix these violations by using the safe ops.
Rule INT31-C requires that integer conversions do not result in lost or
misinterpreted data.
Rule INT33-C requires ensurance that division does not divide by 0.
Fix violations of these types in ptimer.

JIRA NVGPU-3868

Change-Id: Ib513da20eb14fa058630aa7a1f0aa5002373dd08
Signed-off-by: Philip Elcan <pelcan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/2168575
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vinod Gopalakrishnakurup <vinodg@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Philip Elcan
2019-08-02 13:53:38 -04:00
committed by mobile promotions
parent 345ffb47e4
commit 390695e67e
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/gpu/nvgpu/include/nvgpu/ptimer.h
View File

@@ -23,6 +23,7 @@
#define NVGPU_PTIMER_H
#include <nvgpu/types.h>
#include <nvgpu/safe_ops.h>
struct gk20a;
@@ -37,12 +38,14 @@ struct nvgpu_cpu_time_correlation_sample {
static inline u32 ptimer_scalingfactor10x(u32 ptimer_src_freq)
{
return U32((U64(PTIMER_REF_FREQ_HZ) * U64(10)) / U64(ptimer_src_freq));
return nvgpu_safe_cast_u64_to_u32((U64(PTIMER_REF_FREQ_HZ) * U64(10))
/ U64(ptimer_src_freq));
}
static inline u32 scale_ptimer(u32 timeout , u32 scale10x)
{
if (((timeout*10U) % scale10x) >= (scale10x/2U)) {
nvgpu_assert(scale10x != 0U);
if ((nvgpu_safe_mult_u32(timeout, 10U) % scale10x) >= (scale10x/2U)) {
return ((timeout * 10U) / scale10x) + 1U;
} else {
return (timeout * 10U) / scale10x;